Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210312105530.2219008-1-lee.jones@linaro.org> <20210312105530.2219008-7-lee.jones@linaro.org>
In-Reply-To: <20210312105530.2219008-7-lee.jones@linaro.org>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Fri, 19 Mar 2021 15:56:19 +0100
Message-ID: <CAK8P3a234A2WmPFJxXmf-n+J7TP3A=DyDWEr657zxaML7V9UWQ@mail.gmail.com>
Subject: Re: [PATCH 06/11] block: drbd: drbd_main: Remove duplicate field initialisation
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Philipp Reisner <philipp.reisner@linbit.com>,
        Lars Ellenberg <lars.ellenberg@linbit.com>,
        Jens Axboe <axboe@kernel.dk>, drbd-dev@lists.linbit.com,
        linux-block <linux-block@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Mar 12, 2021 at 11:57 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> [P_RETRY_WRITE] is initialised more than once.
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/block/drbd/drbd_main.c: In function =E2=80=98cmdname=E2=80=99:
>  drivers/block/drbd/drbd_main.c:3660:22: warning: initialized field overw=
ritten [-Woverride-init]
>  drivers/block/drbd/drbd_main.c:3660:22: note: (near initialization for =
=E2=80=98cmdnames[44]=E2=80=99)
>
> Cc: Philipp Reisner <philipp.reisner@linbit.com>
> Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: drbd-dev@lists.linbit.com
> Cc: linux-block@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Looks correct. I had actually posted a slightly different fix last year,
but either one addresses the warning:

https://lore.kernel.org/lkml/20201026215043.3893318-1-arnd@kernel.org/

         Arnd