Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751145AbWJEUIH (ORCPT ); Thu, 5 Oct 2006 16:08:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751189AbWJEUIH (ORCPT ); Thu, 5 Oct 2006 16:08:07 -0400 Received: from fep32-0.kolumbus.fi ([193.229.0.63]:24159 "EHLO fep32-app.kolumbus.fi") by vger.kernel.org with ESMTP id S1751145AbWJEUIE (ORCPT ); Thu, 5 Oct 2006 16:08:04 -0400 Date: Thu, 5 Oct 2006 23:07:52 +0300 (EEST) From: Kai Makisara X-X-Sender: makisara@kai.makisara.local To: Jeff Garzik cc: linux-scsi@vger.kernel.org, Andrew Morton , LKML Subject: Re: [PATCH] SCSI st: fix error handling in module init, sysfs In-Reply-To: <20061004100037.GA16915@havoc.gtf.org> Message-ID: References: <20061004100037.GA16915@havoc.gtf.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 989 Lines: 34 On Wed, 4 Oct 2006, Jeff Garzik wrote: > > - Notice and handle sysfs errors in module init, tape init > > - Properly unwind errors in module init > > - Remove bogus st_sysfs_class==NULL test, it is guaranteed !NULL at that point > > Signed-off-by: Jeff Garzik > Acked-by: Kai Makisara > --- > > drivers/scsi/st.c | 115 ++++++++++++++++++++++++++++++++++++------------------ > 1 files changed, 78 insertions(+), 37 deletions(-) > > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c > index 7f669b6..3babdc7 100644 > --- a/drivers/scsi/st.c > +++ b/drivers/scsi/st.c > @@ -195,9 +195,9 @@ static int sgl_unmap_user_pages(struct s > static int st_probe(struct device *); ... Thanks, Kai - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/