Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1520229pxf; Fri, 19 Mar 2021 08:53:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxczEiELpq14h+AxbaubWwmY4cQDH9MHfwGiSFcCF/W+vSBO07adTKdsMUIT1sTeSi+KKl5 X-Received: by 2002:a17:906:5e55:: with SMTP id b21mr5125783eju.289.1616169207653; Fri, 19 Mar 2021 08:53:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616169207; cv=none; d=google.com; s=arc-20160816; b=FYLSyZS9yHmyNFSZDK45TnaMfTfpjpsHqWKWpXkctFWRjS14B6BN/6PkNm9AOGPRjm gcCp5mxCQcI9mTMKsxGNvIcZ0gWE1/43s91JBTkccsdG1BUtfDLl2/sLiU+xSurDNJ93 8KggJfUrNJqKf0s2POua6giLB9W6AB6IW9skx2Rrta8jsfQaLKqDRJMbqTgTtlyt3UAW a5y9fIsXVySijSTZ0v2rRwIUX9lqF0iaYjWksQaOK7zQ53fKKHbpOoiKCKKLVskj50Qm qUuH0k15MTxEuzIalOPTgov6ivur+lbXbFY317lRp5beVdZpsUSeyriMSvg+VdDDozo+ 2Dtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kMjEDPbpygnC4Zgi7zZrR1DkHP0YbRZnHQE2aFdwmCU=; b=c3+lAfJB54Dp6o1Zsk0u+JDUjzrrkNJeRt6Sow1hC3bbf85XZOWGbYg2lT0eXDWnGP xhuxTL5+3uZGARNnmLj0BOdv1nzgti68/ZCX+PcJKaZdb43bWNmbzfGTLmrmokTdFjeR z1PM1F5j4/qBcbFI74XzIkJXQ/cj6lvNCBtUczeh2eyOBmbSTEE7D9uVesGjSVLt2qkG rJf+6CIW78KXkdBD7bmGH8Ao3xuJmP6XRF55X5KwBraUE0DTR6ZZcO89Xuvb61WJL7u+ 6gxaL3hfsGCV9gDLEaRdFq5j4TSSe4nOcEDEbvBuKdwO2hRIOXcQINukAnS+59y6iQ6L XmvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mS5zw8Oe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f9si4735482ejk.446.2021.03.19.08.53.05; Fri, 19 Mar 2021 08:53:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mS5zw8Oe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230442AbhCSPwS (ORCPT + 99 others); Fri, 19 Mar 2021 11:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbhCSPwB (ORCPT ); Fri, 19 Mar 2021 11:52:01 -0400 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23358C06174A; Fri, 19 Mar 2021 08:52:01 -0700 (PDT) Received: by mail-qk1-x72f.google.com with SMTP id y5so1779456qkl.9; Fri, 19 Mar 2021 08:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kMjEDPbpygnC4Zgi7zZrR1DkHP0YbRZnHQE2aFdwmCU=; b=mS5zw8Oe01ntEFj6jOCIzJO5fCGguYLRvG33EOKUjDHhWRPAzsPS7zPWWuk8wm+kIF VEiinXvyfr+0//VQOES7tV0CCW1ygzZn7yqOuO5/FcZyRhFBVQxn00utV6zHJGry9o/3 5fdHlpfeitvN7sPd//kY6N9N7ua1e7JMjSoqmcyz0R+AO5Vh/kcwoLU09BDodvIpsZpx wGWtpwxlNPa0xXruw7FwaTcG9Vbidy2k20bgYQ211E5IA6SgHS9qyfuyTkWxZhowyktn L7CfTfy60IQJayYRFAEXiehOpMyBdb04GAwUyHD6QEhbobKnWliXF7gSkHRfJAK/50yW axzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kMjEDPbpygnC4Zgi7zZrR1DkHP0YbRZnHQE2aFdwmCU=; b=JV6aR1wpuyr+VEbvgydY39ZC/UMnYM1NRUTkg7ncB7qRxN423dJtuzE9zuWfO12cbD 2rcSPIgfRt9xdCwCmY3rqIAm9G1rFnTpR6Tb84B9u9Y+kcdO55a9cnbZGToHMMtWabZR j84YGMczxR1vOYHOCJz1HYi+HHwa3NjkCOAualNDeqdc1In/6Sbz0sGStT6YGD9dPEON vazACvZLhOMzQS6B5WqWiQnTe+qHfono72AAWUK2CJEB4jBIf1yVkuEpEwR4cZrjSVeM f+Tujfm7P9NrDiTo8l30YTS9wQsRDR4RTy3l4+ONugNXD0008oqskwXnu3PwT/v2PqgJ m67w== X-Gm-Message-State: AOAM532JQ0TqPLbXOYFoSTlhguPX6+UlxlilF+HSSOmfQHfMLeEKpzFp AhIe5Dm50RnRgri/jlyN9KI= X-Received: by 2002:a05:620a:1235:: with SMTP id v21mr10018945qkj.305.1616169120455; Fri, 19 Mar 2021 08:52:00 -0700 (PDT) Received: from dschatzberg-fedora-PC0Y6AEN.dhcp.thefacebook.com ([2620:10d:c091:480::1:41da]) by smtp.gmail.com with ESMTPSA id j26sm4017062qtp.30.2021.03.19.08.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 08:52:00 -0700 (PDT) Date: Fri, 19 Mar 2021 11:51:58 -0400 From: Dan Schatzberg To: Jens Axboe Cc: Colin King , linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call Message-ID: References: <20210318151626.17442-1-colin.king@canonical.com> <13a1d187-4d6d-9e06-b94a-553d872de756@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13a1d187-4d6d-9e06-b94a-553d872de756@kernel.dk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 18, 2021 at 02:12:10PM -0600, Jens Axboe wrote: > On 3/18/21 9:16 AM, Colin King wrote: > > From: Colin Ian King > > > > The 3rd argument to alloc_workqueue should be the max_active count, > > however currently it is the lo->lo_number that is intended for the > > loop%d number. Fix this by adding in the missing max_active count. > > Dan, please fold this (or something similar) in when you're redoing the > series. > > -- > Jens Axboe > Will do.