Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1522098pxf; Fri, 19 Mar 2021 08:56:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztgZr5aD+QO4dxRsikL4kznLZcnlSXgwTe+G3yfrTmHloLRHjgP6YLGB2WQVi3ucwKh1oe X-Received: by 2002:aa7:c88e:: with SMTP id p14mr2897743eds.119.1616169373372; Fri, 19 Mar 2021 08:56:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616169373; cv=none; d=google.com; s=arc-20160816; b=W5lKgqrp3rEfCJ9TXyeNXpKTgxH6i8F5m/SymxyDB8z9br3bUJxMLHJ8iG88tpPJM1 mxwis8fpTQtceTyzoaRNdX+EOpfjkyYTJL+1wckR2OWaksf94f7PWcEX4ThUcpv+Gu8o B+SRuaWFmR3IPHH1u0DG4ZiFJV1w3oT6sUdi0bWisDXmFh5vMzCXKkGfl/0bTEQr780S 7lJwnYPQJb5VfTjOpSkQqET8fRBp4MGHvQwiJCtuqYHjcssqCKtxTFSYZqnFWBHGnBeR Eq7IcKw1KVG619z8PgJR7FLTPEonLVVvdIM1V/kEHl8Vfi/ZZQXcwnHIJAqkXhca/VV9 Qwrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0wTT4qv7QZfT/ekLjj+h5aDeBVAVnGNSzJpRlOxQ/w4=; b=f1wmYpqgkrerdSOidwlnQ57vF49qQpWw1SbHGUIUxPUZgBMOAV2BMGHLmQJOUn/LYU neFoEO4GsnP3Kv8njq8q/pKTtrg2uNmr+lJbTCkEt7gXjgy+dZAMqWX5H7zTE6SmUs6/ i6sTgEhz4r0Zb4z088I2mIH6kdaomBisMRoiGegz6PPpnXexS3nwJUTDc3UStb8NNcqa jfU3tafMcVy/JuCZkUlP5T+010CZ6za/l/6imPocdlzPnoZ60FXIRmnLdyJ6wFxiWMnY iMiIRaEsPTZMs8JEEQWdpMq9YwOjomxVR7esZH1yr4z8NL5DbXDZwpXdmIRwYFjJ3Gci eakw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ox6QMurZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j19si4103107edp.531.2021.03.19.08.55.51; Fri, 19 Mar 2021 08:56:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ox6QMurZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230348AbhCSPyU (ORCPT + 99 others); Fri, 19 Mar 2021 11:54:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230215AbhCSPyJ (ORCPT ); Fri, 19 Mar 2021 11:54:09 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D345DC06174A; Fri, 19 Mar 2021 08:54:08 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id h7so7047298qtx.3; Fri, 19 Mar 2021 08:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0wTT4qv7QZfT/ekLjj+h5aDeBVAVnGNSzJpRlOxQ/w4=; b=Ox6QMurZ5IZAN/TtoTqMbrLf3ONKGl/ZJsf4fzZoPIzqWfwodhb/OZc01khel0XyjF ACP6ml5yTvw+KEGKQNvgxkrnE60meuRPR/Vgj8e1D7Mdq1YuhlPiOsdWlemwjKb/1X3C Bn9NZ3KXAO6QWbPzHgQrt9EjXwJnwHMd+Ke7Qv5J5FjLUsH/pL8/Zo+JmcZK189YVk34 e+1S2Sx+rgwLvRn+xQ6YngqOhNL3R+e3mKAU1p/b3Ov/DSqAOiFSJnuaiTRNKkci902Z X+QgLBAqfUTvRsLQo31NJ2QewfXdOBxDqB6GUudmQXErQlYj7n7WA+BX3/IRwNc8qjxZ btSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0wTT4qv7QZfT/ekLjj+h5aDeBVAVnGNSzJpRlOxQ/w4=; b=nY0DSeg8W/WdF5zcVHKXB9o1YZwpyNj7wI+XCFLMghMBwawJvVUmPAyln3T+WUMH++ S/lQjdc4TTzHdBGjjqLiBrl02lRr5/ssjrkI5zl6FdqmOl97pVlk8+H+GtbLU4PSG0Rb maI7LWQv5L64q7yz9GoyTCbSCJFzJDGE1CccvGNVFAGmF1ZFN0Rbv07SbEQ2UItRmZqj hI3tiDKuIyqWvHNcRwMy4O2r4/Yca0p0f77AdXkV0asMuqSIiITrs/o6K96lNuKte3kn WeI3ThxNssjX5/d2lmWfjK+C+cn3POyzIJBRs/hbt+PsV6Im4iHmeGr3RU22BVENnNbE 4/Sw== X-Gm-Message-State: AOAM532XJKma9HvOcncKvrFrpvu+x85VMKYeEssQwc/b0DraJ37HrOsi 2qWylP0qUgXx7Aty3DgxhFc= X-Received: by 2002:aed:2a82:: with SMTP id t2mr8657586qtd.217.1616169248159; Fri, 19 Mar 2021 08:54:08 -0700 (PDT) Received: from dschatzberg-fedora-PC0Y6AEN.dhcp.thefacebook.com ([2620:10d:c091:480::1:41da]) by smtp.gmail.com with ESMTPSA id h75sm4723533qke.80.2021.03.19.08.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 08:54:07 -0700 (PDT) Date: Fri, 19 Mar 2021 11:54:05 -0400 From: Dan Schatzberg To: Colin King Cc: Jens Axboe , linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call Message-ID: References: <20210318151626.17442-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210318151626.17442-1-colin.king@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 18, 2021 at 03:16:26PM +0000, Colin King wrote: > From: Colin Ian King > > The 3rd argument to alloc_workqueue should be the max_active count, > however currently it is the lo->lo_number that is intended for the > loop%d number. Fix this by adding in the missing max_active count. > Thanks for catching this Colin. I'm fairly new to kernel development. Is there some tool I could have run locally to catch this?