Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932066AbWJEU3y (ORCPT ); Thu, 5 Oct 2006 16:29:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932068AbWJEU3x (ORCPT ); Thu, 5 Oct 2006 16:29:53 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:47879 "HELO iolanthe.rowland.org") by vger.kernel.org with SMTP id S932066AbWJEU3x (ORCPT ); Thu, 5 Oct 2006 16:29:53 -0400 Date: Thu, 5 Oct 2006 16:29:51 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Pavel Machek cc: Duncan Sands , , , , , ueagle , matthieu castet Subject: Re: [linux-usb-devel] [PATCH 1/3] UEAGLE : be suspend friendly In-Reply-To: <20061005181426.GA27838@elf.ucw.cz> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1242 Lines: 39 On Thu, 5 Oct 2006, Pavel Machek wrote: > Hi! > > > > > Plug/unplug should be easy enough to simulate from usb driver, no? > > > > > > if a USB driver doesn't define suspend/resume methods, then the core simply > > > unplugs it on suspend, and replugs on resume (IIRC). > > > > No longer true, and IIRC it never was. All that happens is that URB > > submissions fail with -EHOSTUNREACH once the device is suspended. > > Could we get "old" behaviour for devices like this? "printk("please > unplug/replug me\n")" is not a good solution. I would much rather see this fixed in the driver itself. For the time being, a "dummy" suspend routine could look like this: static int foo_suspend(struct usb_interface *intf, pm_message_t msg) { up(&intf->dev.sem); device_release_driver(&intf->dev); down(&intf->dev.sem); return 0; } Getting reprobed during resume would be more difficult; it would need help from userspace. Maybe UEAGLE can do something a little more sensible... Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/