Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Mar 2021 16:48:23 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     William Kucharski <william.kucharski@oracle.com>
Cc:     netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
        Santosh Shilimkar <santosh.shilimkar@oracle.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] net/rds: correct socket tunable error in rds_tcp_tune()
Message-ID: <20210319164823.GA1124392@casper.infradead.org>
References: <20210317145204.7282-1-william.kucharski@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210317145204.7282-1-william.kucharski@oracle.com>
Precedence: bulk

On Wed, Mar 17, 2021 at 08:52:04AM -0600, William Kucharski wrote:
> Correct an error where setting /proc/sys/net/rds/tcp/rds_tcp_rcvbuf would
> instead modify the socket's sk_sndbuf and would leave sk_rcvbuf untouched.
> 
> Signed-off-by: William Kucharski <william.kucharski@oracle.com>

Looks like a pretty clear copy-n-paste error.  I think Coverity have
started looking for issues like this?

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Also, maybe,

Fixes: c6a58ffed536 ("RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket")