Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1576760pxf; Fri, 19 Mar 2021 10:11:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKpFGekNKsxUqCaSMQipR0TQkHeuK0alTKnCvIsJdkNvmnZeI5F7ysa7d2v+j5kSi64zki X-Received: by 2002:aa7:d484:: with SMTP id b4mr10900815edr.63.1616173862424; Fri, 19 Mar 2021 10:11:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616173862; cv=none; d=google.com; s=arc-20160816; b=s1C3KFRyBDtcDIP9USxOJVATd8bL2Iz2i4L6sPgERx3J/y29yYEn9zGLnSK0riLoOM lHqhthm/+i/NYXO2sNvE0nZIhtD/gdFvvo1u2rx5DdM0qbKEdqb+WvY/RXx5gbuC7Dpb erAxESLFhvVtldIMaTaFW9ww3C5NlTs3gm55DLy6ASzxqCtdq1F39xLg53RBJrKh9u33 VjRTi6TuYowYf0pAykUC6duTk2aQefmv3Eb7Uzgmgz5krJZ8hf3j44KvFGQU81Q/Ov+O IxrinR6/p+Amlr5ki0O9A4vgNHmuGApNOEF99iqEMyA/sEDzUIFJlDHfEc4f1JUHnOi7 Rt2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AikJF0GK0ZzYGbwbgBUzJRLCgyMvlKF2iA5mDBYu/f0=; b=JDYqat3L/EY6MS0ssHxH3DjUCav0RaEG2L4FtcBT+HHAYBxp+mWJ5SYy/hYRR3IhVG Cw5M4Itbh4Jte0ndAfejyEZYPoCm2XEQmb5B1j/wpMFKxN+F3WMG59RvWX4ySmI4g9T5 qDZBXX2OupJPOgy8knK0H87uvUZEXQsX4Ft3gtaAs84VZ6NLC/x0zJYCJC+wU5lU5KVz 8kel14s7sRjT8uHQDs7kT1QzEySsG/HPs6DEswsTigOAA3ncYFdzdscHTqccPJp9mtAf GTe/WvKKHjZvi3o1GT4ucZjdn6paL0SDjyD7w91SrM8DUOrVRFVtFiPOuP9dpxB23ocZ ewmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=atYHlbts; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h18si4776056ejd.89.2021.03.19.10.10.39; Fri, 19 Mar 2021 10:11:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=atYHlbts; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230288AbhCSRJn (ORCPT + 99 others); Fri, 19 Mar 2021 13:09:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230154AbhCSRJM (ORCPT ); Fri, 19 Mar 2021 13:09:12 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 090E7C061762 for ; Fri, 19 Mar 2021 10:09:12 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id h10so11588414edt.13 for ; Fri, 19 Mar 2021 10:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AikJF0GK0ZzYGbwbgBUzJRLCgyMvlKF2iA5mDBYu/f0=; b=atYHlbtsaqi04LfSg5Eox0I8qpNOjB6GEdi0psVT9m5ldSjyzg1eh67CmEdPjM6f2Q p7AMVV4XhWzFgVxvstDqqYgicBPRljDxT+CFM0XG48Ck4uEAE1JXuRpZJ2h5YhVRLwj5 5QyesM2zRMk8xFbagNwTwnbdJLsikJ99YGPnc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AikJF0GK0ZzYGbwbgBUzJRLCgyMvlKF2iA5mDBYu/f0=; b=r84RQ9IHvVdFPTjxuCVvmM+CDha4NKbvvSzBtE2aGrwXVML2BwfskUkj/3Vfgt7Q3w +rTnMAH58+oG/zqTxSFFwJY7Ep4jJ3K/X1+Bw3UjeQcA7shSRKKoXyqy/8BhwFYSD0Bb ZUQBbPy76Tjd8Em+f/IJIlEwFwdMIXUPYlrU5X3Yk9JXuAc5MvPM4eo1+ukUIsZQydOD HJylIC1ObZpiB+lyz/HT+SEc355BX3DgiCZXLVJ4ds0WO76+DjVbj+6pk/MF/Gcj99Ms cWCfE3W9dQxwrUZkxm7zjIeRgq5cv8U0aNPtNobVRrc6CSuFf1cItiC1FoUYXo6IKYzU oO2Q== X-Gm-Message-State: AOAM531z6UPzxfoSx8BgrzDBCx1FRdPno7ewkZSe6iVJgkw+Oh40bL0u oonoaHPEy8yd4gydFyX4oZGqnQ== X-Received: by 2002:aa7:c447:: with SMTP id n7mr10623091edr.171.1616173750816; Fri, 19 Mar 2021 10:09:10 -0700 (PDT) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id be27sm4506050edb.47.2021.03.19.10.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 10:09:10 -0700 (PDT) From: Ricardo Ribalda To: Laurent Pinchart , Mauro Carvalho Chehab , Hans Verkuil , Sergey Senozhatsky , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, tfiga@chromium.org Cc: Ricardo Ribalda , Mike Isely Subject: [PATCH v8 02/19] media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL Date: Fri, 19 Mar 2021 18:08:49 +0100 Message-Id: <20210319170906.278238-3-ribalda@chromium.org> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210319170906.278238-1-ribalda@chromium.org> References: <20210319170906.278238-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is written. Cc: Mike Isely Signed-off-by: Ricardo Ribalda Reviewed-by: Hans Verkuil --- drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c index 9657c1883311..c04ab7258d64 100644 --- a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c +++ b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c @@ -640,10 +640,6 @@ static int pvr2_s_ext_ctrls(struct file *file, void *priv, unsigned int idx; int ret; - /* Default value cannot be changed */ - if (ctls->which == V4L2_CTRL_WHICH_DEF_VAL) - return -EINVAL; - ret = 0; for (idx = 0; idx < ctls->count; idx++) { ctrl = ctls->controls + idx; -- 2.31.0.rc2.261.g7f71774620-goog