Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1588681pxf; Fri, 19 Mar 2021 10:26:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzWFupG+jvjberQA3ySpdfpOymJsJcovJVgps9n5Ppu8OxTF8eHyvbyng6Cda3qFVNhNIr X-Received: by 2002:a05:6402:31b7:: with SMTP id dj23mr11122569edb.245.1616174818953; Fri, 19 Mar 2021 10:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616174818; cv=none; d=google.com; s=arc-20160816; b=y47QLMbK1QtC79fSz3xuzOeVoyPWFoZ3Qlv+zXfGCiQ5zbPyEetnRHnUjo6g5Opd+j oYMWVxmqTamsnBFee3Dw1+Xj2r7HhZuNVShCPo8jHQoxcvUrWnD7L4WDIU56TQrDXXJe 1zl8WR/Qjld5+sunF3FnzCQSiZrW6zaDWAQPfIKcEPL0riqvje3n7HaSJwbULSvkqoV1 M9LWxEzOQmB3TyIonKtpLDJ9FEBaFLj+PdVVq/aetntqp1PFGcH/9cH6fADMoEGpZRka IpyN5/cwsRdbWu/nSPz2nRqSi+Er9e4VE4nWE+TrsO9bKp9XNa6lFvf/i2+MZOhNsXyS Q8dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=RPNBgVNWrZM19pIS372izv7KcqqWZ135/0V8aeAzGP4=; b=0jF1XpvTPwphXyOxQsM4hkGcsA6KrE4ItZBvqHDPEQFKLImhXqeU2ZHB/XndzG5Xbq uhFI3K9rfBI0IhAZKOIQMrxitmU+bSZAHDs/8VeK4bMIGI78pqP7w5/E61MIXB6jzYUt PIwYwmk6Wtuuk+tsvPKkFnQDkC9VxATbASsN/I3rcggZBqorCjSDOxrxkQCaoPDp93j5 82l1dmRNKBbRzInIX/cxo9+s1n5jnZmaILcp3sbAoVISh5PeLY9IDbjTzU/dfcsmQtyp +SxaInf84CD7b4vAVSUuUH1J8bDFX3F5KWJINAUWTTZc3cFfJquNxkWRKFI2QG09jl/m 3lvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K1efaQIP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si4474082eds.454.2021.03.19.10.26.34; Fri, 19 Mar 2021 10:26:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K1efaQIP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230294AbhCSRZa (ORCPT + 99 others); Fri, 19 Mar 2021 13:25:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230264AbhCSRZB (ORCPT ); Fri, 19 Mar 2021 13:25:01 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31C9CC061760 for ; Fri, 19 Mar 2021 10:25:01 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id ha17so5012810pjb.2 for ; Fri, 19 Mar 2021 10:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=RPNBgVNWrZM19pIS372izv7KcqqWZ135/0V8aeAzGP4=; b=K1efaQIPJngSEiTSfj5NbLVfNLqZtgPvqUfvC1WNYpzdFAu7/1XTpLPBBFtmSt+oY2 KVmLT9t34Y6/JS+Ig+PPncatAS2b/d4cD8tjJcN54O8jhVmiXiLmNkazHuqcVfqBBhC6 yW0J2Fu5AtsfqocA+fV3xcEFAv2KViqTGmszc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RPNBgVNWrZM19pIS372izv7KcqqWZ135/0V8aeAzGP4=; b=ZNlwLeVOYFkAoD0UekCkLmA6yN6CODym145T96DoPR17TlevtB+eGy6kyEawatMj2D StVGuZUdJXA8D7b4iHyzuxhNE/ajPzMVD7a+qnkbrrmvOTjZtblL5pWSiNk3Bx0YAmuL RlExMHoyZLmnSalZ79u7I9INxWjxpaVhlgP66t1FKCglCEnaMwFv9q4nMXKJwxS0/24C KGnIVCS17p4MeSmb4Lc3aAV47wH6CjYGqExsHQvAcXWZYM97VKchJCgoQU3tYg1PZd9S JCxoNPTju9t9NIeLfxQf51nw8RzUd/Xwuoa0kkgIsGZpJN2LNheJk1vK5KAlImlk97kp R/Mg== X-Gm-Message-State: AOAM532ieFMTUACT53PnGR7QBivW87ehLvQU/APT2e/+uAFxLWEjmpZ6 yXAohizXvszQAQU8RUPt9BsOnQ== X-Received: by 2002:a17:90b:291:: with SMTP id az17mr10475690pjb.206.1616174700784; Fri, 19 Mar 2021 10:25:00 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w4sm5976831pjk.55.2021.03.19.10.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 10:24:59 -0700 (PDT) Date: Fri, 19 Mar 2021 10:24:59 -0700 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: James Morris , Jann Horn , "Serge E . Hallyn" , Al Viro , Andrew Morton , Andy Lutomirski , Anton Ivanov , Arnd Bergmann , Casey Schaufler , David Howells , Jeff Dike , Jonathan Corbet , Michael Kerrisk , Richard Weinberger , Shuah Khan , Vincent Dagonneau , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org, =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Subject: Re: [PATCH v30 06/12] fs,security: Add sb_delete hook Message-ID: <202103191024.436E16509C@keescook> References: <20210316204252.427806-1-mic@digikod.net> <20210316204252.427806-7-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210316204252.427806-7-mic@digikod.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 16, 2021 at 09:42:46PM +0100, Micka?l Sala?n wrote: > From: Micka?l Sala?n > > The sb_delete security hook is called when shutting down a superblock, > which may be useful to release kernel objects tied to the superblock's > lifetime (e.g. inodes). > > This new hook is needed by Landlock to release (ephemerally) tagged > struct inodes. This comes from the unprivileged nature of Landlock > described in the next commit. > > Cc: Al Viro > Cc: James Morris > Cc: Kees Cook > Signed-off-by: Micka?l Sala?n Reviewed-by: Kees Cook -- Kees Cook