Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/3] gcov: combine common code
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-kernel@vger.kernel.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Johannes Berg <johannes.berg@intel.com>
References: <20210315235453.e3fbb86e99a0.I08a3ee6dbe47ea3e8024956083f162884a958e40@changeid>
From:   Peter Oberparleiter <oberpar@linux.ibm.com>
Message-ID: <816c7845-2ba5-2af2-6632-842f8d207633@linux.ibm.com>
Date:   Fri, 19 Mar 2021 18:25:22 +0100
MIME-Version: 1.0
In-Reply-To: <20210315235453.e3fbb86e99a0.I08a3ee6dbe47ea3e8024956083f162884a958e40@changeid>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 15.03.2021 23:54, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> There's a lot of duplicated code between gcc and clang
> implementations, move it over to fs.c to simplify the
> code, there's no reason to believe that for small data
> like this one would not just implement the simple
> convert_to_gcda() function.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

I successfully tested this patch set using GCC on s390, but had some
problems using Clang with gcov-kernel (which seem unrelated to this
patch set - still to be investigated).

The removal of duplicated code definitively makes sense and this
approach looks like it will help make the build-time test I have in mind
for gcov-kernel easier to implement.

As such, for all 3 patches (not sure if it makes a difference seeing
that this has already landed in linux-next):

Acked-by: Peter Oberparleiter <oberpar@linux.ibm.com>


Regards,
  Peter

-- 
Peter Oberparleiter
Linux on Z Development - IBM Germany