Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1639602pxf; Fri, 19 Mar 2021 11:46:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBql4LpTJnRIi7cnRbtllovciTUE+LXTpwFPhxUPtBXw1kMNl4QsqG+XU0wftxrFaU3AJY X-Received: by 2002:a17:906:f247:: with SMTP id gy7mr5528077ejb.183.1616179574044; Fri, 19 Mar 2021 11:46:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616179574; cv=none; d=google.com; s=arc-20160816; b=nlJUftDIAx6Ocqi2NDUdBKCbSqMEk486OuOoOJGPM2NtRSMFN9CunSzsHKYq9CB6aO PkWmdXi9xpQO2+SN7j7yRbE2JvzI9X8JnMeGzsdWgC8LFx3Z8fzEr+a2LjLDgCSMls0q 70nL5ydOlnW9W06iLTjKIvn5hhDf1XcqLqemEzlI1GVzIV6MMhyP7fPnHyDPA8/Wf+qR G5SAePqfaa33c18RahOzGKiSYMkGViG7srElqAUJ+gACBqxZiYvMN2l61GERjnOhaMN8 ElsF9i4vE3oBSX4sVb4KsRzCDvcyNia7txVKo0z5U5s9J3JQIRKx2plfWyi4LZUDuyUG E3Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Lhe2dKb2oNi2zMaIbN0NnP1EknPttO88R2+FBSn6/CU=; b=Qikiu4BGCLQL/8EGolaer/eaEf9F+niXCxc9rXpgyLOeXSDgaTfBvsYisQLR1hRxYC iHVAlnGIrFyjbKy10oc/Mbobo1aIJm5nDtglOYo2LgBV9QT/jfS9XhK+xojgUeODbb+8 kwkyJMAQsguBk9uNNH63rT2a89h3I98HGoCD1Qbcd1By9RjmKoj/BqH4d0B1h3yt33Ne LaWUbiffllsXQxyluQXCVN0bmdGEk7sDc8Rcei5HOrC0eJtlHJxcmM7ZYfkcccz6GGRW HR0z6IbkkHXiXY6+Qg62cZea9hs+qMLUochvrrLjykfw0RO8QNgv9IV1HbqvLAyU7XUQ 5ewg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=AhIIwwBt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y3si4821315eda.196.2021.03.19.11.45.49; Fri, 19 Mar 2021 11:46:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=AhIIwwBt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230090AbhCSSo5 (ORCPT + 99 others); Fri, 19 Mar 2021 14:44:57 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:6556 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230215AbhCSSoW (ORCPT ); Fri, 19 Mar 2021 14:44:22 -0400 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12JIg7O8015435; Fri, 19 Mar 2021 19:43:25 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=selector1; bh=Lhe2dKb2oNi2zMaIbN0NnP1EknPttO88R2+FBSn6/CU=; b=AhIIwwBtev4zODbdzIqydQiJvSs19vgSVfkds5OeeB4sBFCMRlBGHuSZOK4hQYuLkGxK rUUDtdk8EHYEbNeCxN9UqZ3W5nNH73ffUKCocGG31pUa4EZrlBO3KMEP00h33+KRpBFc cMbjvCuEZy5yk5K/irghsjS8axOFitKH6UpUsjEO4VI/SBUT2Hy9wTtQSgVfLd8IGLSC ejxBcGS9HfAmVASDFgR97+C63c0zj5I29Wfvpa1HntbQKwRo+pWI7cl5VkD8dSG+C+Mj IfabMlG+8NO/u/CWEXUbA+ZUsm5MUMBNVS3tdtHblUnGAcQSH9M9ah/cPsdGLHWMydPM jg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37a8prk02h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Mar 2021 19:43:25 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3C33C100034; Fri, 19 Mar 2021 19:43:25 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 293362721FC; Fri, 19 Mar 2021 19:43:25 +0100 (CET) Received: from localhost (10.75.127.51) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 19 Mar 2021 19:43:24 +0100 From: Erwan Le Ray To: Greg Kroah-Hartman , Rob Herring , Thomas Gleixner , Marc Zyngier , Maxime Coquelin , Alexandre Torgue CC: , , , , , Erwan Le Ray , Fabrice Gasnier , Valentin Caron , Patrice Chotard Subject: [PATCH 2/5] serial: stm32: clean wakeup handling in serial_suspend Date: Fri, 19 Mar 2021 19:42:50 +0100 Message-ID: <20210319184253.5841-3-erwan.leray@foss.st.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210319184253.5841-1-erwan.leray@foss.st.com> References: <20210319184253.5841-1-erwan.leray@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-19_10:2021-03-19,2021-03-19 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove useless call to stm32_usart_serial_en_wakeup() routine in suspend callback. When called with "false" argument, this routine is clearing UESM and WUFIE bits if usart is not wakeup source. Those bits are already cleared in set_termios(), and then in serial_resume() callback when usart is wakeup source. Signed-off-by: Alexandre Torgue Signed-off-by: Erwan Le Ray diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index 11656b6b7c0f..cc054f07bd83 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -1536,8 +1536,6 @@ static int __maybe_unused stm32_usart_serial_suspend(struct device *dev) if (device_may_wakeup(dev) || device_wakeup_path(dev)) stm32_usart_serial_en_wakeup(port, true); - else - stm32_usart_serial_en_wakeup(port, false); /* * When "no_console_suspend" is enabled, keep the pinctrl default state -- 2.17.1