Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Mar 2021 13:08:36 -0700 (PDT)
From:   Randy Dunlap <rdunlap@bombadil.infradead.org>
To:     Tom Saeger <tom.saeger@oracle.com>
cc:     Bhaskar Chowdhury <unixbhaskar@gmail.com>, axboe@kernel.dk,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] Trivial typo fix and sentence construction for better
 readability
In-Reply-To: <20210319200706.2dlq33ii33gyakyf@brm-x62-17.us.oracle.com>
Message-ID: <cbda62a9-16bc-6ea7-6070-95918b9154c7@bombadil.infradead.org>
References: <20210319195451.32456-1-unixbhaskar@gmail.com> <5ac591a4-2ed-311a-fcc2-3cc8443d71ef@bombadil.infradead.org> <20210319200706.2dlq33ii33gyakyf@brm-x62-17.us.oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Sender: Randy Dunlap <rdunlap@infradead.org>
Precedence: bulk


On Fri, 19 Mar 2021, Tom Saeger wrote:

> On Fri, Mar 19, 2021 at 01:03:02PM -0700, Randy Dunlap wrote:
>>
>> Hm, needs some spacing fixes IMO. See below.
>>
>>
>> On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote:
>>
>>>
>>> s/funtion/functions/
>>>
>>> Plus the sentence reconstructed for better readability.
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>> ---
>>> Changes from V1:
>>>  Randy's suggestions incorporated.
>>>
>>> block/blk-mq-tag.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
>>> index 9c92053e704d..c2bef283db63 100644
>>> --- a/block/blk-mq-tag.c
>>> +++ b/block/blk-mq-tag.c
>>> @@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
>>> }
>>>
>>> /**
>>> - * blk_mq_tagset_wait_completed_request - wait until all completed req's
>>> - * complete funtion is run
>
> completion function
>
> That's my read of it.

Sounds good. Thanks.

Bhaskar, please use this wording.


> --Tom
>
>>> + * blk_mq_tagset_wait_completed_request - wait until all the  req's
>>
>>                                                             the req's
>>
>>> + *  functions completed their run
>>
>> and more indentation + wording on that line above:
>>  *        functions have completed their run
>>
>>>  * @tagset:	Tag set to drain completed request
>>>  *
>>>  * Note: This function has to be run after all IO queues are shutdown
>>> --
>>
>> Thanks.
>