Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1717001pxf; Fri, 19 Mar 2021 14:01:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtfThJ5Khz7OquXWLE8rLrPz+adD3rydKRn8ACExJHAZwYof9MS8aHBh8nik0eRnUqlSf1 X-Received: by 2002:a50:fe08:: with SMTP id f8mr11746304edt.217.1616187696373; Fri, 19 Mar 2021 14:01:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616187696; cv=none; d=google.com; s=arc-20160816; b=AdhK7e7StV6BNwxSuvlEzvv4FkGEbYakSaBSl89jvQw+RW9qhX+Od+hIDCU7GLW6Sk rL9I8YFGTWya3e+biYPCk2lnDo3INsM6vFJBIdg/7yj92fh9kPZT2ZfOD8o2BJJu2QEW Zdv91J1rSHYCpuBCyX3MQlTuF2U0DSBhVG5VBSnBd6bQCHNGajJVH6RE9+byGZe8AeZw ZMD4XxL6XiWAhohctkS0JR1aB5mb8JXjY2wu+7tz3TX/Mgmkll8eiBADDhtzaNCc8dOG P6i+e3Asvtt/+Qm8Hh8rQp5Dy5WxWNEZbMzOlJmobXwx1T4CfOlXI7/iRqKdvA4mYRh/ FL4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=t9ANbY6sul/CtHWTpKTWg/1mjaAkNxkLIsbeti3jIbM=; b=MGAOT6JYn2Myto2MK2oW5WGzblvZng0OvioTjECO1TCRf+iF5wRdm7UIVKeoQYDqhK CNQGJ16EFIz8GHd2GnZc5zlfgJfyLiIqJwvXNTsE1hb7dWjWzSy+WiDrj0aMPMjY7VLs hRKa/5ZjROoOxbyWsCY4MjSb9emNeQDttqvtkue1Ce4gcX0e/EdxrUlHDnBA38A1SGt9 uHuCBSNyyARrTn3/2xVatDIW7TQUWfCS01QMf9gRIXkr4zBZztQmt5yIG3asdeaTytOF 7MzxVqOi8DIrU/Ylr46lfDnh/SKKZTpSXcPat3WgHl2V8BHEb5VPyYzW/bs9+QFf6P+q Q8gg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si5096424ejj.746.2021.03.19.14.01.11; Fri, 19 Mar 2021 14:01:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbhCSU6S (ORCPT + 99 others); Fri, 19 Mar 2021 16:58:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:34962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229912AbhCSU5w (ORCPT ); Fri, 19 Mar 2021 16:57:52 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 945CA61919; Fri, 19 Mar 2021 20:57:51 +0000 (UTC) Date: Fri, 19 Mar 2021 16:57:49 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: Josh Poimboeuf , x86@kernel.org, jbaron@akamai.com, ardb@kernel.org, linux-kernel@vger.kernel.org, sumit.garg@linaro.org, oliver.sang@intel.com, jarkko@kernel.org, jeyu@kernel.org Subject: Re: [PATCH 3/3] static_call: Fix static_call_update() sanity check Message-ID: <20210319165749.0f3c8281@gandalf.local.home> In-Reply-To: References: <20210318113156.407406787@infradead.org> <20210318113610.739542434@infradead.org> <20210318161308.vu3dhezp2lczch6f@treble> <20210319140005.7ececb11@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Mar 2021 20:34:24 +0100 Peter Zijlstra wrote: > On Fri, Mar 19, 2021 at 02:00:05PM -0400, Steven Rostedt wrote: > > Would making __exit code the same as init code work? That is, load it just > > like module init code is loaded, and free it when the init code is freed > > As stated, yes. But it must then also identify as init through > within_module_init(). I think that's doable. Since the usecases for that appear to be mostly about "think code may no longer exist after it is used". Thus, having exit code act just like init code when UNLOAD is not set, appears appropriate. Jessica, please correct me if I'm wrong. Thanks, -- Steve