Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc:     Michal Hocko <mhocko@suse.com>, Shakeel Butt <shakeelb@google.com>,
        Oscar Salvador <osalvador@suse.de>,
        David Hildenbrand <david@redhat.com>,
        Muchun Song <songmuchun@bytedance.com>,
        David Rientjes <rientjes@google.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        HORIGUCHI NAOYA <naoya.horiguchi@nec.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
        Waiman Long <longman@redhat.com>, Peter Xu <peterx@redhat.com>,
        Mina Almasry <almasrymina@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>
Subject: [RFC PATCH 4/8] hugetlb: call update_and_free_page without hugetlb_lock
Date:   Fri, 19 Mar 2021 15:42:05 -0700
Message-Id: <20210319224209.150047-5-mike.kravetz@oracle.com>
In-Reply-To: <20210319224209.150047-1-mike.kravetz@oracle.com>
References: <20210319224209.150047-1-mike.kravetz@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from monkey.oracle.com (50.38.35.18) by MWHPR07CA0013.namprd07.prod.outlook.com (2603:10b6:300:116::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 22:42:32 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3585576b-7cb5-4aee-63f8-08d8eb284908
X-MS-TrafficTypeDiagnostic: BYAPR10MB3160:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR10MB31600B399A2A6706B2E6C74CE2689@BYAPR10MB3160.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8QhvduPRB5Ak5GzB56D8GPF3wLx2ZVqw8fxYm5cTFViBxQ2OR0nD73LrHdhqDphAwDCQBRUE2ePnKPZzd1e/vtI4WooOTFjH4zUL+UuSqPOuHht/J3argiCjjmrVozWCpOAU1Wq4HyJ+Q0ZdmsdW+uuV/GixYiOXvc+PTbQmgW1Sl4UwzxqFj1CKG6u+QKy6JcEclqW+hLA7aitVgkOJch/taMhlJ7pze4dGiC9m5wn6Fzv+bU8XPyL6CEBsyFimApTRfHKkTgWzbbe8yyBMHaRsGT2N1/P2KQ+prgXWeBFWE2E2JfpbirWbf7d544dLqp8sILr8V4SVKFgsgUvqix8asghufacq3Em6LgP+/qZ9nFL/Ucfv6QjIar/lPFFeJLVukVfLtAPTJg8q/0bRR3Va740UynqrGTA1tAMAwrO2v0FQ4KC6ADAMj5KErICgnhw/S1asuGf3tZgOxRcT0EPYCGuutMhB52XEfKhopC45PCNWgvn+EoHNrrfE5I40YORwbfQNr82q//xSAVOnGu/DiBHifcb8aNXkbYD2NOT0oCegjhCaQqgsP7Qi1QN9zlBaPWqmIUjjSCMNzfi4L+iEblTqdCk5T1LYaVsY+3YK9/qBtORqO06wW+JaLT4y4bDtEaYaQnQ6VoZTTj5hlg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(346002)(136003)(366004)(376002)(15650500001)(8936002)(316002)(5660300002)(66946007)(36756003)(4326008)(186003)(66556008)(26005)(66476007)(54906003)(6486002)(16526019)(52116002)(7696005)(83380400001)(8676002)(956004)(44832011)(107886003)(7416002)(1076003)(2616005)(38100700001)(86362001)(478600001)(2906002)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?dDVwFc6ZzErNoM67RGhEASNe7rekNTFXjdzzfVqZoNXe1yLjA7Qs52CQeq29?=
 =?us-ascii?Q?5ADe8C65Oblw2YcEIQnaDWtSkiCUos+RIRFwYDneiBQK4ciTihqmzheYOXFu?=
 =?us-ascii?Q?sP7aSxyEsYBgfqK+OgjelWqI5qxvApZlAIUD0mEN6a4/fQFk/yEsgZHVUBZr?=
 =?us-ascii?Q?w7F4o2Smkip/4cC4/LFbrW8Oljfpsq5ZTc9hRoCpIgiZkwdgWp0FQwIVyrRh?=
 =?us-ascii?Q?D8SMANHctuYu8I15bWPdm5FgXSbYrJY9e1QdgWXnlSTQ5g/WbAlzT7/bJEul?=
 =?us-ascii?Q?NKaWOwmZvMXdF1Gtfb9qKlXQGbRuy/E/WnRcnR+PudHuJm07hXbkOa4yBpga?=
 =?us-ascii?Q?tNboVeGlcmZ6s9cLqI0Vb60epRT1oKpljDIoYonH1ePwKw5zumkxoSTBeZ6C?=
 =?us-ascii?Q?Cl//PYgXL4Ghex6lW2+fgjnDySAWXwJdQo8FwZld587E31cXuweXLdl34v/h?=
 =?us-ascii?Q?MFOswepzgeDHh5IC4RUDi5ssfSRA489sdZI+U/tc+8q03h3lIDARh9bvAZIo?=
 =?us-ascii?Q?wvOcrO0jfIVPKJ4n9UDvZzevO7ShClE6OmUII5CiT5QgL0+u1tI1ZEkFIYDV?=
 =?us-ascii?Q?sbCTZKux65PCQ7mJ3mYdSYSwe1PXgIjxjkPG9bBbRK8CVrWdDYWZibUqRl+H?=
 =?us-ascii?Q?u+sbYPSgk+/GHDBGpJg5cUdCB5hULq+nWB/TJDJw9pdyhqTgz41cBFrV313q?=
 =?us-ascii?Q?HsNKATpfIVl3Kj8hXqK5SQN3y4mRaE8FyRtbF1s9nBVpSH+aERMdJEYPp/vQ?=
 =?us-ascii?Q?hPclGxXRJ2xBnb9NZRYjdnrFrq+PLv16ximvQDpF0/SJx5CaWAk7Q5XLfoN0?=
 =?us-ascii?Q?r799C55MKPwii+hHAkdUUl0iscle0ridm54j2xfvY/ezjDPZbHSOFezRfof4?=
 =?us-ascii?Q?EHw7YAsQH4LOswrrOSChery6nbCrd5RBCTbqgwOBgc6LrqOtAQ1ANAJmutfh?=
 =?us-ascii?Q?agoBpHtQBwnYTLHUgn/VwhPLBlaIIduIbE9lKRwfm47nIEuwFPtkY/wVE8VB?=
 =?us-ascii?Q?TS+DKKrJmB/Ib/xSMjhDTeZMON8aMDvjRqN0bfHD0eTpeX7Ce3vADDnu6QjP?=
 =?us-ascii?Q?BUIwOXgrkn6BVmCTeEHMZa1uiXNaizffq6/tsCytZwSA/HaYIP1OTExivYzb?=
 =?us-ascii?Q?YSvqdsBTITA9gANrS+TdD5VS8ZgUezY59zKLPsQStlTseo+6gKTgchs/NfMt?=
 =?us-ascii?Q?7zHDthTym7B/h0ilLK/aC1Wfe0u5tYzGhzWJU+06hQGRMKekQFdGHNm5WkOT?=
 =?us-ascii?Q?uwOcHKLhz9LDMvRnz8J5rLBm0FATEjOk2IogobPyl/trKDgoEVEGGZgr6zm6?=
 =?us-ascii?Q?VqidZax1zrQi+fqvU51eOsnE?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3585576b-7cb5-4aee-63f8-08d8eb284908
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 22:42:33.1133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KbW4oi7HnF4+Y26Ag9XTqW4ZUqRjK1nMEr6TUdI3cQi8mdl72cHRp71sLzAyW3DQv+Z4JyRM32mWO9TBpjLNEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3160
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9928 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 suspectscore=0
 adultscore=0 bulkscore=0 mlxlogscore=943 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103190156
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9928 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 priorityscore=1501
 lowpriorityscore=0 clxscore=1015 adultscore=0 phishscore=0 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2103190155
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

With the introduction of remove_hugetlb_page(), there is no need for
update_and_free_page to hold the hugetlb lock.  Change all callers to
drop the lock before calling.

With additional code modifications, this will allow loops which decrease
the huge page pool to drop the hugetlb_lock with each page to reduce
long hold times.

The ugly unlock/lock cycle in free_pool_huge_page will be removed in
a subsequent patch which restructures free_pool_huge_page.

Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
---
 mm/hugetlb.c | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index ae185d3315e0..3028cf10d504 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1362,14 +1362,8 @@ static void update_and_free_page(struct hstate *h, struct page *page)
 				1 << PG_writeback);
 	}
 	if (hstate_is_gigantic(h)) {
-		/*
-		 * Temporarily drop the hugetlb_lock, because
-		 * we might block in free_gigantic_page().
-		 */
-		spin_unlock(&hugetlb_lock);
 		destroy_compound_gigantic_page(page, huge_page_order(h));
 		free_gigantic_page(page, huge_page_order(h));
-		spin_lock(&hugetlb_lock);
 	} else {
 		__free_pages(page, huge_page_order(h));
 	}
@@ -1435,16 +1429,18 @@ static void __free_huge_page(struct page *page)
 
 	if (HPageTemporary(page)) {
 		remove_hugetlb_page(h, page, false);
+		spin_unlock(&hugetlb_lock);
 		update_and_free_page(h, page);
 	} else if (h->surplus_huge_pages_node[nid]) {
 		/* remove the page from active list */
 		remove_hugetlb_page(h, page, true);
+		spin_unlock(&hugetlb_lock);
 		update_and_free_page(h, page);
 	} else {
 		arch_clear_hugepage_flags(page);
 		enqueue_huge_page(h, page);
+		spin_unlock(&hugetlb_lock);
 	}
-	spin_unlock(&hugetlb_lock);
 }
 
 /*
@@ -1725,7 +1721,13 @@ static int free_pool_huge_page(struct hstate *h, nodemask_t *nodes_allowed,
 				list_entry(h->hugepage_freelists[node].next,
 					  struct page, lru);
 			remove_hugetlb_page(h, page, acct_surplus);
+			/*
+			 * unlock/lock around update_and_free_page is temporary
+			 * and will be removed with subsequent patch.
+			 */
+			spin_unlock(&hugetlb_lock);
 			update_and_free_page(h, page);
+			spin_lock(&hugetlb_lock);
 			ret = 1;
 			break;
 		}
@@ -1794,8 +1796,9 @@ int dissolve_free_huge_page(struct page *page)
 		}
 		remove_hugetlb_page(h, page, false);
 		h->max_huge_pages--;
+		spin_unlock(&hugetlb_lock);
 		update_and_free_page(h, head);
-		rc = 0;
+		return 0;
 	}
 out:
 	spin_unlock(&hugetlb_lock);
@@ -2572,7 +2575,9 @@ static void try_to_free_low(struct hstate *h, unsigned long count,
 			remove_hugetlb_page(h, page, false);
 			h->free_huge_pages--;
 			h->free_huge_pages_node[page_to_nid(page)]--;
+			spin_unlock(&hugetlb_lock);
 			update_and_free_page(h, page);
+			spin_lock(&hugetlb_lock);
 
 			/*
 			 * update_and_free_page could have dropped lock so
-- 
2.30.2