Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1782444pxf; Fri, 19 Mar 2021 16:12:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx14AzdxB06v816F8HmuILR4tivYih9z0TjDrzEhyd0wIcZGdwlTN5EwRhgRe+jMFRTm8V7 X-Received: by 2002:a05:6402:30b9:: with SMTP id df25mr12677921edb.136.1616195573891; Fri, 19 Mar 2021 16:12:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1616195573; cv=pass; d=google.com; s=arc-20160816; b=P+tiMx8pbcwJUYuIkqiJheCgbTVCdxZFwNCvsW2mbWv6+ZPcs6xri+lKDhjH0FNoYx OuZ56qbsb84NvPGNrFUHi8+dnuuWLbWY0fpoOS451uXGFv/mY7kUeuC0A9RXPu7Kbrur mw4lMVeEACCBk7y9u8n0Yuk7yC5G2/z3/z4JXeJZ2/IAhNDc2cYxg5jjFV+GNZ36JVEK ROBB7WvXeWuudncnPwSCNJU9Eh7IAuIECbxJwqrTQm/PlnqHG2ws6T3a4BrZrfgWDpg1 nb2strixOph5iL2pv/Mf/aXNsJzfYOcKiwgDqTgBZY2J8w9jm5hP4eWf+iPXPkn8vbE9 fNLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=10ocK1xc4e0dW1IfGLa5MXYEmDR1IRDCmJNBWSjcWnE=; b=l6lA9Xdt7n6vF3LmCcXqra5g6tdlDUYCB8N3FuyNTas/L+vZbtTl6YmDDCo9BthR++ BqM+nOurQ3rztW1YlsdUORBzONuuEws+5Crkx5wusb9Zu3sRrJ6sjKFl60Z3Wb6THM3I WzHwDRhxI1nQqf/mzYt9DZlaAHhZ7fr2k7R3hDpb1Hz2y9Z9fn+fi4hMfeRHcJwjhHKM bJghJFgGZKKX1OaSNy25/GAyVXC3vwmk70Rq+9Uzg2Nx/8vAPlA3p/qFwB1urxXEjnjK tPoiDQNVy5B+NOueMV9YwHEtVRCh57vPwJlLEV1TFqMrfdBooTgR9L0Nc8ZOMKjl/fmR r9hA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@aepfle.de header.s=strato-dkim-0002 header.b="PxESum/s"; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jp24si5544528ejb.512.2021.03.19.16.12.31; Fri, 19 Mar 2021 16:12:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@aepfle.de header.s=strato-dkim-0002 header.b="PxESum/s"; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229524AbhCSXJU (ORCPT + 99 others); Fri, 19 Mar 2021 19:09:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbhCSXIs (ORCPT ); Fri, 19 Mar 2021 19:08:48 -0400 Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:400:100::c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87AC7C061760 for ; Fri, 19 Mar 2021 16:08:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616195165; cv=none; d=strato.com; s=strato-dkim-0002; b=rBBL2LXqxWxT3SP2/NUPTDKmcxcjQrS6Et8IZsmjOUlgrFF47hJJiL1TuXZ5/GMMOW RFzctnKsP14BEQqGtp5KzLFxlwYqqpRgh6VzyeARk/8ymxUlz66Tw6vNczK92nAiEpIz 2LJJQsM9wZZetqJrK9Pr4RAvrSp1qFz+hDtTpVAKoGOpiVK41p9v/18ykGe3nbAi9PtT X688G+t7b+10u5Y+0cZxsEivkASrxtMAPd8xb3s1x//+IFerVwS/hgL/feoiR9IN3TIM kbb5W37CBdO2hCzX42aBP0DlkMTQTOtNymHh9K/z9rMi0YdD7rn9Xj93wJrfrz3szj8K W5lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1616195165; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=10ocK1xc4e0dW1IfGLa5MXYEmDR1IRDCmJNBWSjcWnE=; b=KePyDc6hBnwx4cHzw2DHN52cKzBeZHUWmKNvfoGFl/pTilgaY3bSg9EHtsTBWRjcSA 7H/UJSdCO/+cJHJqdNv81G9+ooNB0XqxXU5ZCPjNBIhV6gBTzlJJQRvCDXKlkkwfd5OD TsMNmeTO6eIAgTIi9AyZc6jrTX1L1pQTW4+M4RkaN2MWnxZavSzveN2UDQGfx68ZMiA8 cagcU/mSbpnt0XIpu/uatUt2x3zWQKhj2dMjjUYf6zSTlWEhmZ54CyVu9hlVnEZranvc DZ5iyqO7p1JKGI1ducH3GhIoqwQ5AMzbToycJgdaVbX+IrpHEpSQb67polWjvxpUwkj5 b0eQ== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1616195165; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=10ocK1xc4e0dW1IfGLa5MXYEmDR1IRDCmJNBWSjcWnE=; b=PxESum/sCTAD9ZLz/vXKDeMZJZtT6V+QpCVWG5doGcNyPeD3EzqZtXwDyc74A3v5XA GXdDueQb0t/be+KUKaLFMAlFwfMXH2jRyyDYwImidg6B8TYuVSsJnMbIGYuqfLvK5f3a pJlizXGcwsSUSvtzWfggATLsuXIgfm1PY0AESXlwHSJfnHh8V0SspPJHIMbNhR+Tg0C2 jFVcfusnbIieKhy/WIITqkwMyhlaYVtnhxrnkfcD90atoiBntlAsNTeF12XRt4RY9KoY 9dPzhWETQk1rOGXoj4oijqlKJncQVCM7z44qOhZjJmENUqn6v0DpmLLPlaMf29S5GYBL 8xwA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzBW/OdlBZQ4AHSS325Pjw==" X-RZG-CLASS-ID: mo00 Received: from sender by smtp.strato.de (RZmta 47.21.0 SBL|AUTH) with ESMTPSA id k0a44fx2JN64CNJ (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)) (Client did not present a certificate); Sat, 20 Mar 2021 00:06:04 +0100 (CET) From: Olaf Hering To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Olaf Hering , Alexander Viro Subject: [PATCH v1] binfmt: check return value of remove_arg_zero Date: Sat, 20 Mar 2021 00:05:53 +0100 Message-Id: <20210319230554.11991-1-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to build with -Werror=unused-result, use remove_arg_zero properly. Fixes commit b6a2fea39318e43fee84fa7b0b90d68bed92d2ba Signed-off-by: Olaf Hering --- fs/binfmt_em86.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/binfmt_em86.c b/fs/binfmt_em86.c index 06b9b9fddf70..5b1c02a0250f 100644 --- a/fs/binfmt_em86.c +++ b/fs/binfmt_em86.c @@ -63,7 +63,8 @@ static int load_em86(struct linux_binprm *bprm) * This is done in reverse order, because of how the * user environment and arguments are stored. */ - remove_arg_zero(bprm); + retval = remove_arg_zero(bprm); + if (retval < 0) return retval; retval = copy_string_kernel(bprm->filename, bprm); if (retval < 0) return retval; bprm->argc++;