Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Mar 2021 19:27:58 -0700 (PDT)
From:   Randy Dunlap <rdunlap@bombadil.infradead.org>
To:     Bhaskar Chowdhury <unixbhaskar@gmail.com>
cc:     alexander.deucher@amd.com, christian.koenig@amd.com,
        airlied@linux.ie, daniel@ffwll.ch, Hawking.Zhang@amd.com,
        John.Clements@amd.com, tao.zhou1@amd.com, guchun.chen@amd.com,
        Likun.Gao@amd.com, Bhawanpreet.Lakha@amd.com, ray.huang@amd.com,
        Jiansong.Chen@amd.com, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] drm/amdgpu: Fix a typo
In-Reply-To: <20210318202414.10547-1-unixbhaskar@gmail.com>
Message-ID: <3cc678f2-36d1-1af1-5759-37aea82f41ea@bombadil.infradead.org>
References: <20210318202414.10547-1-unixbhaskar@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Sender: Randy Dunlap <rdunlap@infradead.org>
Precedence: bulk


On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:

> s/traing/training/
>
> ...Plus the entire sentence construction for better readability.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> Changes from V1:
>  Alex and Randy's suggestions incorporated.
>
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index c325d6f53a71..bf3857867f51 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
>
> 	if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> 		/*
> -		 * Long traing will encroach certain mount of bottom VRAM,
> -		 * saving the content of this bottom VRAM to system memory
> -		 * before training, and restoring it after training to avoid
> -		 * VRAM corruption.
> +		 * Long training will encroach a certain amount on the bottom of VRAM;
> +                 * save the content from the bottom VRAM to system memory
> +                 * before training, and restore it after training to avoid
> +                 * VRAM corruption.

These 3 new lines are indented with spaces instead of tabs. Oops.  :(

(I may be too late with this comment -- sorry about that.)

> 		 */
> 		sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
>
> --
> 2.26.2
>
>