Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2075035pxf; Sat, 20 Mar 2021 03:53:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzdCL5zgga3gEZXqIzIwwyQp+rqZas337FeQPWVT4WHm9i8QwmchrNJgMeOaZF3qNQ+Sma X-Received: by 2002:a17:907:9863:: with SMTP id ko3mr9178988ejc.543.1616237587280; Sat, 20 Mar 2021 03:53:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616237587; cv=none; d=google.com; s=arc-20160816; b=NRW7GSMl+bN0sgnh02PBM7tnTNsMER5if2CwF0s97KZUyaLbr2W/m+ZT1eXQ1MaXaN rb14XjbS7I3BPKVRlwOako5MZ3bItt0uLLRM/QXQ0BgPiiO1gUKvO575KR83WSYFBEgN qeDyBZkQ0XYb/CcIgGKfH1pib+Z0gjIM/+CP3hOnTE5IlVS/vpiQsLhJefPaBwSI5jGc HFBOW2h9nnL2VXjq2zNHRk1G/usbed4SmYPfiEwyJ+oflx8wn42o2xAbymovR2DYGkS5 AmqyHuF9cudkDx1I9OO8OM+frmh/dzYLmGzX4uwTjiMDQriy2XuqhS47dQpBQ6rKgPp0 nL/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=e0Ok76DtBipIYFoxH3AU3GubyGE5PN2GtFP1WyzCpvQ=; b=gyWOmjkpwET2NUwMkR0kyQSTMWuhsYzoILR3pgfKQHBfSZFqMBMBSi3yTFYaJOtmix QfA7aV9v/j5MW3HnlbWB1sakNVs7pxeOrSdo5shIjC8RaRW7zEyaLKXQkfTADwjQ7KGw P3gAmJ+s6eNIpldV7F4k+hLRHYsmXXJ1bDZN80p5vp8CAaACgOgqnt1aCifAOybZpYIM nkkozMI646X20/MsRIRf7EUb+qZkUEEnF5AKXAdRb5iD4jouENPAs9CLoVXYJz4+mHvj 5Yq7H0bYqiXWpHopqftk4wAex7uz6FOG1eIxY+O/VPTXFJnZtfmk9m8Ec8/8lYZnVMnO nnXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=eBdfloup; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qu25si6515501ejb.665.2021.03.20.03.52.01; Sat, 20 Mar 2021 03:53:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=eBdfloup; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229638AbhCTFmG (ORCPT + 99 others); Sat, 20 Mar 2021 01:42:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbhCTFls (ORCPT ); Sat, 20 Mar 2021 01:41:48 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F7FDC061762; Fri, 19 Mar 2021 22:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=e0Ok76DtBipIYFoxH3AU3GubyGE5PN2GtFP1WyzCpvQ=; b=eBdfloupkaEMexbkEbuEfzKhcO oBrh+QMU204rwPxpc/L90BPmil9fpoueOSXBQfzUNN5dTA+b/Y9lOQfiskB7AdKHW31yr/d8666Aq FgeYcBuTwPTHkna6LoqHp5HlwvbY1v4XKRSf7bdH/+PrI//Rc4+uafjMx+qg4gOPjfH8lphCzGeo7 5lvuX2paWAw33/NCM3Dgzi3yVxtkNRL+5u8mmd2AyW5JVW3rKPHQc4kuYEKYj1cLDzQCV5flrHD3y aeyTVSjb4ebohpTFYrpAFbJJ+5QXPFEJKagkZMrraOTcHwETCcQS4FzGvMxfOaRuP/VU2g97F9SWQ sCF/PDiA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lNUMc-005SQR-F2; Sat, 20 Mar 2021 05:41:36 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: [PATCH v5 03/27] afs: Use wait_on_page_writeback_killable Date: Sat, 20 Mar 2021 05:40:40 +0000 Message-Id: <20210320054104.1300774-4-willy@infradead.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210320054104.1300774-1-willy@infradead.org> References: <20210320054104.1300774-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Open-coding this function meant it missed out on the recent bugfix for waiters being woken by a delayed wake event from a previous instantiation of the page. Signed-off-by: Matthew Wilcox (Oracle) --- fs/afs/write.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/afs/write.c b/fs/afs/write.c index b2e03de09c24..106a864b6a93 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c @@ -850,8 +850,7 @@ vm_fault_t afs_page_mkwrite(struct vm_fault *vmf) return VM_FAULT_RETRY; #endif - if (PageWriteback(page) && - wait_on_page_bit_killable(page, PG_writeback) < 0) + if (wait_on_page_writeback_killable(page)) return VM_FAULT_RETRY; if (lock_page_killable(page) < 0) -- 2.30.2