Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932326AbWJEWET (ORCPT ); Thu, 5 Oct 2006 18:04:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932329AbWJEWET (ORCPT ); Thu, 5 Oct 2006 18:04:19 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:41732 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S932326AbWJEWES (ORCPT ); Thu, 5 Oct 2006 18:04:18 -0400 Date: Fri, 6 Oct 2006 08:02:59 +1000 To: Andrew Morton Cc: Jeremy Fitzhardinge , "Ananiev, Leonid I" , tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression Message-ID: <20061005220259.GA26202@gondor.apana.org.au> References: <20061005143748.2f6594a2.akpm@osdl.org> <45257C65.3030600@goop.org> <20061005145213.f3eaaf7d.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061005145213.f3eaaf7d.akpm@osdl.org> User-Agent: Mutt/1.5.9i From: Herbert Xu Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1047 Lines: 35 On Thu, Oct 05, 2006 at 02:52:13PM -0700, Andrew Morton wrote: > > Herbert had a good-sounding reason for wanting this feature, but afaict he > hasn't proceeded to use it at this stage. And he's hiding from us ;) Well you guys had everything under control so I was happy to stay behind my rock :) The original reason for the return value is so you can do if (WARN_ON(impossible_condition)) { attempt_to_continue; } instead of if (unlikely(impossible_condition)) { WARN_ON(1); attempt_to_continue; } Oh and yes the unlikely does make a difference in a statement expression. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/