Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2744130pxf; Sun, 21 Mar 2021 05:28:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMdOI640sU4ppYngRZy8nGv1KUyo+gWVRkRC2HwN+oMES5E5pTQDF6pZ+8v/RmEczJ/nkV X-Received: by 2002:a17:906:4d18:: with SMTP id r24mr13922077eju.493.1616329723122; Sun, 21 Mar 2021 05:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616329723; cv=none; d=google.com; s=arc-20160816; b=VMy6Gl7VBteefLjbbkiO56oxLNWe5cznXp7o4gvlI2U9xMxctENiY3v0aAEq2krhvM ydIL5Ha7jjooQCTQoEQ/Kdqocfm5KdDRBWSqys5PG013VyTTjhiMkvSJzXuAOucjjEDP ePsmAlO+DENL5HnKJzGFL+ZvTxgwv13sOfW7OtijWFJTPJm0/BB1vFEXMOnO9/KN5N+s 5GJZLB7vaQUYTTnS2sLclxr1m63gtROJg7luPdEbBv3kyGM2rwBMPbeg8Ithh3mRKJ67 RzGlkHw6ogZaXZLH/p0wuAZGl0+v9ISrrtRcgmTYRxx7Ii+yIatOz1dY8nWaN5Kuruwo eWrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zn0thQKrRCOaUqXvGKbzNwd9nTC8oSH1ccRAESfzKnw=; b=nU8+vC9FeU+463TPDy05ocBbJgdCt2a+zsQjYfCvthhS+g7hhODSK8L/JRLDjPpbT8 U0PHKvD/E/r/ddkx1bgbqJ2uKbH9G+YWH6WmxiWAkfApYiDcu5pU1jSe56C9fkBFdUPS VuuNza3XlwBVNcGtnnaU/xrxdSjOR0y/aErlYS742wXs6MPEHZLi+T+LEh8+WQmRf+lf QXR1vsFIRASEmvT1nMCPLaK/NIt9DhXmVd9hpFuTfCyYOZHx7yosBNcxvBSW+yF9nvPx aaDtP6kN5oEPev6ey2SNA7NttWnAS4mnobS/PKqVZ3fWTNJ7gfNJFMnXM2DHygw33R/k /03A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="a+M/10Dw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jo14si9361331ejb.460.2021.03.21.05.28.19; Sun, 21 Mar 2021 05:28:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="a+M/10Dw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229863AbhCUMZ2 (ORCPT + 99 others); Sun, 21 Mar 2021 08:25:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:33044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbhCUMYz (ORCPT ); Sun, 21 Mar 2021 08:24:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3878661946; Sun, 21 Mar 2021 12:24:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616329494; bh=zn0thQKrRCOaUqXvGKbzNwd9nTC8oSH1ccRAESfzKnw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a+M/10DwX2/dUCM80ZtyS7gENrCKmRXjWnCmGvj3p1GWtiW6R3vyrtM9b5fam9xhu 9lC3pVM5TGctVC6MYNGWmPHHYgHIfHltHlzZIZkymulPcWB24O2RDvz6ZSMyZc5Qc/ Zx2OdGr59gdsVpPY9AwsPloX0dTmig6C/Vy6tOnE= Date: Sun, 21 Mar 2021 13:24:49 +0100 From: Greg KH To: eli.billauer@gmail.com Cc: arnd@arndb.de, devel@driverdev.osuosl.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c Message-ID: References: <20210311095033.20956-1-eli.billauer@gmail.com> <20210311095033.20956-2-eli.billauer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210311095033.20956-2-eli.billauer@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 11, 2021 at 11:50:32AM +0200, eli.billauer@gmail.com wrote: > +EXPORT_SYMBOL(xillybus_init_chrdev); Given the license for this code, perhaps EXPORT_SYMBOL_GPL()? I have to ask :) thanks, greg k-h