Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Date:   Sun, 21 Mar 2021 21:10:36 +0200
From:   Jyri Sarha <jyri.sarha@iki.fi>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/tilcdc: panel: fix platform_no_drv_owner.cocci
 warnings
In-Reply-To: <1614762267-98454-1-git-send-email-yang.lee@linux.alibaba.com>
References: <1614762267-98454-1-git-send-email-yang.lee@linux.alibaba.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <0c5ff308f0bc71b847c805851a6f727c@iki.fi>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021-03-03 11:04, Yang Li wrote:
> ./drivers/gpu/drm/tilcdc/tilcdc_panel.c:402:3-8: No need to set .owner
> here. The core will do it.
> 
> Remove .owner field if calls are used which set it automatically
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>

I'll merge this soon to drm-misc-next.

Best regards,
Jyri

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 00efc30..4235780 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -399,7 +399,6 @@ static int panel_remove(struct platform_device 
> *pdev)
>  	.probe = panel_probe,
>  	.remove = panel_remove,
>  	.driver = {
> -		.owner = THIS_MODULE,
>  		.name = "tilcdc-panel",
>  		.of_match_table = panel_of_match,
>  	},