Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: RE: [PATCH v29 4/4] scsi: ufs: Add HPB 2.0 support
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <DM6PR04MB6575DEC175CD1D3895F1AF2BFC669@DM6PR04MB6575.namprd04.prod.outlook.com>
Message-ID: <20210322005016epcms2p189894f11a157ed783e086d4523b85016@epcms2p1>
Date:   Mon, 22 Mar 2021 09:50:16 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <DM6PR04MB6575DEC175CD1D3895F1AF2BFC669@DM6PR04MB6575.namprd04.prod.outlook.com>
        <20210315012850epcms2p361447b689e925561c48aa9ca54434eb5@epcms2p3>
        <20210315013137epcms2p861f06e66be9faff32b6648401778434a@epcms2p8>
        <CGME20210315012850epcms2p361447b689e925561c48aa9ca54434eb5@epcms2p1>
Precedence: bulk

Hi Avri,

>> +static int ufshpb_execute_umap_req(struct ufshpb_lu *hpb,
>> +                                  struct ufshpb_req *umap_req,
>> +                                  struct ufshpb_region *rgn)
>> +{
>> +       struct request *req;
>> +       struct scsi_request *rq;
>> +
>> +       req = umap_req->req;
>> +       req->timeout = 0;
>> +       req->end_io_data = (void *)umap_req;
>> +       rq = scsi_req(req);
>> +       ufshpb_set_unmap_cmd(rq->cmd, rgn);
>> +       rq->cmd_len = HPB_WRITE_BUFFER_CMD_LENGTH;
>> +
>> +       blk_execute_rq_nowait(NULL, req, 1, ufshpb_umap_req_compl_fn);
>Typo? Forgot the struct request_queue *q?

The argument of q is removed after this patch.

https://lore.kernel.org/linux-scsi/1611550198-17142-1-git-send-email-guoqing.jiang@cloud.ionos.com/#r

Thanks,
Daejun

>> +
>> +       return 0;
>> +}
>> +
>>  static int ufshpb_execute_map_req(struct ufshpb_lu *hpb,
>>                                   struct ufshpb_req *map_req, bool last)
>>  {
>> @@ -533,12 +878,12 @@ static int ufshpb_execute_map_req(struct ufshpb_lu
>> *hpb,
>> 
>>         q = hpb->sdev_ufs_lu->request_queue;
>>         for (i = 0; i < hpb->pages_per_srgn; i++) {
>> -               ret = bio_add_pc_page(q, map_req->bio, map_req->mctx->m_page[i],
>> +               ret = bio_add_pc_page(q, map_req->bio, map_req->rb.mctx-
>> >m_page[i],
>>                                       PAGE_SIZE, 0);
>>                 if (ret != PAGE_SIZE) {
>>                         dev_err(&hpb->sdev_ufs_lu->sdev_dev,
>>                                    "bio_add_pc_page fail %d - %d\n",
>> -                                  map_req->rgn_idx, map_req->srgn_idx);
>> +                                  map_req->rb.rgn_idx, map_req->rb.srgn_idx);
>>                         return ret;
>>                 }
>>         }
>> @@ -554,8 +899,8 @@ static int ufshpb_execute_map_req(struct ufshpb_lu
>> *hpb,
>>         if (unlikely(last))
>>                 mem_size = hpb->last_srgn_entries * HPB_ENTRY_SIZE;
>> 
>> -       ufshpb_set_read_buf_cmd(rq->cmd, map_req->rgn_idx,
>> -                               map_req->srgn_idx, mem_size);
>> +       ufshpb_set_read_buf_cmd(rq->cmd, map_req->rb.rgn_idx,
>> +                               map_req->rb.srgn_idx, mem_size);
>>         rq->cmd_len = HPB_READ_BUFFER_CMD_LENGTH;
>> 
>>         blk_execute_rq_nowait(NULL, req, 1, ufshpb_map_req_compl_fn);
>Ditto
> 
> 
>Thanks,
>Avri
> 
> 
>