Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on
 putback_movable_page()
To:     Rafael Aquini <aquini@redhat.com>
CC:     <akpm@linux-foundation.org>, <jglisse@redhat.com>,
        <shy828301@gmail.com>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>
References: <20210320093701.12829-1-linmiaohe@huawei.com>
 <20210320093701.12829-2-linmiaohe@huawei.com> <YFYBIlkM+V0Nsl+5@x1-fbsd>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <efd21696-fb2b-e466-21fc-9b4cca40ffc1@huawei.com>
Date:   Mon, 22 Mar 2021 09:52:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <YFYBIlkM+V0Nsl+5@x1-fbsd>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi:
On 2021/3/20 22:11, Rafael Aquini wrote:
> On Sat, Mar 20, 2021 at 05:36:57AM -0400, Miaohe Lin wrote:
>> The !PageLocked() check is implicitly done in PageMovable(). Remove this
>> explicit one.
>>
> 
> I'd just keep the explicit assertion in place, regardless.
> But if you're going to stick with this patch, please fix it because it's 
> removing the wrong assertion.

Many thanks for your reply. I should have a coffee when I make this patch! :(
Will fix it. Many thanks for remind!

> 
> 
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>>  mm/migrate.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/mm/migrate.c b/mm/migrate.c
>> index 47df0df8f21a..e4ca5ef508ea 100644
>> --- a/mm/migrate.c
>> +++ b/mm/migrate.c
>> @@ -146,7 +146,6 @@ void putback_movable_page(struct page *page)
>>  	struct address_space *mapping;
>>  
>>  	VM_BUG_ON_PAGE(!PageLocked(page), page);
>> -	VM_BUG_ON_PAGE(!PageMovable(page), page);
>>  	VM_BUG_ON_PAGE(!PageIsolated(page), page);
>>  
>>  	mapping = page_mapping(page);
>> -- 
>> 2.19.1
>>
>>
> 
> .
>