Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3118090pxf; Sun, 21 Mar 2021 20:04:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTcAEs3kf7anqE8Ezoe4AKYKRKUyiIy5eyTdh4gRx7acbTdqw+9zMvsWkVDYShSWw5r/T0 X-Received: by 2002:a17:906:b286:: with SMTP id q6mr17118055ejz.422.1616382247644; Sun, 21 Mar 2021 20:04:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616382247; cv=none; d=google.com; s=arc-20160816; b=vRwdMlEoaG09S9UCfVJ8KCBa+enzVdJrXPSL8S4bMbbh/Va7vMHXBM40wouA9QO4od 7D/KFtbT2cI6pPXKOU3gUwKKOD9QLGS1aMUgq5qMC6npwD6fAoPzVauGu2XwzwmYVubE /7D2avAq+1scdj49Fci6VLBV3/W+H+uegbwD2vK+yowGi3ZZDqMM3Quq3zgnZPooN6sg 2GNpmmXEt2aQJkxCX249S3Tr1q9+j78yFjh1t13C5Qq1V5H33i9pbUO21cvCU9RGVIK+ ZYLcF+MBA3ZV4MDGJcTrROStNmVVzAs9lcwRVCTyi/HOFQC73iHQ+HzbNiNbgEKB+oLP eBhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=lGd2W5iqkvRFNfGv2+Xs4iaNgTe5j3WO8XrNv1cz6+w=; b=U8CF2qdpTUgeR9/s90Hs3dY07mBLMnHNdbi/ho8X3XVU5cXXY2MoQhvpKgkHFRiqm6 BMTJfnTQM/9qjg5m/RE3g54rb+ZHP8A/CPpnxmKaATWQu1g60lEFmwO15aAH7dTd46w5 c/d2cykvxNqMW50BhQgLyRe0nsfkvQzknoX1vsPRMFIiV7kxEGlRzp1k/4L62nDIOB/g iEX7SfrBVqZ/yhRWoOdVdM75/IXzyFeLWeFd9BrwT1/xnzCOUuiNWdHHAB2gp2l9H8et j1b5ZEvWeqoZhsmChW/RgKPyIF43UNZSqVLbROkyJK2ds/cLNLCY88cXHudnQReJ620Z 83dA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k3si11295956edh.184.2021.03.21.20.03.45; Sun, 21 Mar 2021 20:04:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229893AbhCVDCv (ORCPT + 99 others); Sun, 21 Mar 2021 23:02:51 -0400 Received: from mga04.intel.com ([192.55.52.120]:21928 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbhCVDCU (ORCPT ); Sun, 21 Mar 2021 23:02:20 -0400 IronPort-SDR: /NXRf68z2Yhs5mqFMnWOblWroPy0efmyo2zdAbEGRtKmrlg7FMVmCSy7B+YiIySCcX9BKpTV3L AUd92VgM+Vfg== X-IronPort-AV: E=McAfee;i="6000,8403,9930"; a="187863171" X-IronPort-AV: E=Sophos;i="5.81,266,1610438400"; d="scan'208";a="187863171" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2021 20:02:19 -0700 IronPort-SDR: bzxpIJoCLJe84bVcqOaqUvNBq4JQkE58kQKsYSQGh97j8g9TnHd5uKKmg6Ogh18eBITXCjKXsp QWO9Oh0W9L7w== X-IronPort-AV: E=Sophos;i="5.81,266,1610438400"; d="scan'208";a="414305347" Received: from tassilo.jf.intel.com ([10.54.74.11]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2021 20:02:19 -0700 Date: Sun, 21 Mar 2021 20:02:17 -0700 From: Andi Kleen To: Jiri Olsa Cc: Changbin Du , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Namhyung Kim , linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v2] perf stat: improve readability of shadow stats Message-ID: <20210322030217.GC1749465@tassilo.jf.intel.com> References: <20210315143047.3867-1-changbin.du@gmail.com> <20210318151240.ms4ic6xfa4xx7t2u@mail.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > But is this a real problem? > > perhaps not, Andi, any idea about this? It's not a problem for my tools which don't use the unit, but I could imagine one for other parsers. I would recommend to not change it for CSV, which is expected to be parsed by tools. -Andi