Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Sungjong Seo" <sj1557.seo@samsung.com>
To:     "'Hyeongseok Kim'" <hyeongseok@gmail.com>,
        <namjae.jeon@samsung.com>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
Cc:     <sj1557.seo@samsung.com>
In-Reply-To: <20210322035336.81050-1-hyeongseok@gmail.com>
Subject: RE: [PATCH v3] exfat: speed up iterate/lookup by fixing start point
 of traversing cluster chain
Date:   Mon, 22 Mar 2021 14:52:19 +0900
Message-ID: <016101d71edf$8542b240$8fc816c0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQFCCaC8jPi/61EWNQoXs0UvpNzAUAIaXSUoq6jXuSA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20210322035356epcas1p35cf4d476030f5ebaf6357c5761355605@epcas1p3.samsung.com>
        <20210322035336.81050-1-hyeongseok@gmail.com>
Precedence: bulk

> When directory iterate and lookup is called, there's a buggy rewinding of
> start point for traversing cluster chain to the parent directory entry's
> first cluster. This caused repeated cluster chain traversing from the
> first entry of the parent directory that would show worse performance if
> huge amounts of files exist under the parent directory.
> Fix not to rewind, make continue from currently referenced cluster and dir
> entry.
> 
> Tested with 50,000 files under single directory / 256GB sdcard, with
> command "time ls -l > /dev/null",
> Before :     0m08.69s real     0m00.27s user     0m05.91s system
> After  :     0m07.01s real     0m00.25s user     0m04.34s system
> 
> Signed-off-by: Hyeongseok Kim <hyeongseok@gmail.com>

Looks good.
Thanks for your contribution.

Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>

> ---
>  fs/exfat/dir.c      | 19 +++++++++++++------
>  fs/exfat/exfat_fs.h |  2 +-
>  fs/exfat/namei.c    |  9 ++++++++-
>  3 files changed, 22 insertions(+), 8 deletions(-)