Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Mar 2021 13:27:00 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Jie Deng <jie.deng@intel.com>
Cc:     linux-i2c@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, mst@redhat.com, wsa@kernel.org,
        jasowang@redhat.com, wsa+renesas@sang-engineering.com,
        andriy.shevchenko@linux.intel.com, conghui.chen@intel.com,
        arnd@arndb.de, kblaiech@mellanox.com,
        jarkko.nikula@linux.intel.com, Sergey.Semin@baikalelectronics.ru,
        rppt@kernel.org, loic.poulain@linaro.org, tali.perry1@gmail.com,
        u.kleine-koenig@pengutronix.de, bjorn.andersson@linaro.org,
        yu1.wang@intel.com, shuo.a.liu@intel.com, stefanha@redhat.com,
        pbonzini@redhat.com
Subject: Re: [PATCH v9] i2c: virtio: add a virtio i2c frontend driver
Message-ID: <20210322075700.gzxx6s3jrkv3sfai@vireshk-i7>
References: <e09c07532f5456816eb91ef4176bf910284df4ff.1616418890.git.jie.deng@intel.com>
 <20210322064144.y6kpajolwh2kd3lj@vireshk-i7>
 <dbb5dfe9-8ee6-e3f8-3681-d0ec83282930@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dbb5dfe9-8ee6-e3f8-3681-d0ec83282930@intel.com>
User-Agent: NeoMutt/20180716-391-311a52
Precedence: bulk

On 22-03-21, 15:53, Jie Deng wrote:
> On 2021/3/22 14:41, Viresh Kumar wrote:
> I think your optimization has problems...
> 
> 
> > 	bool err_found = timeout;
> > 
> > 	for (i = 0; i < nr; i++) {
> > 		/* Detach the ith request from the vq */
> > 		req = virtqueue_get_buf(vq, &len);
> > 
> > 		/*
> > 		 * Condition (req && req == &reqs[i]) should always meet since
> > 		 * we have total nr requests in the vq.
> > 		 */
> > 		if (!err_found &&
> >                      (WARN_ON(!(req && req == &reqs[i])) ||
> > 		     (req->in_hdr.status != VIRTIO_I2C_MSG_OK))) {
> > 			err_found = true;
> > 			continue;
> 
> 
> Just continue here, the ith buf leaks ?

Ahh, this needs to be dropped. You are fight.
 
> > 		}
> > 
> > 		i2c_put_dma_safe_msg_buf(reqs[i].buf, &msgs[i], err_found);
> 
> 
> i2c_put_dma_safe_msg_buf(reqs[i].buf, &msgs[i], !err_found); ?

Yes again, my mistake :)

-- 
viresh