Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3234776pxf; Mon, 22 Mar 2021 01:01:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyy/VL00EkqtKanHurpTXA7kEPgUi/H+bnkSgP00+nVHbzVb11OOuzsg1md4jLQaH0wrf74 X-Received: by 2002:a05:6402:1350:: with SMTP id y16mr24092587edw.309.1616400077035; Mon, 22 Mar 2021 01:01:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616400077; cv=none; d=google.com; s=arc-20160816; b=pBp3ElrP/dAGlJWL9sfEVWbnUWNGaQwsZ7ZwzYqYkBTNRjBQegehpSpXgyFcBXmKgF rzQckJPllFbR3u8yjih1f04qGx0yON0UYWVT4xP2n/Xrb24jOJa59EqAOPKXR+aUu9uA TgGqpElRljsRFkptyuXvJARUrbfLr+RgpZh3PyVMiGIprqN09ZRB3M1l8YyYBmPdLoc2 sgth9GVL4jOIOqWlPMn5yrlbi3NxO9oszJhQ0o7GX6MAC8lDSCrCyVZEJwxLFI/Wlerk dF+8drmW5Uon3XHFBn9eI1b7hoWoc/TaVkXx9VAWbY3X7DATWf4ojRED6D1XTqt4vrHT RnCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-filter; bh=qmuAsbc1u2WB88iRPhSwaVj6CjbmseXJCuXVFQ8QZpg=; b=Y7RylxlhKkc/G0JF7MAlWm4VEtkUeDCI6X18kLUlbWq7cJbV8EPLG13+t8cI8cBDPi K6WfXAECQ/kBKDt77t5qrwrWxykSRRhqdgCvMfUu/ykdTR22vTQ4gnBKZiNKYuXYUCKO kT/93VXpK41ELckRF3NRNAvijVMaurV4Vyq2PMTc1yD3vDUj5+s5AASAGSAFMGbiZKpJ 6PuHFz35DY6hA1TbHTi61+3bSMw5HKIZUxvX9D5q6aZzF+LLXsNyRa5QpbmUmzem0nNO KDyAh5okzsWdxeAvgjMeu3qIc/ZKHgjwE6uBBTr7i+J+Gb6vWVOU/gtrquBggtRyuuEX KMnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=p9KpG2ks; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g5si10543887edy.61.2021.03.22.01.00.54; Mon, 22 Mar 2021 01:01:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=p9KpG2ks; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbhCVH75 (ORCPT + 99 others); Mon, 22 Mar 2021 03:59:57 -0400 Received: from linux.microsoft.com ([13.77.154.182]:58400 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbhCVH7q (ORCPT ); Mon, 22 Mar 2021 03:59:46 -0400 Received: from [192.168.0.114] (unknown [49.207.199.95]) by linux.microsoft.com (Postfix) with ESMTPSA id AA61920B5680; Mon, 22 Mar 2021 00:59:43 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AA61920B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1616399986; bh=qmuAsbc1u2WB88iRPhSwaVj6CjbmseXJCuXVFQ8QZpg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=p9KpG2ksc/qSx9hiDockcv4LQgJIpQZvBk9roB/E3wKvqaa+raY8MnJBmRtuSRQRG 4HseaVU/Cxf8JZ8ozFpiTetVljcsY3Qylhz9A0qwq+zL9T++cocS23W+QAmCQ3l4ew 4ARO+a4pHwBr9gq01jgr3iU+8wHsBo5zemzcpFC4= Subject: Re: [PATCH v2 1/2] optee: fix tee out of memory failure seen during kexec reboot To: Jens Wiklander Cc: Allen Pais , zajec5@gmail.com, bcm-kernel-feedback-list@broadcom.com, Linux ARM , Linux Kernel Mailing List , OP-TEE TrustedFirmware References: <20210225090610.242623-1-allen.lkml@gmail.com> <20210225090610.242623-2-allen.lkml@gmail.com> <9a6c017c-d156-f939-f907-d6dfe83c41ac@linux.microsoft.com> From: Allen Pais Message-ID: Date: Mon, 22 Mar 2021 13:29:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>> >>>> [ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed >>>> [ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22 >>>> >>>> tee_shm_release() is not invoked on dma shm buffer. >>>> >>>> Implement .shutdown() method to handle the release of the buffers >>>> correctly. >>>> >>>> More info: >>>> https://github.com/OP-TEE/optee_os/issues/3637 >>>> >>>> Signed-off-by: Allen Pais >>>> --- >>>> drivers/tee/optee/core.c | 20 ++++++++++++++++++++ >>>> 1 file changed, 20 insertions(+) >>> >>> This looks good to me. Do you have a practical way of testing this on >>> QEMU for instance? >>> >> >> Jens, >> >> I could not reproduce nor create a setup using QEMU, I could only >> do it on a real h/w. >> >> I have extensively tested the fix and I don't see any issues. > > I did a few test runs too, seems OK. Thank you very much.