Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3235363pxf; Mon, 22 Mar 2021 01:02:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6aZiiOka7xt6VmTQB1Fpwe7AU7BNS1kOD3ek3Koe3kkgUfCICb9MgtugOlheBLAx/bodn X-Received: by 2002:a05:6402:1cc1:: with SMTP id ds1mr23797379edb.135.1616400139803; Mon, 22 Mar 2021 01:02:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616400139; cv=none; d=google.com; s=arc-20160816; b=rlG9msYOcHsAakYuyM+h4CBBGBLgKWeiYQIKRtjY0vFZRWY5o7fdOxacPiKfPNFgkc vNlSwfi9ZmIGDV9EfeFqIYfItXRyWofgoy8IjzPtYeK01Rb4AoT6NX5MtwO+XpCUCVyS c/VCHrM9SAt6F9iwNw4/Kpzr8CUcUbXzJVfFcUUqxCTW79gaBRz4B+FUTDRu+G26pLjj 5krwcwtodvaRnfnzZnI4hV5NlDKXfq3ssVvkHAVEB3wRKtyHO1ujh0xzy6+qUb/ZZeV0 gtlysyZlW/2ciJQO7rXghT1MXMm1OrqEOeDWkA+Nwgdm37QT4MymvkRz666Q+hyq7bzo EZkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=sGf+kwZW/wFP+9L+f/Acn8ft874BxO79I+2RdR2Ljro=; b=Az+bywgj+R6ePuE71Y2v8jFD76Dg/VBiNoJZjJfJP2PHAbol0spOkRtLqMbNunwazC 6NZRFLV1Fur7oSV+RH2l0BSau1k0mUGp8uJSvFEzpVV5OieXdl9ukW2CobqfHXw7dRcL 4opLbEK/vaqioYMRIYEltCoi2Ed63koakAf/Mr4wc2pDapnwfHcW6t5psEFX+t+UUgoC ltqIdX7ilXvkHSbDu/x7nIgUvcGGKPq9nFv84qAq6NEXsERPSHpHuIAhfwIfy8mTGEU7 X4dzg/VlhBRBBD7OKi64cA0ieG5z3c9V7WmWoljLW7BshsYvJs886kLmrBa7/M0PkVRH 7r3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zYOBtMnD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h26si9949771edw.139.2021.03.22.01.01.56; Mon, 22 Mar 2021 01:02:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zYOBtMnD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbhCVH64 (ORCPT + 99 others); Mon, 22 Mar 2021 03:58:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229879AbhCVH6Y (ORCPT ); Mon, 22 Mar 2021 03:58:24 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D9C4C061574 for ; Mon, 22 Mar 2021 00:58:24 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id t20so6109472plr.13 for ; Mon, 22 Mar 2021 00:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sGf+kwZW/wFP+9L+f/Acn8ft874BxO79I+2RdR2Ljro=; b=zYOBtMnDt3uvZ32hAu89RQU4ZZsrmM60m26MQ4CUJ7FsZE28fioehItLrKUI/cVcX9 n4dft/MaV2jLEONuV59lCXv2Qw8E1Pb4KjmRECmU0uNnDZsCjEa3+B3VBUUxXtuO63zv HJhdwxgZJrWu/0naL93G7rJvl1n0sLc6ECynFYmlUjXBXdr9Z9ntKakESU55rMuP1NzL fDtD1d7V3U3ldcPmpqlJwCzk8CYc0QtQPFvuigF6pB1DYLMAM/WLRkSOFlmFRGi+eVkt nhOu2psV51aRVVgfBs0HNkWh6Yg3ica4wbnQ9PVlm93vTl+/pFw0VyairmnLC7Tt863C zUbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sGf+kwZW/wFP+9L+f/Acn8ft874BxO79I+2RdR2Ljro=; b=sgUHZd3ryEXUJWK2+nmCvVuqnWQ7tBn6st1/oX/hn/lWd1h4TUq8OKWhbc90QwjW4P bzcGYJZEcKjOujSrHmOrGJ/WO9MNoh6WPmh6mqX+5CoaZFBf2Cdo3SJYHNn2ZW3T9dSl QJVeQ5ObOpSk8RG8V3kHdggyPyib8OH3enV1jxN35ru59HbGNaeuNpD9K5rhpHEQ17m8 bSXsoe4dxVdSzJ5U9KQHWNroDaHyfdxwcXy4CkqLpYJfh6kAfBlt+a77YTaeEp5XsuYq B5LRaUjdwP4zrzWmDSdtlq9sBchOxjwV3Z9VoOahnQBnCecCPF1/dAEzfrifbskStj2o PaYA== X-Gm-Message-State: AOAM533nHHf9POY6Ltr6ZPd/xxP1IXj+B/SS31OIcyyPEraHMTBriiBj SB/pZxxsyKSBqNpy5yRtysLB3w== X-Received: by 2002:a17:902:834a:b029:e6:b6bc:f58c with SMTP id z10-20020a170902834ab02900e6b6bcf58cmr26215016pln.85.1616399904057; Mon, 22 Mar 2021 00:58:24 -0700 (PDT) Received: from localhost ([122.172.6.13]) by smtp.gmail.com with ESMTPSA id z4sm11601770pgv.73.2021.03.22.00.58.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Mar 2021 00:58:23 -0700 (PDT) Date: Mon, 22 Mar 2021 13:28:21 +0530 From: Viresh Kumar To: Jie Deng Cc: linux-i2c@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mst@redhat.com, wsa@kernel.org, jasowang@redhat.com, wsa+renesas@sang-engineering.com, andriy.shevchenko@linux.intel.com, conghui.chen@intel.com, arnd@arndb.de, kblaiech@mellanox.com, jarkko.nikula@linux.intel.com, Sergey.Semin@baikalelectronics.ru, rppt@kernel.org, loic.poulain@linaro.org, tali.perry1@gmail.com, u.kleine-koenig@pengutronix.de, bjorn.andersson@linaro.org, yu1.wang@intel.com, shuo.a.liu@intel.com, stefanha@redhat.com, pbonzini@redhat.com Subject: Re: [PATCH v9] i2c: virtio: add a virtio i2c frontend driver Message-ID: <20210322075821.x6firpcpnuohf6y2@vireshk-i7> References: <20210322064144.y6kpajolwh2kd3lj@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-03-21, 15:53, Jie Deng wrote: > I think your optimization has problems... > > > > bool err_found = timeout; While at it, see if you want to rename this variable as well to something smaller, like "failed". I didn't touch it as it is a matter of personal choice, so leaving it to you.. -- viresh