Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3239233pxf; Mon, 22 Mar 2021 01:09:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwF74xYU/KxgJQB7MtQRhcCvV7Q2Mt9BwJ28iE2rVQqDwSlaB66YdSNoiC4X/zEnljk1cdh X-Received: by 2002:a17:906:39a:: with SMTP id b26mr18395506eja.158.1616400567054; Mon, 22 Mar 2021 01:09:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616400567; cv=none; d=google.com; s=arc-20160816; b=nKti0Gcxm2oDYWwGydLfGNuhZ5d3lU0ogMvuB1UwyYafElgDtkQGOOT/tUSNdbz1W1 opLiWkD54cRosVYq2dTunX8N90P31++rfeoXDmgzDBoIXBfuXvH/ueu6dxkAM55qwzOd Dp6rXyDupzodXAKbtkoSsnLrGwqKkjz5d4RMCowPV65TGG74X3J0AysSg4cXeChMQfX3 jL1JDpbeiAwlvQYxtQTCg6xQDA/wq5bJ9VBJt5ENAGgSWn41r6yQmh3dBrVWv+1yVh+a scO2sdSQbojWNjEIhahUpujwZrAHBwXFxazfEppLvkm2s1QNDKjE1LFpuMD/KdUfCFII /vfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TbYveShLYeVqBDd6OuMK3KKplXpJFMY9UQBn/f/mXuk=; b=bHM6t6JwuMiM8OMxb2LrG8osxP2gWOABAoDcPNWaKM4REviNdfAfosvsemtDWlp+BR gQe8JoaJeWEfFvRHl0/FztinGMY3p4RfnY1hoMV7NCxXxDGb5t9D7NE9MKYV658Qb4Zw wMtlq7J5G+HDQP1Tv+qSqcu9bcQuxjD3eG0xpVP19pBLR6GxllklXckO2fLX2COSOUH+ 81zL7sang+XA4BzwRIkuFrGmRpeFSramsYHsLq9dm3VaNgIWNmMNsnaSXsGAc6n8AzEx 2OWZA+au3UPIXrUHCivaPqU+4PGS3DFZEwCk96pC4kxIq7h8Qm8whaEeFKbO8MN4Hx9h oLPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=oUINOzWN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u7si10800694edo.259.2021.03.22.01.09.04; Mon, 22 Mar 2021 01:09:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=oUINOzWN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229647AbhCVIIH (ORCPT + 99 others); Mon, 22 Mar 2021 04:08:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbhCVIHm (ORCPT ); Mon, 22 Mar 2021 04:07:42 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FF3DC061574; Mon, 22 Mar 2021 01:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TbYveShLYeVqBDd6OuMK3KKplXpJFMY9UQBn/f/mXuk=; b=oUINOzWNzUdAROCRX5M78JAJO+ HoCGe1ia4mvzSj9k8yi/ZlT/4E14wgYfKSCd7VnoLGoT3+IeEiDZvgBu7dSfnzQ/+dk8xDLcENX6t T62vKVi6lP7Dxtk5Y7hMV42i54rIMh6BieObBd3sq8YrAUWxADN7eE8bILypdhoQfZt10ko2R5kmP FKRNEfQbbbxfKutmUNBnmE8VRp3WnpG4d2p/U029bk06ERSvFupgAaZH7ekvMTRw0abD/XlT2e6WN VYmPuXFM5fy/UxIc03SwLmBfIoqM0/miKbVR1dK4DsvopqYGUZ4VPQRjREXIsd9EY31n3bI0MpaII aqQPm2Lg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lOFaM-008BRm-9O; Mon, 22 Mar 2021 08:06:55 +0000 Date: Mon, 22 Mar 2021 08:06:50 +0000 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v5 01/27] fs/cachefiles: Remove wait_bit_key layout dependency Message-ID: <20210322080650.GB1946905@infradead.org> References: <20210320054104.1300774-1-willy@infradead.org> <20210320054104.1300774-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210320054104.1300774-2-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 20, 2021 at 05:40:38AM +0000, Matthew Wilcox (Oracle) wrote: > Cachefiles was relying on wait_page_key and wait_bit_key being the > same layout, which is fragile. Now that wait_page_key is exposed in > the pagemap.h header, we can remove that fragility > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig