Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: +5LGUCiYanJvNATkRPiU0SWv0YZbLI2vz/9T5NK+SoEyhmyvxduxjvnHJJu0MtWFEdKj72ViUv
 s3T6vt3jL671y8Tu0CMpUdi/4wb3J8/MYx/yiYXTtnv9NjvyB9e9mr77cBxj1Aib01PhZI8cMX
 pkfhe3S1PckQTsf9xWjmEfsGsaJ+buyoJJQ8JbVjPpKywFz6fVg+aDlI4a06Usptyc//Am7XvF
 IjZE+I+fNJdf/uakrn6ArUkcIef9OpyJ6emniQVApuKLFKMRkq7UEAbjaSr4fYY2/YsGWMmzFY
 AU8=
IronPort-SDR: 0mXobf63eiUJpdenwZUNb9JRZnBmklVmRW28IidQfZ4O7MDyjYZL2+QqOgUCFYRHQQF+g/LLHE
 jk8a7fcLCsIJ+NDE9eq6WduAbptexfRgmlwVo7HzbD+kjlghuvVoh+pmONgmfAGRwHChAP9PZR
 QNPs5WNFLyp49lE/ykwr8lWhQUVE3kpZ8a2GWD8nBC9yZDW8to57lwsIvW8tpDh7OvLiN7Xz1x
 iUQG7ZXrO0vsncaReMLiZcF0u98GE+4+DTAU4kG8u6zBg3d7tI4GMUow7Im8/0n3tC8OG4S6bR
 xv/4ITMnohbvAdNhjtbCjjhN
IronPort-SDR: yQh4PsxrU+2lpuOGjOkO94PSBc+5KoSHsmUGiALm1sh9BD8UKzAZa5WShTrddv87NzuyoiSAdt
 UPERYgFZmOHS6Ijus9Cq8Ld32CD1wRbjZfsPBmtxAhk3KqSTMnNudbf4QdJbcLdmjS2ve8zuuh
 c9+wVsJ+zFvmpAOj7P9on9A7/no8cbTOhqwKV/0CyBvca+EmEq02lw72a8eVC+1djjrel1Jh5f
 tg0aLuETdsj7Brp9vvLiqmn5NBX78YtEZhWPFkeHTFxfA18DBjSkZeXuHTHOXgSMg4TiFa8lr5
 VwE=
WDCIronportException: Internal
From:   Avri Altman <avri.altman@wdc.com>
To:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     gregkh@linuxfoundation.org, Bart Van Assche <bvanassche@acm.org>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Daejun Park <daejun7.park@samsung.com>,
        alim.akhtar@samsung.com, asutoshd@codeaurora.org,
        Zang Leigang <zangleigang@hisilicon.com>,
        Avi Shchislowski <avi.shchislowski@wdc.com>,
        Bean Huo <beanhuo@micron.com>, cang@codeaurora.org,
        stanley.chu@mediatek.com, Avri Altman <avri.altman@wdc.com>
Subject: [PATCH v6 08/10] scsi: ufshpb: Limit the number of inflight map requests
Date:   Mon, 22 Mar 2021 10:10:42 +0200
Message-Id: <20210322081044.62003-9-avri.altman@wdc.com>
In-Reply-To: <20210322081044.62003-1-avri.altman@wdc.com>
References: <20210322081044.62003-1-avri.altman@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

In host control mode the host is the originator of map requests. To not
flood the device with map requests, use a simple throttling mechanism
that limits the number of inflight map requests.

Signed-off-by: Avri Altman <avri.altman@wdc.com>
---
 drivers/scsi/ufs/ufshpb.c | 11 +++++++++++
 drivers/scsi/ufs/ufshpb.h |  1 +
 2 files changed, 12 insertions(+)

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 4639d3b5ddc0..f755f5a7775c 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -21,6 +21,7 @@
 #define READ_TO_MS 1000
 #define READ_TO_EXPIRIES 100
 #define POLLING_INTERVAL_MS 200
+#define THROTTLE_MAP_REQ_DEFAULT 1
 
 /* memory management */
 static struct kmem_cache *ufshpb_mctx_cache;
@@ -747,6 +748,14 @@ static struct ufshpb_req *ufshpb_get_map_req(struct ufshpb_lu *hpb,
 	struct ufshpb_req *map_req;
 	struct bio *bio;
 
+	if (hpb->is_hcm &&
+	    hpb->num_inflight_map_req >= THROTTLE_MAP_REQ_DEFAULT) {
+		dev_info(&hpb->sdev_ufs_lu->sdev_dev,
+			 "map_req throttle. inflight %d throttle %d",
+			 hpb->num_inflight_map_req, THROTTLE_MAP_REQ_DEFAULT);
+		return NULL;
+	}
+
 	map_req = ufshpb_get_req(hpb, srgn->rgn_idx, REQ_OP_SCSI_IN, false);
 	if (!map_req)
 		return NULL;
@@ -761,6 +770,7 @@ static struct ufshpb_req *ufshpb_get_map_req(struct ufshpb_lu *hpb,
 
 	map_req->rb.srgn_idx = srgn->srgn_idx;
 	map_req->rb.mctx = srgn->mctx;
+	hpb->num_inflight_map_req++;
 
 	return map_req;
 }
@@ -770,6 +780,7 @@ static void ufshpb_put_map_req(struct ufshpb_lu *hpb,
 {
 	bio_put(map_req->bio);
 	ufshpb_put_req(hpb, map_req);
+	hpb->num_inflight_map_req--;
 }
 
 static int ufshpb_clear_dirty_bitmap(struct ufshpb_lu *hpb,
diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
index c2821504a2d8..c9b8ee540704 100644
--- a/drivers/scsi/ufs/ufshpb.h
+++ b/drivers/scsi/ufs/ufshpb.h
@@ -213,6 +213,7 @@ struct ufshpb_lu {
 	struct ufshpb_req *pre_req;
 	int num_inflight_pre_req;
 	int throttle_pre_req;
+	int num_inflight_map_req;
 	struct list_head lh_pre_req_free;
 	int cur_read_id;
 	int pre_req_min_tr_len;
-- 
2.25.1