Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3241854pxf; Mon, 22 Mar 2021 01:14:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxX2EWfX2WocRVo5MKsL1+XCKsxLltCG4EOk/ccjUUv+XiR024dgYloGn+8eXS5bXi0BtZ3 X-Received: by 2002:a17:906:1519:: with SMTP id b25mr18112330ejd.254.1616400861158; Mon, 22 Mar 2021 01:14:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616400861; cv=none; d=google.com; s=arc-20160816; b=YLovuCNMBI7Shljynvg+TCm0dbCYdsRovAp4aPRYCFouWq4D3Doh4jHgHYo58qGOtV T0/nrh7jRvNsbLHYCktLntYYz1oh6PDVmWsFCNyhToWApu+RMBypC3lvXOkJ0q5L4Hsf dXr3CqrRv/SvQET8ZmDzu7DYaAH/FCqnuRMl1pzFi8tMI7+lUmBUFvNj1M92S/hvvLhR vpuC8aeHejw+sjgdtN2xqUcqtLr+6AcQS6lMP272Hrwv8lw12eLqlyXFnZjcOXQEKgs3 9w+FpMUEa797xYIzzRbsOcc4tZgNKy8zGUwGfiQJf9Cvk6aCxMj+Mq9BP67hAMZLecGs i2Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0Gom5lIOcdXHDFkwwTX/JWMweB4RudLWTzTu1Kol3XM=; b=QPb4xbL60p3CIQLVGmxMGXSAXFAoKgPklQ8Yd8yH9c3zuLXvl/sYv4cll4ac3zI5gm PRw4zId8gVwmKLYMRMZja94bHlc35h08RenPpUg0ByThrgjtYWSJxqNIfyXifhalyXQc xU6pQ7xpBGnFh3yR57aK5Gp2n9vfxKUdOUWzAfBCZYMgEtgMx18KSfKFZDOL2EFaqh7P GGbtx7SW7Epw3x35ePP/vQ60LSUGRnKTCP2243cCfvkkHWXdpgtuQ94W85RwmbOoyHI0 6EdxsHtgPn7zp2bwVJajlQcDi16XbvVP4EUf/iMV/+WsG5dx1UPhMPF1w+VrG8wvEmqM I8iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=JyJG6OQw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jx25si10449304ejc.382.2021.03.22.01.13.58; Mon, 22 Mar 2021 01:14:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=JyJG6OQw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229760AbhCVIKx (ORCPT + 99 others); Mon, 22 Mar 2021 04:10:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbhCVIKl (ORCPT ); Mon, 22 Mar 2021 04:10:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66962C061574; Mon, 22 Mar 2021 01:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0Gom5lIOcdXHDFkwwTX/JWMweB4RudLWTzTu1Kol3XM=; b=JyJG6OQw9jHUMAM4Ha8nIensbI 9fZiw/I5PHU+KACQauDg9T+mvu6hIIUAwAXbWasK7pdDRaKG98c2hqagwjW6Ay1hIKXKnFNc2p26o BId9OrjcFEM5zhFLk9MMy6f6kGnEeXar1ZVotYRwHdZ5zBVMIZgToOz36vhi7lffHa+KFbJy2v09a e8TyGo2crikf1T/fodSFlmVdvvk30haS4s95hnoSh+41au08sn8ScErTl58edbOIyZKJHKUAUUIhx Lm33TT6XoLTpBOnLqhqFKKZM2Nk5r56IXwWL5vaJSjRD34k/rRMfvJ7Nht+Ov2NcRl2dipUfU9O3Y M8zY187A==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lOFcB-008BcB-Vl; Mon, 22 Mar 2021 08:09:01 +0000 Date: Mon, 22 Mar 2021 08:08:43 +0000 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v5 03/27] afs: Use wait_on_page_writeback_killable Message-ID: <20210322080843.GD1946905@infradead.org> References: <20210320054104.1300774-1-willy@infradead.org> <20210320054104.1300774-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210320054104.1300774-4-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 20, 2021 at 05:40:40AM +0000, Matthew Wilcox (Oracle) wrote: > Open-coding this function meant it missed out on the recent bugfix > for waiters being woken by a delayed wake event from a previous > instantiation of the page. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig