Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3248871pxf; Mon, 22 Mar 2021 01:28:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgmiIfvRFyDfVdqxwCvtaD9Js5crycWk+namr6h4DVGym6qoS36UIezfV/Qy08rMZJJRQZ X-Received: by 2002:a17:906:4055:: with SMTP id y21mr17737311ejj.507.1616401712518; Mon, 22 Mar 2021 01:28:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616401712; cv=none; d=google.com; s=arc-20160816; b=oCZIOialRWzldWT2swYqrFmQB0Pwo/1/Yqm0NCiJ+wM2atkaSauyBE6eEXZw2TWbP9 e/ktkGu7TugB61aX0oA7uliROcPrPpXY2Vdunq9dt7wIKUTbMyoZXQjS9AEg+bmSG29f RtMTVZ1c7Kyls2zznvSzaPzdzGA5R5pBYSpygsyrmskI4Da0WmLrS28cGnTNuGOx+KPo AVVlrBM+u8gBlvlmI6lTSZeuKwUJTx9HLgOAnqfKnk9mTplIEm5q8ry0HtB3Vl6TQ+Yh p6QDk0evsBFhHZVjHpsrcV21ldr0TCYnPiW3BofUOZGFilWKJ4ofYwa8pD5KJ45qwYOx HggA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6XDm6dbry0r+YwRaSouAqsdbNTu+SUnf4rka7kXFp4s=; b=GMoIrr1ajqrhQaVgTSoxqVfPWtG24XO5c5twTi7bQXVW2SKUQ664+ixBEiwPnMeun9 Zz3hK7nwqtNG4ELnF7BabvlbEZ/5GIn9qUm3YL47fID0hB5E4mdYkh52WYtcFXB17JX8 56y84aUkTcqwVmI6nCD6URtPeDxMvrLo3Rncp5epmR3A4LMJ14L+FArRyEYF3ftzAB7v Ik/smI9y8zHhImxojLCnVVLTjF+3OOxVL09spDAkB6Tpusc1L9h/i9C61HvC1VhpxUSi d29P/aB382J3JtT1PcrlaVibF2cyhCHGP0aHIZsj66vnmTA+mNf78KARz38SQy0Ym1E0 Xh+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=faZMeub+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a23si11252750eje.83.2021.03.22.01.28.10; Mon, 22 Mar 2021 01:28:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=faZMeub+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230118AbhCVI1f (ORCPT + 99 others); Mon, 22 Mar 2021 04:27:35 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:34504 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229973AbhCVI1D (ORCPT ); Mon, 22 Mar 2021 04:27:03 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12M8Qc2Z130183; Mon, 22 Mar 2021 03:26:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1616401598; bh=6XDm6dbry0r+YwRaSouAqsdbNTu+SUnf4rka7kXFp4s=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=faZMeub+NihFppV8JJFPUIGbk2KZ+Rl3fHm4MhKWziqBDfkrCeFNHDkrQGZxoNKl/ 5pezCoXQ7MTwIMbbluCBB0ebDjrOl4XFOEoYSbXg/gE94A1zSfQVark9fItGiRgyJC xBqfZNnexsUGO/zSBwl5YVA8wyJ3eTmY32djiFjg= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12M8Qcgf116234 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 22 Mar 2021 03:26:38 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 22 Mar 2021 03:26:37 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 22 Mar 2021 03:26:37 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12M8QbfD038199; Mon, 22 Mar 2021 03:26:37 -0500 Date: Mon, 22 Mar 2021 13:56:36 +0530 From: Pratyush Yadav To: Tudor Ambarus CC: , , , , , , Joe Perches Subject: Re: [PATCH v3 2/2] mtd: spi-nor: swp: Improve code around spi_nor_check_lock_status_sr() Message-ID: <20210322082634.6bpgsvpofw7o4pml@ti.com> References: <20210322075131.45093-1-tudor.ambarus@microchip.com> <20210322075131.45093-3-tudor.ambarus@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210322075131.45093-3-tudor.ambarus@microchip.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/03/21 09:51AM, Tudor Ambarus wrote: > - bool return value for spi_nor_check_lock_status_sr(), gets rid of > the return 1, > - introduce temporary variables for better readability. > > Suggested-by: Joe Perches > Signed-off-by: Tudor Ambarus Reviewed-by: Pratyush Yadav -- Regards, Pratyush Yadav Texas Instruments Inc.