Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <75df140d2167eadf1089d014f571d711a9aeb6a5.camel@gmail.com>
Subject: Re: [PATCH v31 2/4] scsi: ufs: L2P map management for HPB read
From:   Bean Huo <huobean@gmail.com>
To:     daejun7.park@samsung.com, Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Dukhyun Kwon <d_hyun.kwon@samsung.com>,
        Keoseong Park <keosung.park@samsung.com>,
        Jaemyung Lee <jaemyung.lee@samsung.com>,
        Jieon Seol <jieon.seol@samsung.com>
Date:   Mon, 22 Mar 2021 10:11:47 +0100
In-Reply-To: <20210322065410epcms2p431f73262f508e9e3e16bd4995db56a4b@epcms2p4>
References: <20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p5>
         <CGME20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p4>
         <20210322065410epcms2p431f73262f508e9e3e16bd4995db56a4b@epcms2p4>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-03-22 at 15:54 +0900, Daejun Park wrote:
> +       switch (rsp_field->hpb_op) {
> 
> +       case HPB_RSP_REQ_REGION_UPDATE:
> 
> +               if (data_seg_len != DEV_DATA_SEG_LEN)
> 
> +                       dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
> 
> +                                "%s: data seg length is not
> same.\n",
> 
> +                                __func__);
> 
> +               ufshpb_rsp_req_region_update(hpb, rsp_field);
> 
> +               break;
> 
> +       case HPB_RSP_DEV_RESET:
> 
> +               dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
> 
> +                        "UFS device lost HPB information during
> PM.\n");
> 
> +               break;

Hi Deajun,
This series looks good to me. Just here I have one question. You didn't
handle HPB_RSP_DEV_RESET, just a warning.  Based on your SS UFS, how to
handle HPB_RSP_DEV_RESET from the host side? Do you think we shoud
reset host side HPB entry as well or what else?


Bean