Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3278916pxf; Mon, 22 Mar 2021 02:29:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5ZBO65KKN1EZChyZWFHCM8lZIKB0CKseTiSRGjQQnGwnOaYEAwcs/mTqOpbm7Kj8L7L4h X-Received: by 2002:a05:6402:3089:: with SMTP id de9mr24929919edb.10.1616405367221; Mon, 22 Mar 2021 02:29:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616405367; cv=none; d=google.com; s=arc-20160816; b=petijXJ54ZRh/TOPCaZwM4NZZ0/uGgZDtNE32hEmV9PNczB6o7OmRcNS/VEn9nLm7c /MYBUAsfvmKFZhlZ04wwVY6aRSExV5/96WlzR4RXydTgik8LKX3VX5Hd4TyqksTWIYwe 6Zp0ByuxVq8LuUtGiq3Qae9QY+OZtEy36MSmdCpgkfINs8i/Np4dPI4nwcfeKdIDhx4v QWIZmmrKzrugWI1IDC0fi1LSicSkHvMC2T2deV+1/Uc3CZKynxoC88ilijDGoIqtiKBL Ii/QMYOeUvEyvFgaB7rPFFn9yGC79RhfadYN2Dqlz+NuLgaym505U8BdFK9/Spn1F7UV rvVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=AM5PYcagQbtDg3NrFzWha9n5u8jY/mxXCcbX0fzIUlk=; b=fRGvUbXoFfGsNGgAzeiEX1gVbV5xKnkbKmcaop/9CM/jRPkrDZz9kuL5mJblnGy7u1 CRQ+xrBgyG1Eiy4vbEsEG5XuDm30BJTyHySolTaluEuROsk9NQ7/5nkcJ9ftIYrA+PXw 4nCqBl7BF5DiM642+3G/Fooiw9V11lIKiAeNp3g+dBjGqkNZn0kDMX8naPiPrW7amLUZ rNnqe/XI5rETjU0Fcyv6B5cpvSbrHDNo7/FwHpMbgIzbtqVWAErc7zOXxflY7p+kQfb7 Qm0e6sLN4s0x/Xzk9SYcp7F9EXg47E72B1DfSIX2y9kKd28K99A+ADEGaVCDl9XmPnR1 BitQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Jf/p0uMl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c18si10587473ede.125.2021.03.22.02.29.05; Mon, 22 Mar 2021 02:29:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Jf/p0uMl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229883AbhCVJ0J (ORCPT + 99 others); Mon, 22 Mar 2021 05:26:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27426 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229865AbhCVJZt (ORCPT ); Mon, 22 Mar 2021 05:25:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616405148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AM5PYcagQbtDg3NrFzWha9n5u8jY/mxXCcbX0fzIUlk=; b=Jf/p0uMltl/O21PvjfHNUkl+Mj7d4iTnz4QfGJxPMSh0dnia6s/mXCN+zilemIKExdoQ4z z+1llgHa4oN0qNHjQ/sILE+naKjdMSzbq13B0lL7m888yaYg52BPNXDYTYXc6CjxDmLYPT 6T4V9WcVaH/KJ3OvxzOsRLen24FTdlE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-249-c39_QNLyMOaD17Z6n2Owsg-1; Mon, 22 Mar 2021 05:25:45 -0400 X-MC-Unique: c39_QNLyMOaD17Z6n2Owsg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 65115108BD06; Mon, 22 Mar 2021 09:25:43 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-58.rdu2.redhat.com [10.10.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id AAD2B2CE8A; Mon, 22 Mar 2021 09:25:36 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210320054104.1300774-2-willy@infradead.org> References: <20210320054104.1300774-2-willy@infradead.org> <20210320054104.1300774-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v5 01/27] fs/cachefiles: Remove wait_bit_key layout dependency MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1878126.1616405135.1@warthog.procyon.org.uk> Date: Mon, 22 Mar 2021 09:25:35 +0000 Message-ID: <1878127.1616405135@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > Cachefiles was relying on wait_page_key and wait_bit_key being the > same layout, which is fragile. Now that wait_page_key is exposed in > the pagemap.h header, we can remove that fragility > > Signed-off-by: Matthew Wilcox (Oracle) Acked-and-tested-by: David Howells I wonder if this could be pushed directly to Linus now since we're relying on two different structs being compatible.