Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v31 2/4] scsi: ufs: L2P map management for HPB read
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Bean Huo <huobean@gmail.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Dukhyun Kwon <d_hyun.kwon@samsung.com>,
        Keoseong Park <keosung.park@samsung.com>,
        Jaemyung Lee <jaemyung.lee@samsung.com>,
        Jieon Seol <jieon.seol@samsung.com>
In-Reply-To: <75df140d2167eadf1089d014f571d711a9aeb6a5.camel@gmail.com>
Message-ID: <20210322094534epcms2p5b2c0e5b18307f98a17bb385ee64bdc2c@epcms2p5>
Date:   Mon, 22 Mar 2021 18:45:34 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <75df140d2167eadf1089d014f571d711a9aeb6a5.camel@gmail.com>
        <20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p5>
        <20210322065410epcms2p431f73262f508e9e3e16bd4995db56a4b@epcms2p4>
        <CGME20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p5>
Precedence: bulk

Hi Bean,

>On Mon, 2021-03-22 at 15:54 +0900, Daejun Park wrote:
>> +       switch (rsp_field->hpb_op) =7B
>>=20
>> +       case HPB_RSP_REQ_REGION_UPDATE:
>>=20
>> +               if (data_seg_len =21=3D DEV_DATA_SEG_LEN)
>>=20
>> +                       dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
>>=20
>> +                                =22%s: data seg length is not
>> same.=5Cn=22,
>>=20
>> +                                __func__);
>>=20
>> +               ufshpb_rsp_req_region_update(hpb, rsp_field);
>>=20
>> +               break;
>>=20
>> +       case HPB_RSP_DEV_RESET:
>>=20
>> +               dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
>>=20
>> +                        =22UFS device lost HPB information during
>> PM.=5Cn=22);
>>=20
>> +               break;
>=20
>Hi Deajun,
>This series looks good to me. Just here I have one question. You didn't

Thanks.

>handle HPB_RSP_DEV_RESET, just a warning.  Based on your SS UFS, how to
>handle HPB_RSP_DEV_RESET from the host side? Do you think we shoud
>reset host side HPB entry as well or what else?

In the JEDEC HPB spec, it as follows:

When the device is powered off by the host, the device may restore L2P map
data upon power up or build from the host=E2=80=99s=20HPB=20READ=20command.=
=0D=0A=0D=0ASo=20I=20think=20there=20is=20nothing=20to=20do,=20because=20UF=
S=20can=20build=20from=20host's=0D=0Acommand.=20Moreover,=20in=20the=20case=
=20of=20the=20HPB=20read=20with=20invalid=20information=20by=0D=0Adev=20res=
et,=20it=20just=20processed=20as=20normal=20read.=0D=0A=0D=0AThanks,=0D=0AD=
aejun=0D=0A>=20=0D=0A>=20=0D=0A>Bean=0D=0A>=20=0D=0A>=20=0D=0A>=20=0D=0A>=
=20=20