Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3327541pxf; Mon, 22 Mar 2021 04:00:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLVAvn2ywQ1dLsP+9iJeVgQdmWJjW08uLt6/PEWH0z2uPQDc9d503dQ4jYPugorPuEIQj1 X-Received: by 2002:a05:6402:34c8:: with SMTP id w8mr25828328edc.235.1616410844876; Mon, 22 Mar 2021 04:00:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616410844; cv=none; d=google.com; s=arc-20160816; b=t5uapx79pCBFcx+F4j3ro/n4/7lt/XEp/rowFGY9sJNTWPyaraH1eLwXig06iYYGX8 LW04SP5mgs1Eh34yNMVLC3c9LkOc51B0HGHxucU+BhMTlfDoV5MyZWfmj93vmnFdx6B8 rJzeQ84ENHbiqQ88qyIfbumvCdccQa6c1EgKDsakufO7vO5IpMTR228hv2jTwcNcHxVN d3iQ2/0+d9UYcU9WdqdEU+6NgBxzbyticCvjByn9T04V/FhO+V3zYBdNNkOE1Q2RUlcj CLgKuAzw6iQy8HUatfD5gGMFUEyA6oUICZ9wxDB/vvBohygB3mo9MN7tHRpQ+ziN2DJp ZTaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=vwLiE2bX+yZQRxKPUW5syuzepbqLkakQZz431wRPu+k=; b=KwCUtvzO0A6N6zxBTm3tIbzkETZoCk2QvMbp1qpHOzPAAaGYO3kgEaqj3eVR2RYZ83 rz6uBH/xxn5UfIH+xpSTLBVSU068R/ZA/RswqPXuYHZijhwWTAvrHEJ28UxYL6rzwVAv 1rnya5nNTYx5WCWm06VAWPxQxmLzBF/1of9LG5ZrmSqDT492WM2hRfkrL+48YJubyfl2 AyJJ380frOeJdM/Il+AntlGqNDHUljMffZgR2yW5Q6YU/bYyqxg/CbF6BenE9V5tYKya fRcAuxtoIjROg7/1T13iCKm+oeYeX3gYkPh3HotsxF4MWdcjbdIr5l6iIHB+hLMB1N6z IkDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oGFV5APu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si10390183edp.277.2021.03.22.04.00.21; Mon, 22 Mar 2021 04:00:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oGFV5APu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230434AbhCVK6h (ORCPT + 99 others); Mon, 22 Mar 2021 06:58:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230267AbhCVK6U (ORCPT ); Mon, 22 Mar 2021 06:58:20 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B07AC061574; Mon, 22 Mar 2021 03:58:20 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id y19-20020a0568301d93b02901b9f88a238eso15453408oti.11; Mon, 22 Mar 2021 03:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vwLiE2bX+yZQRxKPUW5syuzepbqLkakQZz431wRPu+k=; b=oGFV5APueIU8gAuNWxZzNp7WcUMlP0RALZ9VcqyZQz0r9zhhlsY6RE2s0RkL25gWA1 HHo4nLZJdFyffHSYVonlXIZ0mh5dXDZCQZOKc51X242nMvDx0ouITEA2GKNZ2b/VagPl c7AzWuLkt4tuXHnr2gVCDDjdW7mQ1E2BRCzhPltRgVZnOB4Oq9Zb5OSlUhlq5tgFLfgf UW8bqhyV51NPcNEKGQD/F9Di0XOmT5X4WixJ/CuHK/RnvrR+8W0SFyErLdYoVRn9THNt VZ1/64CwCOtK3uHqDX8LdjLBKLJh5bPn+K/qiJ+fhunzK4WhodhFnKiDGgwcWFEqQMQy HjQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vwLiE2bX+yZQRxKPUW5syuzepbqLkakQZz431wRPu+k=; b=UkHortrU3nfNNdbkPbXZGH8as0oGEvMiU4LJsQICPN1H7UTPHyoMkYob8FZUsuqW2y K/EZ4axYCeqgFKBAF29sfd21bU03pqPUDDFMg1vcc4R3FuSkGbiGhrnaMW6YiOMqJMCO Zwpn0Dt+Ieen7ce1Gg9svKydPRerI0UV6dHK3ZiB3mkvVTL3DAlwHZODVg+hgWcmJAQf ria98g6vSK+05IwC4neLiL+OHsd4v/YeFsaWzjajyaS776ZMs9FFkpKzTVkdiukSSOwP qEkq8YwHdfW3qcmbYuOGXB7/ar6CwGZ3ad2/MZLmkjz/xjn2mJo+QahmAhO7d3XIwFTV +NHA== X-Gm-Message-State: AOAM532E+Pr79hgAXYeyg29lkDM8drQbScjnxeSIfjNkCzswoOEZFl1t pWoRHY93o9CULl9Gl4+Y+MrkdHE4wdXZjv206LY= X-Received: by 2002:a05:6830:1bf5:: with SMTP id k21mr11235337otb.129.1616410699688; Mon, 22 Mar 2021 03:58:19 -0700 (PDT) MIME-Version: 1.0 References: <1610973703-676-1-git-send-email-gene.chen.richtek@gmail.com> <1610973703-676-3-git-send-email-gene.chen.richtek@gmail.com> In-Reply-To: From: Gene Chen Date: Mon, 22 Mar 2021 18:58:08 +0800 Message-ID: Subject: Re: [PATCH v4 2/2] power: supply: mt6360_charger: add MT6360 charger support To: sre@kernel.org, Matthias Brugger , Rob Herring Cc: linux-pm@vger.kernel.org, devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Gene Chen , Wilma.Wu@mediatek.com, shufan_lee@richtek.com, ChiYuan Huang , benjamin.chao@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gene Chen =E6=96=BC 2021=E5=B9=B43=E6=9C=882= =E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=883:27=E5=AF=AB=E9=81=93=EF=BC= =9A > > Gene Chen =E6=96=BC 2021=E5=B9=B41=E6=9C=88= 18=E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=888:42=E5=AF=AB=E9=81=93=EF= =BC=9A > > > > From: Gene Chen > > > > Add basic support for the battery charger for MT6360 PMIC > > > > Signed-off-by: Gene Chen > > --- > > drivers/power/supply/Kconfig | 10 + > > drivers/power/supply/Makefile | 1 + > > drivers/power/supply/mt6360_charger.c | 914 ++++++++++++++++++++++++++= ++++++++ > > 3 files changed, 925 insertions(+) > > create mode 100644 drivers/power/supply/mt6360_charger.c > > > > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfi= g > > index eec646c..dd63bed 100644 > > --- a/drivers/power/supply/Kconfig > > +++ b/drivers/power/supply/Kconfig > > @@ -567,6 +567,16 @@ config CHARGER_MP2629 > > Battery charger. This driver provides Battery charger power m= anagement > > functions on the systems. > > > > +config CHARGER_MT6360 > > + tristate "Mediatek MT6360 Charger Driver" > > + depends on MFD_MT6360 > > + depends on REGULATOR > > + help > > + Say Y here to enable MT6360 Charger Part. > > + The device supports High-Accuracy Voltage/Current Regulation, > > + Average Input Current Regulation, Battery Tempature Sensing, > > + Over-Temperature Protection, DPDM Detection for BC1.2 > > + > > config CHARGER_QCOM_SMBB > > tristate "Qualcomm Switch-Mode Battery Charger and Boost" > > depends on MFD_SPMI_PMIC || COMPILE_TEST > > diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makef= ile > > index dd4b863..9bd0804 100644 > > --- a/drivers/power/supply/Makefile > > +++ b/drivers/power/supply/Makefile > > @@ -77,6 +77,7 @@ obj-$(CONFIG_CHARGER_MAX77693) +=3D max77693_c= harger.o > > obj-$(CONFIG_CHARGER_MAX8997) +=3D max8997_charger.o > > obj-$(CONFIG_CHARGER_MAX8998) +=3D max8998_charger.o > > obj-$(CONFIG_CHARGER_MP2629) +=3D mp2629_charger.o > > +obj-$(CONFIG_CHARGER_MT6360) +=3D mt6360_charger.o > > obj-$(CONFIG_CHARGER_QCOM_SMBB) +=3D qcom_smbb.o > > obj-$(CONFIG_CHARGER_BQ2415X) +=3D bq2415x_charger.o > > obj-$(CONFIG_CHARGER_BQ24190) +=3D bq24190_charger.o > > diff --git a/drivers/power/supply/mt6360_charger.c b/drivers/power/supp= ly/mt6360_charger.c > > new file mode 100644 > > index 0000000..d80bdad > > --- /dev/null > > +++ b/drivers/power/supply/mt6360_charger.c > > @@ -0,0 +1,914 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2021 MediaTek Inc. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#define MT6360_PMU_CHG_CTRL1 0x311 > > +#define MT6360_PMU_CHG_CTRL2 0x312 > > +#define MT6360_PMU_CHG_CTRL3 0x313 > > +#define MT6360_PMU_CHG_CTRL4 0x314 > > +#define MT6360_PMU_CHG_CTRL5 0x315 > > +#define MT6360_PMU_CHG_CTRL6 0x316 > > +#define MT6360_PMU_CHG_CTRL7 0x317 > > +#define MT6360_PMU_CHG_CTRL8 0x318 > > +#define MT6360_PMU_CHG_CTRL9 0x319 > > +#define MT6360_PMU_CHG_CTRL10 0x31A > > +#define MT6360_PMU_DEVICE_TYPE 0x322 > > +#define MT6360_PMU_USB_STATUS1 0x327 > > +#define MT6360_PMU_CHG_STAT 0x34A > > +#define MT6360_PMU_CHG_CTRL19 0x361 > > +#define MT6360_PMU_FOD_STAT 0x3E7 > > + > > +/* MT6360_PMU_CHG_CTRL1 */ > > +#define MT6360_FSLP_SHFT (3) > > +#define MT6360_FSLP_MASK BIT(MT6360_FSLP_SHFT) > > +#define MT6360_OPA_MODE_SHFT (0) > > +#define MT6360_OPA_MODE_MASK BIT(MT6360_OPA_MODE_SHFT) > > +/* MT6360_PMU_CHG_CTRL2 */ > > +#define MT6360_IINLMTSEL_SHFT (2) > > +#define MT6360_IINLMTSEL_MASK GENMASK(3, 2) > > +/* MT6360_PMU_CHG_CTRL3 */ > > +#define MT6360_IAICR_SHFT (2) > > +#define MT6360_IAICR_MASK GENMASK(7, 2) > > +#define MT6360_ILIM_EN_MASK BIT(0) > > +/* MT6360_PMU_CHG_CTRL4 */ > > +#define MT6360_VOREG_SHFT (1) > > +#define MT6360_VOREG_MASK GENMASK(7, 1) > > +/* MT6360_PMU_CHG_CTRL5 */ > > +#define MT6360_VOBST_MASK GENMASK(7, 2) > > +/* MT6360_PMU_CHG_CTRL6 */ > > +#define MT6360_VMIVR_SHFT (1) > > +#define MT6360_VMIVR_MASK GENMASK(7, 1) > > +/* MT6360_PMU_CHG_CTRL7 */ > > +#define MT6360_ICHG_SHFT (2) > > +#define MT6360_ICHG_MASK GENMASK(7, 2) > > +/* MT6360_PMU_CHG_CTRL8 */ > > +#define MT6360_IPREC_SHFT (0) > > +#define MT6360_IPREC_MASK GENMASK(3, 0) > > +/* MT6360_PMU_CHG_CTRL9 */ > > +#define MT6360_IEOC_SHFT (4) > > +#define MT6360_IEOC_MASK GENMASK(7, 4) > > +/* MT6360_PMU_CHG_CTRL10 */ > > +#define MT6360_OTG_OC_MASK GENMASK(3, 0) > > +/* MT6360_PMU_DEVICE_TYPE */ > > +#define MT6360_USBCHGEN_MASK BIT(7) > > +/* MT6360_PMU_USB_STATUS1 */ > > +#define MT6360_USB_STATUS_SHFT (4) > > +#define MT6360_USB_STATUS_MASK GENMASK(6, 4) > > +/* MT6360_PMU_CHG_STAT */ > > +#define MT6360_CHG_STAT_SHFT (6) > > +#define MT6360_CHG_STAT_MASK GENMASK(7, 6) > > +#define MT6360_VBAT_LVL_MASK BIT(5) > > +/* MT6360_PMU_CHG_CTRL19 */ > > +#define MT6360_VINOVP_SHFT (5) > > +#define MT6360_VINOVP_MASK GENMASK(6, 5) > > +/* MT6360_PMU_FOD_STAT */ > > +#define MT6360_CHRDET_EXT_MASK BIT(4) > > + > > +/* uV */ > > +#define MT6360_VMIVR_MIN 3900000 > > +#define MT6360_VMIVR_MAX 13400000 > > +#define MT6360_VMIVR_STEP 100000 > > +/* uA */ > > +#define MT6360_ICHG_MIN 100000 > > +#define MT6360_ICHG_MAX 5000000 > > +#define MT6360_ICHG_STEP 100000 > > +/* uV */ > > +#define MT6360_VOREG_MIN 3900000 > > +#define MT6360_VOREG_MAX 4710000 > > +#define MT6360_VOREG_STEP 10000 > > +/* uA */ > > +#define MT6360_AICR_MIN 100000 > > +#define MT6360_AICR_MAX 3250000 > > +#define MT6360_AICR_STEP 50000 > > +/* uA */ > > +#define MT6360_IPREC_MIN 100000 > > +#define MT6360_IPREC_MAX 850000 > > +#define MT6360_IPREC_STEP 50000 > > +/* uA */ > > +#define MT6360_IEOC_MIN 100000 > > +#define MT6360_IEOC_MAX 850000 > > +#define MT6360_IEOC_STEP 50000 > > + > > +struct mt6360_chg_info { > > + struct device *dev; > > + struct regmap *regmap; > > + struct power_supply_desc psy_desc; > > + struct power_supply *psy; > > + struct regulator_dev *otg_rdev; > > + struct mutex chgdet_lock; > > + u32 vinovp; > > + bool pwr_rdy; > > + bool bc12_en; > > + int psy_usb_type; > > + struct work_struct chrdet_work; > > +}; > > + > > +enum mt6360_iinlmtsel { > > + MT6360_IINLMTSEL_AICR_3250 =3D 0, > > + MT6360_IINLMTSEL_CHG_TYPE, > > + MT6360_IINLMTSEL_AICR, > > + MT6360_IINLMTSEL_LOWER_LEVEL, > > +}; > > + > > +enum mt6360_pmu_chg_type { > > + MT6360_CHG_TYPE_NOVBUS =3D 0, > > + MT6360_CHG_TYPE_UNDER_GOING, > > + MT6360_CHG_TYPE_SDP, > > + MT6360_CHG_TYPE_SDPNSTD, > > + MT6360_CHG_TYPE_DCP, > > + MT6360_CHG_TYPE_CDP, > > + MT6360_CHG_TYPE_DISABLE_BC12, > > + MT6360_CHG_TYPE_MAX, > > +}; > > + > > +static enum power_supply_usb_type mt6360_charger_usb_types[] =3D { > > + POWER_SUPPLY_USB_TYPE_UNKNOWN, > > + POWER_SUPPLY_USB_TYPE_SDP, > > + POWER_SUPPLY_USB_TYPE_DCP, > > + POWER_SUPPLY_USB_TYPE_CDP, > > +}; > > + > > +static unsigned int mt6360_map_reg_sel(u32 data, u32 min, u32 max, u32= step) > > +{ > > + u32 target =3D 0, max_sel; > > + > > + if (data >=3D min) { > > + target =3D (data - min) / step; > > + max_sel =3D (max - min) / step; > > + if (target > max_sel) > > + target =3D max_sel; > > + } > > + return target; > > +} > > + > > +static u32 mt6360_map_real_val(u32 sel, u32 min, u32 max, u32 step) > > +{ > > + u32 target =3D 0; > > + > > + target =3D min + (sel * step); > > + if (target > max) > > + target =3D max; > > + return target; > > +} > > + > > +static int mt6360_get_chrdet_ext_stat(struct mt6360_chg_info *mci, > > + bool *pwr_rdy) > > +{ > > + int ret; > > + unsigned int regval; > > + > > + ret =3D regmap_read(mci->regmap, MT6360_PMU_FOD_STAT, ®val); > > + if (ret < 0) > > + return ret; > > + *pwr_rdy =3D (regval & MT6360_CHRDET_EXT_MASK) ? true : false; > > + return 0; > > +} > > + > > +static int mt6360_charger_get_online(struct mt6360_chg_info *mci, > > + union power_supply_propval *val) > > +{ > > + int ret; > > + bool pwr_rdy; > > + > > + ret =3D mt6360_get_chrdet_ext_stat(mci, &pwr_rdy); > > + if (ret < 0) > > + return ret; > > + val->intval =3D pwr_rdy ? true : false; > > + return 0; > > +} > > + > > +static int mt6360_charger_get_status(struct mt6360_chg_info *mci, > > + union power_supply_propval *val) > > +{ > > + int status, ret; > > + unsigned int regval; > > + bool pwr_rdy; > > + > > + ret =3D mt6360_get_chrdet_ext_stat(mci, &pwr_rdy); > > + if (ret < 0) > > + return ret; > > + if (!pwr_rdy) { > > + status =3D POWER_SUPPLY_STATUS_DISCHARGING; > > + goto out; > > + } > > + > > + ret =3D regmap_read(mci->regmap, MT6360_PMU_CHG_STAT, ®val); > > + if (ret < 0) > > + return ret; > > + regval &=3D MT6360_CHG_STAT_MASK; > > + regval >>=3D MT6360_CHG_STAT_SHFT; > > + switch (regval) { > > + case 0x0: > > + status =3D POWER_SUPPLY_STATUS_NOT_CHARGING; > > + break; > > + case 0x1: > > + status =3D POWER_SUPPLY_STATUS_CHARGING; > > + break; > > + case 0x2: > > + status =3D POWER_SUPPLY_STATUS_FULL; > > + break; > > + default: > > + ret =3D -EIO; > > + } > > +out: > > + if (!ret) > > + val->intval =3D status; > > + return ret; > > +} > > + > > +static int mt6360_charger_get_charge_type(struct mt6360_chg_info *mci, > > + union power_supply_propval *v= al) > > +{ > > + int type, ret; > > + unsigned int regval; > > + u8 chg_stat; > > + > > + ret =3D regmap_read(mci->regmap, MT6360_PMU_CHG_STAT, ®val); > > + if (ret < 0) > > + return ret; > > + > > + chg_stat =3D (regval & MT6360_CHG_STAT_MASK) >> MT6360_CHG_STAT= _SHFT; > > + switch (chg_stat) { > > + case 0x01: /* Charge in Progress */ > > + if (regval & MT6360_VBAT_LVL_MASK) > > + type =3D POWER_SUPPLY_CHARGE_TYPE_FAST; > > + else > > + type =3D POWER_SUPPLY_CHARGE_TYPE_TRICKLE; > > + break; > > + case 0x00: /* Not Charging */ > > + case 0x02: /* Charge Done */ > > + case 0x03: /* Charge Fault */ > > + default: > > + type =3D POWER_SUPPLY_CHARGE_TYPE_NONE; > > + break; > > + } > > + > > + val->intval =3D type; > > + return 0; > > +} > > + > > +static int mt6360_charger_get_ichg(struct mt6360_chg_info *mci, > > + union power_supply_propval *val) > > +{ > > + int ret; > > + unsigned int regval; > > + > > + ret =3D regmap_read(mci->regmap, MT6360_PMU_CHG_CTRL7, ®val)= ; > > + if (ret < 0) > > + return ret; > > + regval =3D (regval & MT6360_ICHG_MASK) >> MT6360_ICHG_SHFT; > > + val->intval =3D mt6360_map_real_val(regval, > > + MT6360_ICHG_MIN, > > + MT6360_ICHG_MAX, > > + MT6360_ICHG_STEP); > > + return 0; > > +} > > + > > +static int mt6360_charger_get_max_ichg(struct mt6360_chg_info *mci, > > + union power_supply_propval *val) > > +{ > > + val->intval =3D MT6360_ICHG_MAX; > > + return 0; > > +} > > + > > +static int mt6360_charger_get_cv(struct mt6360_chg_info *mci, > > + union power_supply_propval *val) > > +{ > > + int ret; > > + unsigned int regval; > > + > > + ret =3D regmap_read(mci->regmap, MT6360_PMU_CHG_CTRL4, ®val)= ; > > + if (ret < 0) > > + return ret; > > + regval =3D (regval & MT6360_VOREG_MASK) >> MT6360_VOREG_SHFT; > > + val->intval =3D mt6360_map_real_val(regval, > > + MT6360_VOREG_MIN, > > + MT6360_VOREG_MAX, > > + MT6360_VOREG_STEP); > > + return 0; > > +} > > + > > +static int mt6360_charger_get_max_cv(struct mt6360_chg_info *mci, > > + union power_supply_propval *val) > > +{ > > + val->intval =3D MT6360_VOREG_MAX; > > + return 0; > > +} > > + > > +static int mt6360_charger_get_aicr(struct mt6360_chg_info *mci, > > + union power_supply_propval *val) > > +{ > > + int ret; > > + unsigned int regval; > > + > > + ret =3D regmap_read(mci->regmap, MT6360_PMU_CHG_CTRL3, ®val)= ; > > + if (ret < 0) > > + return ret; > > + regval =3D (regval & MT6360_IAICR_MASK) >> MT6360_IAICR_SHFT; > > + val->intval =3D mt6360_map_real_val(regval, > > + MT6360_AICR_MIN, > > + MT6360_AICR_MAX, > > + MT6360_AICR_STEP); > > + return 0; > > +} > > + > > +static int mt6360_charger_get_mivr(struct mt6360_chg_info *mci, > > + union power_supply_propval *val) > > +{ > > + int ret; > > + unsigned int regval; > > + > > + ret =3D regmap_read(mci->regmap, MT6360_PMU_CHG_CTRL6, ®val)= ; > > + if (ret < 0) > > + return ret; > > + regval =3D (regval & MT6360_VMIVR_MASK) >> MT6360_VMIVR_SHFT; > > + val->intval =3D mt6360_map_real_val(regval, > > + MT6360_VMIVR_MIN, > > + MT6360_VMIVR_MAX, > > + MT6360_VMIVR_STEP); > > + return 0; > > +} > > + > > +static int mt6360_charger_get_iprechg(struct mt6360_chg_info *mci, > > + union power_supply_propval *val) > > +{ > > + int ret; > > + unsigned int regval; > > + > > + ret =3D regmap_read(mci->regmap, MT6360_PMU_CHG_CTRL8, ®val)= ; > > + if (ret < 0) > > + return ret; > > + regval =3D (regval & MT6360_IPREC_MASK) >> MT6360_IPREC_SHFT; > > + val->intval =3D mt6360_map_real_val(regval, > > + MT6360_IPREC_MIN, > > + MT6360_IPREC_MAX, > > + MT6360_IPREC_STEP); > > + return 0; > > +} > > + > > +static int mt6360_charger_get_ieoc(struct mt6360_chg_info *mci, > > + union power_supply_propval *val) > > +{ > > + int ret; > > + unsigned int regval; > > + > > + ret =3D regmap_read(mci->regmap, MT6360_PMU_CHG_CTRL9, ®val)= ; > > + if (ret < 0) > > + return ret; > > + regval =3D (regval & MT6360_IEOC_MASK) >> MT6360_IEOC_SHFT; > > + val->intval =3D mt6360_map_real_val(regval, > > + MT6360_IEOC_MIN, > > + MT6360_IEOC_MAX, > > + MT6360_IEOC_STEP); > > + return 0; > > +} > > + > > +static int mt6360_charger_set_online(struct mt6360_chg_info *mci, > > + const union power_supply_propval *= val) > > +{ > > + u8 force_sleep =3D val->intval ? 0 : 1; > > + > > + return regmap_update_bits(mci->regmap, > > + MT6360_PMU_CHG_CTRL1, > > + MT6360_FSLP_MASK, > > + force_sleep << MT6360_FSLP_SHFT); > > +} > > + > > +static int mt6360_charger_set_ichg(struct mt6360_chg_info *mci, > > + const union power_supply_propval *va= l) > > +{ > > + u8 sel; > > + > > + sel =3D mt6360_map_reg_sel(val->intval, > > + MT6360_ICHG_MIN, > > + MT6360_ICHG_MAX, > > + MT6360_ICHG_STEP); > > + return regmap_update_bits(mci->regmap, > > + MT6360_PMU_CHG_CTRL7, > > + MT6360_ICHG_MASK, > > + sel << MT6360_ICHG_SHFT); > > +} > > + > > +static int mt6360_charger_set_cv(struct mt6360_chg_info *mci, > > + const union power_supply_propval *val) > > +{ > > + u8 sel; > > + > > + sel =3D mt6360_map_reg_sel(val->intval, > > + MT6360_VOREG_MIN, > > + MT6360_VOREG_MAX, > > + MT6360_VOREG_STEP); > > + return regmap_update_bits(mci->regmap, > > + MT6360_PMU_CHG_CTRL4, > > + MT6360_VOREG_MASK, > > + sel << MT6360_VOREG_SHFT); > > +} > > + > > +static int mt6360_charger_set_aicr(struct mt6360_chg_info *mci, > > + const union power_supply_propval *va= l) > > +{ > > + u8 sel; > > + > > + sel =3D mt6360_map_reg_sel(val->intval, > > + MT6360_AICR_MIN, > > + MT6360_AICR_MAX, > > + MT6360_AICR_STEP); > > + return regmap_update_bits(mci->regmap, > > + MT6360_PMU_CHG_CTRL3, > > + MT6360_IAICR_MASK, > > + sel << MT6360_IAICR_SHFT); > > +} > > + > > +static int mt6360_charger_set_mivr(struct mt6360_chg_info *mci, > > + const union power_supply_propval *va= l) > > +{ > > + u8 sel; > > + > > + sel =3D mt6360_map_reg_sel(val->intval, > > + MT6360_VMIVR_MIN, > > + MT6360_VMIVR_MAX, > > + MT6360_VMIVR_STEP); > > + return regmap_update_bits(mci->regmap, > > + MT6360_PMU_CHG_CTRL3, > > + MT6360_VMIVR_MASK, > > + sel << MT6360_VMIVR_SHFT); > > +} > > + > > +static int mt6360_charger_set_iprechg(struct mt6360_chg_info *mci, > > + const union power_supply_propval = *val) > > +{ > > + u8 sel; > > + > > + sel =3D mt6360_map_reg_sel(val->intval, > > + MT6360_IPREC_MIN, > > + MT6360_IPREC_MAX, > > + MT6360_IPREC_STEP); > > + return regmap_update_bits(mci->regmap, > > + MT6360_PMU_CHG_CTRL8, > > + MT6360_IPREC_MASK, > > + sel << MT6360_IPREC_SHFT); > > +} > > + > > +static int mt6360_charger_set_ieoc(struct mt6360_chg_info *mci, > > + const union power_supply_propval *va= l) > > +{ > > + u8 sel; > > + > > + sel =3D mt6360_map_reg_sel(val->intval, > > + MT6360_IEOC_MIN, > > + MT6360_IEOC_MAX, > > + MT6360_IEOC_STEP); > > + return regmap_update_bits(mci->regmap, > > + MT6360_PMU_CHG_CTRL9, > > + MT6360_IEOC_MASK, > > + sel << MT6360_IEOC_SHFT); > > +} > > + > > +static int mt6360_charger_get_property(struct power_supply *psy, > > + enum power_supply_property psp, > > + union power_supply_propval *val) > > +{ > > + struct mt6360_chg_info *mci =3D power_supply_get_drvdata(psy); > > + int ret =3D 0; > > + > > + switch (psp) { > > + case POWER_SUPPLY_PROP_ONLINE: > > + ret =3D mt6360_charger_get_online(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_STATUS: > > + ret =3D mt6360_charger_get_status(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_CHARGE_TYPE: > > + ret =3D mt6360_charger_get_charge_type(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT: > > + ret =3D mt6360_charger_get_ichg(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX: > > + ret =3D mt6360_charger_get_max_ichg(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE: > > + ret =3D mt6360_charger_get_cv(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX: > > + ret =3D mt6360_charger_get_max_cv(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: > > + ret =3D mt6360_charger_get_aicr(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT: > > + ret =3D mt6360_charger_get_mivr(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_PRECHARGE_CURRENT: > > + ret =3D mt6360_charger_get_iprechg(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT: > > + ret =3D mt6360_charger_get_ieoc(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_USB_TYPE: > > + val->intval =3D mci->psy_usb_type; > > + break; > > + default: > > + ret =3D -ENODATA; > > + } > > + return ret; > > +} > > + > > +static int mt6360_charger_set_property(struct power_supply *psy, > > + enum power_supply_property psp, > > + const union power_supply_propval= *val) > > +{ > > + struct mt6360_chg_info *mci =3D power_supply_get_drvdata(psy); > > + int ret; > > + > > + switch (psp) { > > + case POWER_SUPPLY_PROP_ONLINE: > > + ret =3D mt6360_charger_set_online(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT: > > + ret =3D mt6360_charger_set_ichg(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE: > > + ret =3D mt6360_charger_set_cv(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: > > + ret =3D mt6360_charger_set_aicr(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT: > > + ret =3D mt6360_charger_set_mivr(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_PRECHARGE_CURRENT: > > + ret =3D mt6360_charger_set_iprechg(mci, val); > > + break; > > + case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT: > > + ret =3D mt6360_charger_set_ieoc(mci, val); > > + break; > > + default: > > + ret =3D -EINVAL; > > + } > > + return ret; > > +} > > + > > +static int mt6360_charger_property_is_writeable(struct power_supply *p= sy, > > + enum power_supply_proper= ty psp) > > +{ > > + switch (psp) { > > + case POWER_SUPPLY_PROP_ONLINE: > > + case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT: > > + case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE: > > + case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: > > + case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT: > > + case POWER_SUPPLY_PROP_PRECHARGE_CURRENT: > > + case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT: > > + return 1; > > + default: > > + return 0; > > + } > > +} > > + > > +static enum power_supply_property mt6360_charger_properties[] =3D { > > + POWER_SUPPLY_PROP_ONLINE, > > + POWER_SUPPLY_PROP_STATUS, > > + POWER_SUPPLY_PROP_CHARGE_TYPE, > > + POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT, > > + POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX, > > + POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE, > > + POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX, > > + POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT, > > + POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT, > > + POWER_SUPPLY_PROP_PRECHARGE_CURRENT, > > + POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT, > > + POWER_SUPPLY_PROP_USB_TYPE, > > +}; > > + > > +static const struct power_supply_desc mt6360_charger_desc =3D { > > + .type =3D POWER_SUPPLY_TYPE_USB, > > + .properties =3D mt6360_charger_properties, > > + .num_properties =3D ARRAY_SIZE(mt6360_charger_propertie= s), > > + .get_property =3D mt6360_charger_get_property, > > + .set_property =3D mt6360_charger_set_property, > > + .property_is_writeable =3D mt6360_charger_property_is_writeabl= e, > > + .usb_types =3D mt6360_charger_usb_types, > > + .num_usb_types =3D ARRAY_SIZE(mt6360_charger_usb_types= ), > > +}; > > + > > +static const struct regulator_ops mt6360_chg_otg_ops =3D { > > + .list_voltage =3D regulator_list_voltage_linear, > > + .enable =3D regulator_enable_regmap, > > + .disable =3D regulator_disable_regmap, > > + .is_enabled =3D regulator_is_enabled_regmap, > > + .set_voltage_sel =3D regulator_set_voltage_sel_regmap, > > + .get_voltage_sel =3D regulator_get_voltage_sel_regmap, > > +}; > > + > > +static const struct regulator_desc mt6360_otg_rdesc =3D { > > + .of_match =3D "usb-otg-vbus", > > + .name =3D "usb-otg-vbus", > > + .ops =3D &mt6360_chg_otg_ops, > > + .owner =3D THIS_MODULE, > > + .type =3D REGULATOR_VOLTAGE, > > + .min_uV =3D 4425000, > > + .uV_step =3D 25000, > > + .n_voltages =3D 57, > > + .vsel_reg =3D MT6360_PMU_CHG_CTRL5, > > + .vsel_mask =3D MT6360_VOBST_MASK, > > + .enable_reg =3D MT6360_PMU_CHG_CTRL1, > > + .enable_mask =3D MT6360_OPA_MODE_MASK, > > +}; > > + > > +static irqreturn_t mt6360_pmu_attach_i_handler(int irq, void *data) > > +{ > > + struct mt6360_chg_info *mci =3D data; > > + int ret; > > + unsigned int usb_status; > > + int last_usb_type; > > + > > + mutex_lock(&mci->chgdet_lock); > > + if (!mci->bc12_en) { > > + dev_warn(mci->dev, "Received attach interrupt, bc12 dis= abled, ignore irq\n"); > > + goto out; > > + } > > + last_usb_type =3D mci->psy_usb_type; > > + /* Plug in */ > > + ret =3D regmap_read(mci->regmap, MT6360_PMU_USB_STATUS1, &usb_s= tatus); > > + if (ret < 0) > > + goto out; > > + usb_status &=3D MT6360_USB_STATUS_MASK; > > + usb_status >>=3D MT6360_USB_STATUS_SHFT; > > + switch (usb_status) { > > + case MT6360_CHG_TYPE_NOVBUS: > > + dev_dbg(mci->dev, "Received attach interrupt, no vbus\n= "); > > + goto out; > > + case MT6360_CHG_TYPE_UNDER_GOING: > > + dev_dbg(mci->dev, "Received attach interrupt, under goi= ng...\n"); > > + goto out; > > + case MT6360_CHG_TYPE_SDP: > > + mci->psy_usb_type =3D POWER_SUPPLY_USB_TYPE_SDP; > > + break; > > + case MT6360_CHG_TYPE_SDPNSTD: > > + mci->psy_usb_type =3D POWER_SUPPLY_USB_TYPE_SDP; > > + break; > > + case MT6360_CHG_TYPE_CDP: > > + mci->psy_usb_type =3D POWER_SUPPLY_USB_TYPE_CDP; > > + break; > > + case MT6360_CHG_TYPE_DCP: > > + mci->psy_usb_type =3D POWER_SUPPLY_USB_TYPE_DCP; > > + break; > > + case MT6360_CHG_TYPE_DISABLE_BC12: > > + dev_dbg(mci->dev, "Received attach interrupt, bc12 dete= ct not enable\n"); > > + goto out; > > + default: > > + dev_dbg(mci->dev, "Received attach interrupt, reserved = address\n"); > > + goto out; > > + } > > + > > + dev_dbg(mci->dev, "Received attach interrupt, chg_type =3D %d\n= ", mci->psy_usb_type); > > + if (last_usb_type !=3D mci->psy_usb_type) > > + power_supply_changed(mci->psy); > > +out: > > + mutex_unlock(&mci->chgdet_lock); > > + return IRQ_HANDLED; > > +} > > + > > +static void mt6360_handle_chrdet_ext_evt(struct mt6360_chg_info *mci) > > +{ > > + int ret; > > + bool pwr_rdy; > > + > > + mutex_lock(&mci->chgdet_lock); > > + ret =3D mt6360_get_chrdet_ext_stat(mci, &pwr_rdy); > > + if (ret < 0) > > + goto out; > > + if (mci->pwr_rdy =3D=3D pwr_rdy) { > > + dev_dbg(mci->dev, "Received vbus interrupt, pwr_rdy is = same(%d)\n", pwr_rdy); > > + goto out; > > + } > > + mci->pwr_rdy =3D pwr_rdy; > > + dev_dbg(mci->dev, "Received vbus interrupt, pwr_rdy =3D %d\n", = pwr_rdy); > > + if (!pwr_rdy) { > > + mci->psy_usb_type =3D POWER_SUPPLY_USB_TYPE_UNKNOWN; > > + power_supply_changed(mci->psy); > > + > > + } > > + ret =3D regmap_update_bits(mci->regmap, > > + MT6360_PMU_DEVICE_TYPE, > > + MT6360_USBCHGEN_MASK, > > + pwr_rdy ? MT6360_USBCHGEN_MASK : 0); > > + if (ret < 0) > > + goto out; > > + mci->bc12_en =3D pwr_rdy; > > +out: > > + mutex_unlock(&mci->chgdet_lock); > > +} > > + > > +static void mt6360_chrdet_work(struct work_struct *work) > > +{ > > + struct mt6360_chg_info *mci =3D (struct mt6360_chg_info *)conta= iner_of( > > + work, struct mt6360_chg_info, chrd= et_work); > > + > > + mt6360_handle_chrdet_ext_evt(mci); > > +} > > + > > +static irqreturn_t mt6360_pmu_chrdet_ext_evt_handler(int irq, void *da= ta) > > +{ > > + struct mt6360_chg_info *mci =3D data; > > + > > + mt6360_handle_chrdet_ext_evt(mci); > > + return IRQ_HANDLED; > > +} > > + > > +static int mt6360_chg_irq_register(struct platform_device *pdev) > > +{ > > + const struct { > > + const char *name; > > + irq_handler_t handler; > > + } irq_descs[] =3D { > > + { "attach_i", mt6360_pmu_attach_i_handler }, > > + { "chrdet_ext_evt", mt6360_pmu_chrdet_ext_evt_handler } > > + }; > > + int i, ret; > > + > > + for (i =3D 0; i < ARRAY_SIZE(irq_descs); i++) { > > + ret =3D platform_get_irq_byname(pdev, irq_descs[i].name= ); > > + if (ret < 0) > > + return ret; > > + > > + ret =3D devm_request_threaded_irq(&pdev->dev, ret, NULL= , > > + irq_descs[i].handler, > > + IRQF_TRIGGER_FALLING, > > + irq_descs[i].name, > > + platform_get_drvdata(pd= ev)); > > + if (ret < 0) > > + return dev_err_probe(&pdev->dev, ret, "Failed t= o request %s irq\n", > > + irq_descs[i].name); > > + } > > + > > + return 0; > > +} > > + > > +struct mt6360_field_info { > > + struct device_attribute dev_attr; > > + u16 reg; > > + u8 mask; > > + u8 shft; > > +}; > > + > > +static int mt6360_chg_init_setting(struct mt6360_chg_info *mci) > > +{ > > + int ret; > > + > > + ret =3D regmap_update_bits(mci->regmap, MT6360_PMU_DEVICE_TYPE, > > + MT6360_USBCHGEN_MASK, 0); > > + if (ret) > > + return dev_err_probe(mci->dev, ret, "%s: Failed to disa= ble bc12\n", __func__); > > + ret =3D regmap_update_bits(mci->regmap, MT6360_PMU_CHG_CTRL2, > > + MT6360_IINLMTSEL_MASK, > > + MT6360_IINLMTSEL_AICR << > > + MT6360_IINLMTSEL_SHFT); > > + if (ret) > > + return dev_err_probe(mci->dev, ret, > > + "%s: Failed to switch iinlmtsel to= aicr\n", __func__); > > + usleep_range(5000, 6000); > > + ret =3D regmap_update_bits(mci->regmap, MT6360_PMU_CHG_CTRL3, > > + MT6360_ILIM_EN_MASK, 0); > > + if (ret) > > + return dev_err_probe(mci->dev, ret, > > + "%s: Failed to disable ilim\n", __= func__); > > + ret =3D regmap_update_bits(mci->regmap, MT6360_PMU_CHG_CTRL10, > > + MT6360_OTG_OC_MASK, MT6360_OTG_OC_MASK= ); > > + if (ret) > > + return dev_err_probe(mci->dev, ret, > > + "%s: Failed to config otg oc to 3A= \n", __func__); > > + return 0; > > +} > > + > > +static u32 mt6360_vinovp_trans_to_sel(u32 val) > > +{ > > + u32 vinovp_tbl[] =3D { 5500000, 6500000, 11000000, 14500000 }; > > + int i; > > + > > + /* Select the smaller and equal supported value */ > > + for (i =3D 0; i < ARRAY_SIZE(vinovp_tbl)-1; i++) { > > + if (val < vinovp_tbl[i+1]) > > + break; > > + } > > + return i; > > +} > > + > > +static int mt6360_parse_dt(struct platform_device *pdev) > > +{ > > + struct mt6360_chg_info *mci =3D dev_get_drvdata(&pdev->dev); > > + int ret; > > + > > + ret =3D device_property_read_u32(&pdev->dev, "richtek,vinovp-mi= crovolt", &mci->vinovp); > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, "Failed to parse = vinovp in DT\n"); > > + return ret; > > +} > > + > > +static int mt6360_apply_dt(struct platform_device *pdev) > > +{ > > + struct mt6360_chg_info *mci =3D dev_get_drvdata(&pdev->dev); > > + u32 sel; > > + > > + sel =3D mt6360_vinovp_trans_to_sel(mci->vinovp); > > + return regmap_update_bits(mci->regmap, MT6360_PMU_CHG_CTRL19, > > + MT6360_VINOVP_MASK, sel << MT6360_VIN= OVP_SHFT); > > +} > > + > > +static int mt6360_charger_probe(struct platform_device *pdev) > > +{ > > + struct mt6360_chg_info *mci; > > + struct power_supply_config charger_cfg =3D {}; > > + struct regulator_config config =3D { }; > > + int ret; > > + > > + mci =3D devm_kzalloc(&pdev->dev, sizeof(*mci), GFP_KERNEL); > > + if (!mci) > > + return -ENOMEM; > > + > > + ret =3D mt6360_parse_dt(pdev); > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, "Failed to parse = dt\n"); > > + > > + mci->dev =3D &pdev->dev; > > + mci->vinovp =3D 6500000; > > + mutex_init(&mci->chgdet_lock); > > + platform_set_drvdata(pdev, mci); > > + INIT_WORK(&mci->chrdet_work, &mt6360_chrdet_work); > > + > > + mci->regmap =3D dev_get_regmap(pdev->dev.parent, NULL); > > + if (!mci->regmap) > > + return dev_err_probe(&pdev->dev, -ENODEV, "Failed to ge= t parent regmap\n"); > > + > > + ret =3D mt6360_apply_dt(pdev); > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, "Failed to apply = dt\n"); > > + > > + memcpy(&mci->psy_desc, &mt6360_charger_desc, sizeof(mci->psy_de= sc)); > > + mci->psy_desc.name =3D dev_name(&pdev->dev); > > + charger_cfg.drv_data =3D mci; > > + charger_cfg.of_node =3D pdev->dev.of_node; > > + mci->psy =3D devm_power_supply_register(&pdev->dev, > > + &mci->psy_desc, &charger_= cfg); > > + if (IS_ERR(mci->psy)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(mci->psy), > > + "Failed to register power supply d= ev\n"); > > + > > + ret =3D mt6360_chg_init_setting(mci); > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, "Failed to initia= l setting\n"); > > + > > + schedule_work(&mci->chrdet_work); > > + > > + ret =3D mt6360_chg_irq_register(pdev); > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, "Failed to regist= er irqs\n"); > > + > > + config.dev =3D &pdev->dev; > > + config.regmap =3D mci->regmap; > > + mci->otg_rdev =3D devm_regulator_register(&pdev->dev, &mt6360_o= tg_rdesc, > > + &config); > > + if (IS_ERR(mci->otg_rdev)) > > + return PTR_ERR(mci->otg_rdev); > > + > > + return 0; > > +} > > + > > +static const struct of_device_id __maybe_unused mt6360_charger_of_id[]= =3D { > > + { .compatible =3D "mediatek,mt6360-chg", }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, mt6360_charger_of_id); > > + > > +static const struct platform_device_id mt6360_charger_id[] =3D { > > + { "mt6360-chg", 0 }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(platform, mt6360_charger_id); > > + > > +static struct platform_driver mt6360_charger_driver =3D { > > + .driver =3D { > > + .name =3D "mt6360-chg", > > + .of_match_table =3D of_match_ptr(mt6360_charger_of_id), > > + }, > > + .probe =3D mt6360_charger_probe, > > + .id_table =3D mt6360_charger_id, > > +}; > > +module_platform_driver(mt6360_charger_driver); > > + > > +MODULE_AUTHOR("Gene Chen "); > > +MODULE_DESCRIPTION("MT6360 Charger Driver"); > > +MODULE_LICENSE("GPL"); > > -- > > 2.7.4 > > > > Dear Reviewers, > Is there any change I can fix, please let me know, thanks Is there any update?