Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Mar 2021 12:25:39 +0100
Message-ID: <s5h35wne8gc.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Fengfei Xi <xi.fengfei@h3c.com>
Cc:     <perex@perex.cz>, <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: remove unnecessary blank
In-Reply-To: <20210321085948.11491-1-xi.fengfei@h3c.com>
References: <20210321085948.11491-1-xi.fengfei@h3c.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 21 Mar 2021 09:59:48 +0100,
Fengfei Xi wrote:
> 
> Remove unnecessary blank when calling kmalloc_array().
> 
> Signed-off-by: Fengfei Xi <xi.fengfei@h3c.com>

Thanks for the patch.

We apply this kind of trivial coding-style fix only if it'd improve
the readability significantly or when it's a preliminary work for the
other actual fixes.  So if you'd work on this driver further, let us
know.


Takashi

> ---
>  sound/oss/dmasound/dmasound_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c
> index 49679aa86..78bb9dfe2 100644
> --- a/sound/oss/dmasound/dmasound_core.c
> +++ b/sound/oss/dmasound/dmasound_core.c
> @@ -421,7 +421,7 @@ static int sq_allocate_buffers(struct sound_queue *sq, int num, int size)
>  		return 0;
>  	sq->numBufs = num;
>  	sq->bufSize = size;
> -	sq->buffers = kmalloc_array (num, sizeof(char *), GFP_KERNEL);
> +	sq->buffers = kmalloc_array(num, sizeof(char *), GFP_KERNEL);
>  	if (!sq->buffers)
>  		return -ENOMEM;
>  	for (i = 0; i < num; i++) {
> -- 
> 2.17.1
>