Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Mar 2021 12:34:02 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Johan Hovold <johan@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sam Nobs <samuel.nobs@taitradio.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] serial: imx: drop workaround for forced irq threading
Message-ID: <20210322113402.naqzgkoe2xesnw4b@pengutronix.de>
References: <20210322111036.31966-1-johan@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wf6me76eh66ksbak"
Content-Disposition: inline
In-Reply-To: <20210322111036.31966-1-johan@kernel.org>
Precedence: bulk


--wf6me76eh66ksbak
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 22, 2021 at 12:10:36PM +0100, Johan Hovold wrote:
> Force-threaded interrupt handlers used to run with interrupts enabled,
> something which could lead to deadlocks in case a threaded handler
> shared a lock with code running in hard interrupt context (e.g. timer
> callbacks) and did not explicitly disable interrupts.
>=20
> This was specifically the case for serial drivers that take the port
> lock in their console write path as printk can be called from hard
> interrupt context also with forced threading ("threadirqs").
>=20
> Since commit 81e2073c175b ("genirq: Disable interrupts for force
> threaded handlers") interrupt handlers always run with interrupts
> disabled on non-RT so that drivers no longer need to do handle this.

So we're breaking RT knowingly here? If this is the case I'm not happy
with your change. (And if RT is not affected a different wording would
be good.)

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--wf6me76eh66ksbak
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmBYgKcACgkQwfwUeK3K
7AmnFAf/UTf0HIa8YjVOJLVTqlkCdbExe8cENZWveMj7/3CZDflNU9S+cayKynL1
nDnyZOhtIer1yGqpmWURc7dNuyuIPRUbt3hLlDDjqXwTVHYQ+UokZrceSRw0HFJg
IGpTVsGhJFZ5eNP8VfL4dCpaJ3Ztw/j/xJZecZAuvzrsdMsYKcDFPtTtCahy05nK
Z0mnTqFcJ5uyclx/djBPWwIAOPVTWKq3O7Adarq7O+kooBQ9364v5VFusumHnKlo
rIdK516Zb1HJWTds/wpggmceBbuPUNbsbqAV6+VKufxWnOkjuHn7jCP/C/HCXain
yBxZHl/ID0hqYBR6iYi102kA+sb7GA==
=4pb6
-----END PGP SIGNATURE-----

--wf6me76eh66ksbak--