Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3382077pxf; Mon, 22 Mar 2021 05:15:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyz+p0P/mVcQErW2PulA++21+luL4uwPzz5KqrztlPy/teXDEbOfoIT6oB+dJiZiPMTSDho X-Received: by 2002:a17:906:ca50:: with SMTP id jx16mr19115708ejb.72.1616415333251; Mon, 22 Mar 2021 05:15:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616415333; cv=none; d=google.com; s=arc-20160816; b=GUs2MYCgpNxoKAu1t3Pl/vr0fhKfpuvvtj2ShXcdbmw1L2qcLhs4m9li+kBJVxvMIS 1R7y8HRiPReGM4bkddsfgXCrt1n1Zysqr4K6iTKxVGikVPnnK+J92CUoG24FXzdrhk9O ZTrhqd94kxoa4nWY+d9S+7029XR7spXHPD3RblscOKgjLMQrYkAKLQQwsK4Sv+Dlrts5 etb/S827/kX8S86gak1CBkk6vjQTCtPmMzbk24wODSA1XdPbW1Eo8D5oXp3a29MUo28I RGnd6Tyw7Mq1fmBn4bOit6gMjf+CEUjuUYGTi7fRbnTZz20lHyn5xBd4vlOOQPjGILGP OZEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=AIu6pLDQZor47A62h7BGBpCq89misgvGBsOhNKuoLLQ=; b=co28G29o2HxzoUfhtUYDHmpyIBuh+7F8wOfOuhjHyvFbl18HGDbw8HRmbfOsUguSd9 99x65nc1mpxqbMyNkUJjfhI4puJTBYMvkuZSHCEf1/YQWHSfda9Ruk/ykYM0CoL05FHW QtgFnYVXtwxmGh9O3UncYb/Pn7oSlMsh++YJF7cU0YvoJLXh1rUdoeBClhlOm4beTXKO vGHMWB2nqi5zZeo4miQS/oHnMDUyjQoReSagx2IoKOtozjp7KqkKi4SL5B57VRYE2VSY DZgKJjlWAhbaRohse2Dkyd8a7FgeH99euVZqdRqdaIaKsjPmghlnpsuMiO9xIl7SHPBU y8Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YQSbCTQj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h20si10428509edq.97.2021.03.22.05.15.10; Mon, 22 Mar 2021 05:15:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YQSbCTQj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230164AbhCVMNu (ORCPT + 99 others); Mon, 22 Mar 2021 08:13:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:48628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229905AbhCVMNh (ORCPT ); Mon, 22 Mar 2021 08:13:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 61EBA6198B; Mon, 22 Mar 2021 12:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616415216; bh=2xy/ZpPjOW0oIt6mLviODf/g/JztzLUVzbDrPox2lfE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YQSbCTQjeyS2UqljQkDqZmB9hNuuzGNxqFzi8tBD2j6ueNIDzsiCBtoliDyOuroNX aaSA2/yroenyErha3H67sIq7O7AJys3qFTeKaUiHcTauU5CZnaBlMwWPz4pZYW221x nU8nCIGfiXCckik4WcBuszHK5Qe18fibAQ/Fxcd0ZymHuCn8LyuV7kH+0+27U+bvgH cVm8jHgfFEEQbHFh1PVaKRJo7PKBfAtZKir9yBxtBtfRcVIVixrF5FoO2zLZ6hLdI9 ekTb8DMBqmjxiafWkjIxXQM3TXEuK8Fxn7+pqs0ptkbKS3gpm+Uk5J9AGhIaTYbbIB 8qHqNpr3lwBIQ== Date: Mon, 22 Mar 2021 12:13:31 +0000 From: Mark Brown To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Catalin Marinas , Chen Jun , Marco Elver , Will Deacon Subject: Re: [PATCH] arm64: stacktrace: don't trace arch_stack_walk() Message-ID: <20210322121330.GA4681@sirena.org.uk> References: <20210319184106.5688-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft" Content-Disposition: inline In-Reply-To: <20210319184106.5688-1-mark.rutland@arm.com> X-Cookie: A friend in need is a pest indeed. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/04w6evG8XlLl3ft Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 19, 2021 at 06:41:06PM +0000, Mark Rutland wrote: > We recently converted arm64 to use arch_stack_walk() in commit: >=20 > 5fc57df2f6fd ("arm64: stacktrace: Convert to ARCH_STACKWALK") >=20 > The core stacktrace code expects that (when tracing the current task) > arch_stack_walk() starts a trace at its caller, and does not include > itself in the trace. However, arm64's arch_stack_walk() includes itself, Reviewed-by: Mark Brown --/04w6evG8XlLl3ft Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBYiecACgkQJNaLcl1U h9DEbQf/RW80IksT99bCxlvuUNGMepB0HODebTps3dINdEdl0awUTI6YBtkkgbgf xvpA4kcJhNSyMELjqZ/fW4tleGNcrLP8O11OoUb3+eDqL6s/bvz1eKLoszb+jWDa XMMMjPCq7+gVNwwaSpajrys50UszkyzmlKvq5eE/7rfWHBGdjzRQ8XJwSadHuWg5 0zJEvSQPDGEQZ+158WWs+LwhRDFuMkFs8wtVH0H0Es60AICB4rBPEkI6PLQnh6gg 55SK9zeFuOwxTM1MTd7bgDeI3VugSBf/s0NoBqaC1TdsqYjiUk6bbKtBzpvWMPlZ pvnhkiUq/XGWnYLwbzV/fye8mr1zcw== =gunV -----END PGP SIGNATURE----- --/04w6evG8XlLl3ft--