Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3395832pxf; Mon, 22 Mar 2021 05:35:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxyJXx+Of/RR4iPvPCLtdxe5PHB6F6Kz5fdSTKJkK8m5kisdAj31uvItRd/fj/1g96MQAs X-Received: by 2002:a05:6402:35c8:: with SMTP id z8mr25517257edc.341.1616416532119; Mon, 22 Mar 2021 05:35:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616416532; cv=none; d=google.com; s=arc-20160816; b=rKNMayV5qy2TwUcX1soIER+YWOHzIuakuBmPQcsObO/wz6ztekqFxcqz0pK+DScHwJ 8MhdKXi9ak4eBW7kG9B/nfFbhe/3NkscQcySCdBlEW675Pu3ZqwPZ+wvgrOJo/mmitIe 4vFP0ubfO4OECNSMeKLZZJ+LYa4jCttWqHELt5gOjseztCh+tUohXiBDp9hSfa8cps7K 79XAcT09KoSOagfC+vmpJXb3l/GeFhA9k63OaG3oKigxU0/wlgx0gMwgRXi2hNiiHI6x HQnPn4TE6VcviCf5y6fhOw6MkabnOhrLm86L+fvoUltEEwpxUvEW6lJX+0T0wxphYbKO fj8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Yn8z0qpfrMPdHBYAgP9bqzINTf/PIauPBABoKH9mmXs=; b=yq24NBrJhs0ozPHd+8GdRN75ld4uJvs2aI2YT2Xj/yO0hMfUxV8TeWSEOatuMbVSWW PzxvloLiBtyUiHExMEJmM5t0JG6ayqpHvhG9MHYk0HUGfyv2Bj9jjAOptOtgxsYap3yp xasqjsp64cETwSjbVS8WNlzUEI7iJ/cGJy7jDuzn0nA106eYvjc41ubGXYwuJML7LmQ/ qzX0GdkjwCLT51EAUE4YartOGPZxY2Y+TEe99BQMqUHMnoAKaCcOQ+8P8pPjefFaX4mM LYXr5wp0Hrfxwowg9ifL/506ztLoflU6TtugeotYVF93jZ3nMaNAmI6JQAVpx0+OexBf gbvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sNRY7qS+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q6si10114025ejn.153.2021.03.22.05.35.09; Mon, 22 Mar 2021 05:35:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sNRY7qS+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230459AbhCVMeN (ORCPT + 99 others); Mon, 22 Mar 2021 08:34:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:54840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231464AbhCVMcK (ORCPT ); Mon, 22 Mar 2021 08:32:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B499061994; Mon, 22 Mar 2021 12:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616416330; bh=xxd8MiDf4ZC55mk4M/uP9KN9Sker8aHYPSZIuzYqg4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sNRY7qS+kpaZ7hnUJ59GhBF1Ch87S7BaOK3hpxH7vcw6AmJE4HAJ8PT8lDg5DmrMo VyWAYn9AEPCb+meBeetltMfFIOCpXIE3yykBxvqaOyZJGw4umLsDfYDHDH9O3DNN+/ mlf+0aB7dJtrLCcjFXmx7kFLsAtItW/iKOsd+JoQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Martin K. Petersen" Subject: [PATCH 5.11 064/120] scsi: lpfc: Fix some error codes in debugfs Date: Mon, 22 Mar 2021 13:27:27 +0100 Message-Id: <20210322121931.818924193@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121929.669628946@linuxfoundation.org> References: <20210322121929.669628946@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter commit 19f1bc7edf0f97186810e13a88f5b62069d89097 upstream. If copy_from_user() or kstrtoull() fail then the correct behavior is to return a negative error code. Link: https://lore.kernel.org/r/YEsbU/UxYypVrC7/@mwanda Fixes: f9bb2da11db8 ("[SCSI] lpfc 8.3.27: T10 additions for SLI4") Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/lpfc/lpfc_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c @@ -2421,7 +2421,7 @@ lpfc_debugfs_dif_err_write(struct file * memset(dstbuf, 0, 33); size = (nbytes < 32) ? nbytes : 32; if (copy_from_user(dstbuf, buf, size)) - return 0; + return -EFAULT; if (dent == phba->debug_InjErrLBA) { if ((dstbuf[0] == 'o') && (dstbuf[1] == 'f') && @@ -2430,7 +2430,7 @@ lpfc_debugfs_dif_err_write(struct file * } if ((tmp == 0) && (kstrtoull(dstbuf, 0, &tmp))) - return 0; + return -EINVAL; if (dent == phba->debug_writeGuard) phba->lpfc_injerr_wgrd_cnt = (uint32_t)tmp;