Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3396168pxf; Mon, 22 Mar 2021 05:36:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxd+VQxIr34BM4PinzhzonEGOYPqGl2ELtJ0uP2qrp5TaojS8/6bc/l/eNTC+8awxWLOPCr X-Received: by 2002:a05:6402:704:: with SMTP id w4mr26394709edx.175.1616416563511; Mon, 22 Mar 2021 05:36:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616416563; cv=none; d=google.com; s=arc-20160816; b=Wq0BdzMIAPKj9iAcYnFAQcTKEMU1fRsstDml0vMOs4orBg40xVe+WqeP3VfNoeY/Bs pB/MXOPguB8tJ6yji8H3YnrSqVACOXrfSjiFsLptq9ygmy0H0zNV6Ilaf/GK1VrOSoky O+LjmNR5wQhD6wJ8b6IPhhy9L770QZ+ydYcO8BD65lAgO4tUMWfkgAyr1M3YsuSgsBs+ JE96g8IlK+IYBRXJ55XJB+2TR1v2PTOc+Ha73/Jwo15cVDODlYgSNoUxuoThVyst7NQ9 1s7NBXaONFpFWltKRi59ZZlbBhyDXTG/qoe3PxcBftFHcC2VZJyuWwOXIDgk8tFiKwEr B6WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bF/f2GeyZi8mIiPXBxSXqt8vsDIjCm0zcEH5YwD56xA=; b=utUdwP+ML69dPB6U/I58x9SdQPEBcUosiSrhgCT2zT3FvHcVF5RJ7+a1vzqnLbiiJ7 QTLmlQM0DW60eboKDUJktVG/wuvif9amhYQ9D2SphLDjdpc+bzDhGkTvfc6CxrVveL0p 9pE8GMW77WWgOu+866wZ9Csdqk5iENTYAz9fJzCadx8o2o2SU0/KRoiIknv1Rmc1EGvg Si/t/co+9U3Y254hxRfVCMTIEKYYJCcdVCi/SVMij29IjTQt4PDMsl/d+oLntVLA+dTb E0NSwr483pIhQbzPydileNB0p0IZbGScM7NzgEc1JXARZGZsohAhb8Fr8DcEcpSgo8Kv BYHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hW6NeepU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hc43si11573539ejc.387.2021.03.22.05.35.40; Mon, 22 Mar 2021 05:36:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hW6NeepU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230430AbhCVMem (ORCPT + 99 others); Mon, 22 Mar 2021 08:34:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:54908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231481AbhCVMcT (ORCPT ); Mon, 22 Mar 2021 08:32:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B936C619A0; Mon, 22 Mar 2021 12:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616416338; bh=v604UhnfAOcV6/lLI85/Rvp8vQDeW4X5WTHjoJMBMCE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hW6NeepUnu1FuZHCmTPC3v0uZRTt3+RnHzgyRla4OxOs1x0jNZgun/9crHC2+cBkJ IctciCM1h8zk9Oxd/oMB6frIiId5A7LLe7YqYokd531DaGcW8S6yYZUGwTMcPFJ8Zs ri/ZV/erVcmOthym3Zdg7qSWE372XInJ3ccMsk/g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , "Martin K. Petersen" Subject: [PATCH 5.11 067/120] scsi: mpt3sas: Do not use GFP_KERNEL in atomic context Date: Mon, 22 Mar 2021 13:27:30 +0100 Message-Id: <20210322121931.909896134@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121929.669628946@linuxfoundation.org> References: <20210322121929.669628946@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET commit a50bd64616907ed126ffbdbaa06c5ce708c4a404 upstream. mpt3sas_get_port_by_id() can be called when a spinlock is held. Use GFP_ATOMIC instead of GFP_KERNEL when allocating memory. Issue spotted by call_kern.cocci: ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function mpt3sas_get_port_by_id called on line 7125 inside lock on line 7123 but uses GFP_KERNEL ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function mpt3sas_get_port_by_id called on line 6842 inside lock on line 6839 but uses GFP_KERNEL ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function mpt3sas_get_port_by_id called on line 6854 inside lock on line 6851 but uses GFP_KERNEL ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function mpt3sas_get_port_by_id called on line 7706 inside lock on line 7702 but uses GFP_KERNEL ./drivers/scsi/mpt3sas/mpt3sas_scsih.c:416:42-52: ERROR: function mpt3sas_get_port_by_id called on line 10260 inside lock on line 10256 but uses GFP_KERNEL Link: https://lore.kernel.org/r/20210220093951.905362-1-christophe.jaillet@wanadoo.fr Fixes: 324c122fc0a4 ("scsi: mpt3sas: Add module parameter multipath_on_hba") Signed-off-by: Christophe JAILLET Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -407,7 +407,7 @@ mpt3sas_get_port_by_id(struct MPT3SAS_AD * And add this object to port_table_list. */ if (!ioc->multipath_on_hba) { - port = kzalloc(sizeof(struct hba_port), GFP_KERNEL); + port = kzalloc(sizeof(struct hba_port), GFP_ATOMIC); if (!port) return NULL;