Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3399097pxf; Mon, 22 Mar 2021 05:40:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPFMQyh3rk23NhnDuQEZivRWh+ZG0cnYQfDC1DUV9YfkSSD6Tnai8nd5U4l729H4kQv0V9 X-Received: by 2002:aa7:da14:: with SMTP id r20mr25194446eds.181.1616416820979; Mon, 22 Mar 2021 05:40:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616416820; cv=none; d=google.com; s=arc-20160816; b=sJrMpNyyzyFIFGMp1Uj4J54eEreAJJOSvppId8m/O35Ytb9fxRmRC98GONm1mqNRT/ v1uJSSXscidZ/f4LD4/aIZIYnFQmcS9tcc2xOwZC9gU2Eb6+pIKB/X9d6OqSmAdsiqEI bim3pz3DpE5oxxDkCAV/rizGrz3uT9iyhaItY5zJhfy1d6qCUlGDYwjZNmgKu0fL/Y8g FHLAsLyo3q1zocWghYROyQQKLBIF9XMAp3dUsHOkm2G3vThlylsdwzVBRcFuAn0Ae+xW o78yZX6J0SG+4WPS83SEhypKWey+50jZLYWX4IJg34y35YeOxzKz1Nx5AJYvulE3jO3C kdsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=t+HAb6ZAnKXBZ3HU46F5f+ULyEEjBOVcTh+37ZxeMOE=; b=ohCA5yc129KVBXjybtRXC7mXjJPlA2PzFIj61CUYjuj3suBXkyuAcnZkSCodADH2Yd DXFE6NY4bZP5VvuZJfsjl3Dvk4faQ65AQi81Ju2uzzUaHkxfHqwj1/5gUr1BFOIfD8dp m7Pw4b2MfYYS7qWiALJApIK4fBZIu9/4NsFeXgeNZGStOMgCujaN77ScZKxbXUIWNxpQ ms9lYgOu8b12k3uWCA93hZEkufgIyB8AfIfY0yPGt87NhtOAoNPlSckzS2e3qembpG6n Lp4VnOzSHEkjWx4jUtcByfUno5pY3x74XchL6ilB8HQIV/m4DWBLfjnKaYGGF7rSgm0J 8+IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XbnflXgf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w14si11065590edu.225.2021.03.22.05.39.58; Mon, 22 Mar 2021 05:40:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XbnflXgf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231866AbhCVMhF (ORCPT + 99 others); Mon, 22 Mar 2021 08:37:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:56226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231551AbhCVMdV (ORCPT ); Mon, 22 Mar 2021 08:33:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A6E226199F; Mon, 22 Mar 2021 12:33:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616416398; bh=FKq6rZ2Ke0ICL1Ru4IhqBy/idzzVBl+D9H6u8T9JoC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XbnflXgfTapfJbVFU0+XJL4zijmUcCKJN7T7YJ/OrVv0q4s/prVqSPXBwg28WxQPF lcukMoBxAv8N0B5rt4s0lF5qgYGj6TUNMo78U1uVHKJuRXT4YJCtmVLV0jZRrBuEl4 Ju30snzuQ1T9+JyoPZLsscjfSzJr8OJUeBBXyhF4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Linus Walleij , Jonathan Cameron Subject: [PATCH 5.11 091/120] iio: adc: ab8500-gpadc: Fix off by 10 to 3 Date: Mon, 22 Mar 2021 13:27:54 +0100 Message-Id: <20210322121932.718236252@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121929.669628946@linuxfoundation.org> References: <20210322121929.669628946@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Walleij commit 4f5434086d9223f20b3128a7dc78b35271e76655 upstream. Fix an off by three orders of magnitude error in the AB8500 GPADC driver. Luckily it showed up quite quickly when trying to make use of it. The processed reads were returning microvolts, microamperes and microcelsius instead of millivolts, milliamperes and millicelsius as advertised. Cc: stable@vger.kernel.org Fixes: 07063bbfa98e ("iio: adc: New driver for the AB8500 GPADC") Signed-off-by: Linus Walleij Link: https://lore.kernel.org/r/20201224011700.1059659-1-linus.walleij@linaro.org Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/adc/ab8500-gpadc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/adc/ab8500-gpadc.c +++ b/drivers/iio/adc/ab8500-gpadc.c @@ -918,7 +918,7 @@ static int ab8500_gpadc_read_raw(struct return processed; /* Return millivolt or milliamps or millicentigrades */ - *val = processed * 1000; + *val = processed; return IIO_VAL_INT; }