Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3399170pxf; Mon, 22 Mar 2021 05:40:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyx7n1b437ecyFW4ibQlUrGL6dj/qhsFfFoj8WKnBIoDrrv+lMTT1A0sgqA2rYETY/ZlMUB X-Received: by 2002:a17:906:2314:: with SMTP id l20mr19473664eja.178.1616416828474; Mon, 22 Mar 2021 05:40:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616416828; cv=none; d=google.com; s=arc-20160816; b=E6jbMZ42wr9+iU25cFyr0+D+jkUSQvk0SnjiFVifY7zOBiEoiF+ePMGwvX+ay7Ltc7 OEM+Yv5rU0PiuPqrm76SpYk46KMuGjHovXGAItfV0VnFYDmwDe5IsCRFJbtMFqwbzeQA Ro//aEO330hlpM2C1bVfL2n+Aq61/ogMLNXDAsoh1wb5kWNARP9vo/oDOAsdGae8puuA wZc+2QqmIp63MEBpiYOYaFAFOAO2jxlbtx7G4Cwn81vx1vqqqakVR/5rota7LIQ9TzMB bjAiTI0WCm9Tm1g7GCd0ftL+7KzwqUnHtDRjn9dSndeg3V+iErnYBviWQsiCWgJ7V+Wi dvaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=efM/RcMVkY+0neMb1TqzP5vv+QSQ8B/r4OoHUTT5QjQ=; b=GDPDMC57EHzk2UqAYYWzOs52s1XyWZ5Mo6NGnI6UBmvWefMWJWNGA9zwntY49eZ/mh nWHnZNT3DjA1jOiFT/GAVfikXKfYDH+NNjAdWw+paNLJO/0/5xxX4mdoCkOseKGWcwJR 8/CJVc0FsBShZxWiwQnXG3iO2f3K8N9JA9Ie/YK9SkRrcb56bAx780UsixnQiXbYXPH/ 5JC9YMNIcgevNsyoWmey+b8Y1+WSIcLQlzwOJyyoRKjv6jqHeNcyc/xXPXIGXpJUvaCQ /JNvqXZvZhPh8beIN/fu9cZaO+g3jD83ubKdUDArKBhpfTZfyuhJQ7iISLjCqXSgH3IL 527A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uWgUPeM7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cx24si11509012edb.541.2021.03.22.05.40.06; Mon, 22 Mar 2021 05:40:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uWgUPeM7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231371AbhCVMgz (ORCPT + 99 others); Mon, 22 Mar 2021 08:36:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:56196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231488AbhCVMdS (ORCPT ); Mon, 22 Mar 2021 08:33:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 07D5B61990; Mon, 22 Mar 2021 12:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616416395; bh=Thj2BLnJy/B5q8Mr7PuHRR4CrJMZD4dBO5VAgv42dNU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uWgUPeM782tjnX8PnrmYBzlDgoIYY17h/g2bHSbutzkYxZb4FxrWYeH5KlTxEN6li lWMZ0yLAMd09P/ZzcFnPDrowZXnRV1KEl8VS/wHS4H/szNBlwn71mjAwn+jplhhzuv r0S0xvdvawvQdv+ncB9jgGxKCSDHEpUVIpIbldDo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dinghao Liu , Linus Walleij , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 5.11 090/120] iio: gyro: mpu3050: Fix error handling in mpu3050_trigger_handler Date: Mon, 22 Mar 2021 13:27:53 +0100 Message-Id: <20210322121932.687859713@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121929.669628946@linuxfoundation.org> References: <20210322121929.669628946@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dinghao Liu commit 6dbbbe4cfd398704b72b21c1d4a5d3807e909d60 upstream. There is one regmap_bulk_read() call in mpu3050_trigger_handler that we have caught its return value bug lack further handling. Check and terminate the execution flow just like the other three regmap_bulk_read() calls in this function. Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Signed-off-by: Dinghao Liu Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20210301080421.13436-1-dinghao.liu@zju.edu.cn Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/gyro/mpu3050-core.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -551,6 +551,8 @@ static irqreturn_t mpu3050_trigger_handl MPU3050_FIFO_R, &fifo_values[offset], toread); + if (ret) + goto out_trigger_unlock; dev_dbg(mpu3050->dev, "%04x %04x %04x %04x %04x\n",