Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3402311pxf; Mon, 22 Mar 2021 05:45:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8/8+K1BgiTGl3AfwvQBBfeLfwhOe2D6MylVCVE/PgdqY1lxLm03RUSlaqBYpbfalVx3RU X-Received: by 2002:a17:906:7f01:: with SMTP id d1mr19583674ejr.136.1616417124203; Mon, 22 Mar 2021 05:45:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616417124; cv=none; d=google.com; s=arc-20160816; b=ZA/Z/TEcFAoFiQdPP03xbgzby+XrVDW0uUP+dq2oWQOSbIaVXnoF2+rEXmnHXThV/H ZtYSIlWTQf/THVbnM739x2/8jAQI6QQwnxwTvHDJYl5LHtVMTbdqnC8sERIi5SfrblGb Ckl06PlNYPIy+0dhBfD+i0SeLHaoqe7vkeifPaCZoz07p6ocIiAdhEa6a3496XOaOcLz UjWhLOfe/B7L8/dL4Gp+B4uH/QtHRfGPCuUwv2dghyMTum9mVcW5e4gUIYfKM7Xpi5md UO4lu4ld29vkjJ7IyM7x2NLE3nzY0Lns+rJ/kQTiQE3/YY6s+VXV40ntb7/WD1COPHXl 7z8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=93W2nvO/cmUieHPVvyf6W7eCYqZCzRhF33MJ5McUdcY=; b=Q211nOCeX8+b8r/LevTkhhQFaVM1vbO7oKFYrKjng4+C5aJkietZsnqfE0lxe6/71f RAlz5+FqH/fH+QpSaNtbmNvCJ1DqW0AERfQfIwQKJJL3SRHgR65AHq3MZpniJPaH0CK/ j8EPNuZCLar0vFj2HTBf1zNI9d7+Ss+ewOWubWHMOT5adEJjzbS8L9ORI/Ypf1UZsQkC S3vq0xNBchA95NuXQzXFb/QYR8i5Dzhy8cjuP88hAYuh8rrj1iUprPtifC61NhhuoTd/ /ImDy66sxjQ/3VanIEiPzHlyOeaZX0Nk7HsRKZFsEHDyuVmwMkaqO3lXEdzjpVgHoh6U 1ODQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RZhO2wKW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cx24si11509012edb.541.2021.03.22.05.45.01; Mon, 22 Mar 2021 05:45:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RZhO2wKW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230440AbhCVMoV (ORCPT + 99 others); Mon, 22 Mar 2021 08:44:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:57576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231997AbhCVMhT (ORCPT ); Mon, 22 Mar 2021 08:37:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 66F95619AB; Mon, 22 Mar 2021 12:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616416620; bh=L1ZHneKGMBBfnSCptUGOuoVALo40O+L2+86LCfvOks0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RZhO2wKWFjG/8x0Jm7BsVJP1ZTs+E0m6nur2nySB3s0sId3jnMGCW4luO/PPwN2uF PKw0icJ31iohm83+LiOOAVIPHqXozAS2hBT+be4z/dG7MI8HhmmgyBMurQTiHIjELi 31c55YiRjmWB6ICUf/J7sVREOmum25/h02BvgT+g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Martin K. Petersen" Subject: [PATCH 5.10 056/157] scsi: lpfc: Fix some error codes in debugfs Date: Mon, 22 Mar 2021 13:26:53 +0100 Message-Id: <20210322121935.529415430@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121933.746237845@linuxfoundation.org> References: <20210322121933.746237845@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter commit 19f1bc7edf0f97186810e13a88f5b62069d89097 upstream. If copy_from_user() or kstrtoull() fail then the correct behavior is to return a negative error code. Link: https://lore.kernel.org/r/YEsbU/UxYypVrC7/@mwanda Fixes: f9bb2da11db8 ("[SCSI] lpfc 8.3.27: T10 additions for SLI4") Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/lpfc/lpfc_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c @@ -2423,7 +2423,7 @@ lpfc_debugfs_dif_err_write(struct file * memset(dstbuf, 0, 33); size = (nbytes < 32) ? nbytes : 32; if (copy_from_user(dstbuf, buf, size)) - return 0; + return -EFAULT; if (dent == phba->debug_InjErrLBA) { if ((dstbuf[0] == 'o') && (dstbuf[1] == 'f') && @@ -2432,7 +2432,7 @@ lpfc_debugfs_dif_err_write(struct file * } if ((tmp == 0) && (kstrtoull(dstbuf, 0, &tmp))) - return 0; + return -EINVAL; if (dent == phba->debug_writeGuard) phba->lpfc_injerr_wgrd_cnt = (uint32_t)tmp;