Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3402802pxf; Mon, 22 Mar 2021 05:46:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLJIEil5jhgVUwF/WpxyeInxIGInYXoGC2BWXpetine6GGYw/SjQjHbfWwcdSY4HX32x8t X-Received: by 2002:a05:6402:b41:: with SMTP id bx1mr25663792edb.69.1616417173363; Mon, 22 Mar 2021 05:46:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616417173; cv=none; d=google.com; s=arc-20160816; b=tkk2RMlZVEutPLmqGaPOUZDrdgCRP30iFQzGcTFw/t0AF2BSmVNdx+yrTii6x1fvGm WK3H2tzYmEyFoukHexLnVVEgQCm+1ZaFRUc+6PdHbREiaYPu5ztPjHvh7c/e+vVu6/VV mcSvQMBxEgD8gUz0q/8cEMC9cgleW3mm74UzWIM6KEE5duLLBMVku8lmHKS2iIZK+cjx WuAWq8Gihj4oUO9d40oW/4IZGk7bnsquWj53g4B+PjqZlxG+Z8JWufNYg4d3omLxok6M 9MtBdUQvGPviW981Uj2j4kKu2MBYNKuG9LDBddDjAGL8GTt2iUCQXDm54gsbKOUC0QT0 iPFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=K7vDirgMbq80YiWWIrDMB08T87ChnD4vBWUqW0FLJlo=; b=jWSwxO5t8n5hQoblsY1Hp/QXUd73RreNZf4QiTZP2UReEuKwxGEFQCLW5sIrz8vZ6Y fhYfAxco5E0oYWzTl9cnh5CSxH9LlYVtDrcUR8d7HrObCutoTzd2iBNDwTkaKcFNpryk uDq87ShOyKm3EY6vOQynb9FAVgICkQcJZdnyMG+uV67EZTSRGDiF/MqvmpNIpmwSpB3b 1lCAi+I+DJbxnk/PK/Y3/7IkHpQ9hVLaB5ovaeqT9KqAjKOJpNfDj+2iMeh77w4kACvQ Q15cW29k7pY2oHGV3E3yXrF+Gzlzdzw5RrKh2zYUJEavh4mvW+/AVqkljzv0Y9kDpi7Y okdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MmTNmwmn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n23si11398947ejr.458.2021.03.22.05.45.50; Mon, 22 Mar 2021 05:46:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MmTNmwmn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231244AbhCVMlq (ORCPT + 99 others); Mon, 22 Mar 2021 08:41:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:56922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231316AbhCVMfy (ORCPT ); Mon, 22 Mar 2021 08:35:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9A4D4619AA; Mon, 22 Mar 2021 12:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616416539; bh=ZB97km9wZK85oCKCyWjxtmlx6xbYJF/8/5iRqzEhMIk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MmTNmwmnlaMHwld+fZgYhSMvAeFFaHM3HgOkPhQFceHiKFuAXXISW20Vylah43bGp VVi0zZ9SkBqvTNmr0sgCs6fXtMFKXrK/9aaUfUvvHvVNZxUuAQtiIpmE1ZCnNetBDt 5HDTsT2tj3Bp3GxRYH68YZxNam/rJtuhFN79P/qY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexander Shiyan , Nicolin Chen , Mark Brown Subject: [PATCH 5.10 024/157] ASoC: fsl_ssi: Fix TDM slot setup for I2S mode Date: Mon, 22 Mar 2021 13:26:21 +0100 Message-Id: <20210322121934.537422227@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121933.746237845@linuxfoundation.org> References: <20210322121933.746237845@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Shiyan commit 87263968516fb9507d6215d53f44052627fae8d8 upstream. When using the driver in I2S TDM mode, the _fsl_ssi_set_dai_fmt() function rewrites the number of slots previously set by the fsl_ssi_set_dai_tdm_slot() function to 2 by default. To fix this, let's use the saved slot count value or, if TDM is not used and the slot count is not set, proceed as before. Fixes: 4f14f5c11db1 ("ASoC: fsl_ssi: Fix number of words per frame for I2S-slave mode") Signed-off-by: Alexander Shiyan Acked-by: Nicolin Chen Link: https://lore.kernel.org/r/20210216114221.26635-1-shc_work@mail.ru Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/fsl/fsl_ssi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -878,6 +878,7 @@ static int fsl_ssi_hw_free(struct snd_pc static int _fsl_ssi_set_dai_fmt(struct fsl_ssi *ssi, unsigned int fmt) { u32 strcr = 0, scr = 0, stcr, srcr, mask; + unsigned int slots; ssi->dai_fmt = fmt; @@ -909,10 +910,11 @@ static int _fsl_ssi_set_dai_fmt(struct f return -EINVAL; } + slots = ssi->slots ? : 2; regmap_update_bits(ssi->regs, REG_SSI_STCCR, - SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(2)); + SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(slots)); regmap_update_bits(ssi->regs, REG_SSI_SRCCR, - SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(2)); + SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(slots)); /* Data on rising edge of bclk, frame low, 1clk before data */ strcr |= SSI_STCR_TFSI | SSI_STCR_TSCKP | SSI_STCR_TEFS;