Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3405851pxf; Mon, 22 Mar 2021 05:51:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLQn7x/c47av/niS6py8VUgcidF9816b3fx8xgKmcX1BruGNUn91TU35nhoLPCXfiSU3TS X-Received: by 2002:a17:906:1b42:: with SMTP id p2mr19277350ejg.236.1616417473340; Mon, 22 Mar 2021 05:51:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616417473; cv=none; d=google.com; s=arc-20160816; b=li9ZqVpzj3xGCdS5WkPiIpK1tj2X6sPsOQQSTE+txFa7OJkl8AaUaOVlmmJXLkMofX nbijmWmMssQHO8ZuLfCrGg7VRGFwei81BTbNNhh5n5eZ5x1Lp+pVf9hTDmwfnJsZXYFT P+rUW/yYQ8FY9vie+lNSZPGyrWVnfH0Pkn4cixpQHiX//9GHiM8UMIQZpTzsG5QBJUEV wflnqRq8OuTnNRc0077pCLpbpo/2F4RNd51GCtJu0yRsAoqXagIQhGtdDk2eWV979sdu XqCEgr5mQqcI7Dr9yYzbxzj9i/Jja7wCgYi/ngNCCMo4X/T1vDJgCXg7PO4/fcS8uAfU TPEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BuSQisomI/G0pwo1FRVTHtmE7q9L4VNOFuQxOcTaBNI=; b=JpgW3XGJz1UIdv67Rqn/3D1TOz1MGca0fm9ShEIrTvJfVyluaG0rQLbECs2SpDP/2U io4874WDzCtXwn7MyMXA3x2m3XA+QAx+04TcbOIReBhEuduICj/1qi6UOEGEJNWaeH6g x7mrg62NdvNnuLJ9Y7ux0kCJr1AxPRHhhCLAKdfKn0v6AetjItIK4+Nci0Z0snoxzQ4v iTsrgw4ENpklqrhvI2kljZlgDN9joI8sHfp6gvaV5oG1Y1CRi4k7/6zStYJdbzoW0v8N wUt+NiksQIlY2cwyM67QLhcmZSuwTa1roUBQTSqVnhpdCHa5uFjseCbU+zGfEA4nEsFR C2gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lRBUndT6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b18si11378355edr.358.2021.03.22.05.50.51; Mon, 22 Mar 2021 05:51:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lRBUndT6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231773AbhCVMtg (ORCPT + 99 others); Mon, 22 Mar 2021 08:49:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:35500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231655AbhCVMlP (ORCPT ); Mon, 22 Mar 2021 08:41:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 337CB619C7; Mon, 22 Mar 2021 12:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616416761; bh=NrpVF5lsezzdjANQSxdVnekep3ctTVAmyvjptOnSXj8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lRBUndT6kNDclza2nNkbRmQlpKaQdLZeFmddX8j79/LrUt/qDMJu/Pt9pugbLXBIn jAOFh/vKBbBOoC7ahbrPf2kE09iYT0GMeCU8dHF69Ze4cz6sR8MIv/aP0xcizBXntK bWm5EV4LxAVQWqGyKR+74SepOTksJH8rxCb0Ci9o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kernel test robot , Andrii Nakryiko , Alexei Starovoitov , Yonghong Song , Sasha Levin Subject: [PATCH 5.10 067/157] bpf: Declare __bpf_free_used_maps() unconditionally Date: Mon, 22 Mar 2021 13:27:04 +0100 Message-Id: <20210322121935.889181004@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121933.746237845@linuxfoundation.org> References: <20210322121933.746237845@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrii Nakryiko [ Upstream commit 936f8946bdb48239f4292812d4d2e26c6d328c95 ] __bpf_free_used_maps() is always defined in kernel/bpf/core.c, while include/linux/bpf.h is guarding it behind CONFIG_BPF_SYSCALL. Move it out of that guard region and fix compiler warning. Fixes: a2ea07465c8d ("bpf: Fix missing prog untrack in release_maps") Reported-by: kernel test robot Signed-off-by: Andrii Nakryiko Signed-off-by: Alexei Starovoitov Acked-by: Yonghong Song Link: https://lore.kernel.org/bpf/20210112075520.4103414-4-andrii@kernel.org Signed-off-by: Sasha Levin --- include/linux/bpf.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index 642ce03f19c4..76322b6452c8 100644 --- a/include/linux/bpf.h +++ b/include/linux/bpf.h @@ -1201,8 +1201,6 @@ struct bpf_prog * __must_check bpf_prog_inc_not_zero(struct bpf_prog *prog); void bpf_prog_put(struct bpf_prog *prog); int __bpf_prog_charge(struct user_struct *user, u32 pages); void __bpf_prog_uncharge(struct user_struct *user, u32 pages); -void __bpf_free_used_maps(struct bpf_prog_aux *aux, - struct bpf_map **used_maps, u32 len); void bpf_prog_free_id(struct bpf_prog *prog, bool do_idr_lock); void bpf_map_free_id(struct bpf_map *map, bool do_idr_lock); @@ -1652,6 +1650,9 @@ static inline struct bpf_prog *bpf_prog_get_type(u32 ufd, return bpf_prog_get_type_dev(ufd, type, false); } +void __bpf_free_used_maps(struct bpf_prog_aux *aux, + struct bpf_map **used_maps, u32 len); + bool bpf_prog_get_ok(struct bpf_prog *, enum bpf_prog_type *, bool); int bpf_prog_offload_compile(struct bpf_prog *prog); -- 2.30.1