Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3411754pxf; Mon, 22 Mar 2021 06:00:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylqikuj8Q1Fyv4Wm7zASotuDjvihj0wCvb5gfVxfqWjP36c9m2Fzk7Q7zmK10A4D+dIogw X-Received: by 2002:a19:7403:: with SMTP id v3mr8940561lfe.379.1616418034289; Mon, 22 Mar 2021 06:00:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616418034; cv=none; d=google.com; s=arc-20160816; b=zXVfevEFbKYP78M/guh6KBtcLqrXrB/XxK3Symd+DripaqKj+bCwugmjsU7LqYk2aj sFYLA5kg1xp9/bHF2qFdutnXe0Xm1peLz0SnH6f4njZXnYpwvB3gXyTi+PsaQSr32+Ty lb8JycEswNDY50mhELQzZfLwWhJu8yPxSKTMrcM1QcPNKk8wALNjN+FZKfaeh0ukrLrY iM1EmFdbFtxX1uX7ChHXLt6OxDgBhM6CxnNjGZMpAVpvgX0RlDccqeJ7ZsBxPdVy6ixS WVzIziPr1htaypj+Mman9d8ZKcMULkhtGVxZtkjGbKRgkmOSKD5UHazMytjokb/+wAcU /j7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ye5cCJb+D8rFt8BqGxjzVg9b7Cdz+yJRV9hkwNFB32I=; b=sbIXaednas81nXHa8z2HpMAbXAYb9cN9ox/v0ZemtHQrqAPLlf0P3VDm1gIyqVDrmq WXJiR3+IpLkkyfwfZJ2jqH/Fq5Mv7BgFsSd88AGnkIPvtq1HfAA/jxbN4/FReh6jY34P w9MiahjgCt52AKqM4oXy6VCqEccb/awtioCLypmfRVtu+NvCVcV7art/ueQ3SydxqH+Y XdNZr2PbDseN6ecsl40L9gHWILBeSofyJxNkYAYoYbM3Cxvned+MDrtISdngK/fjTZuV tA0dM602cmu7d4toxmeIMRWkyMArGWntkLjeKe2gxfxpSs8vbHDeUXzs0LK6PbWq1NnA AcaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QEc47Mc8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si11212817ejz.709.2021.03.22.06.00.10; Mon, 22 Mar 2021 06:00:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QEc47Mc8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232573AbhCVMz1 (ORCPT + 99 others); Mon, 22 Mar 2021 08:55:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:40960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230042AbhCVMow (ORCPT ); Mon, 22 Mar 2021 08:44:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BBBBD619E2; Mon, 22 Mar 2021 12:41:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616416910; bh=aoYiavtlJP2pJskaK6NkDrKcbc5G/xS+wV15QxO6LxA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QEc47Mc8YCWW/4EMF456J9cfyZc0Ytu2cZotQjposIlnRb0XsyT223mIOUZeHWvb1 KOg6vVhYnzjEJRUqPitZnAlUwBOHCUvOAREqCQfNrfSOWCCTOPWRl0/ni/A3gtAG6h 7qdLdJL47GpNec5WzhnYdZaAYB1b5vdsHb62Iykg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexander Shiyan , Nicolin Chen , Mark Brown Subject: [PATCH 5.4 13/60] ASoC: fsl_ssi: Fix TDM slot setup for I2S mode Date: Mon, 22 Mar 2021 13:28:01 +0100 Message-Id: <20210322121922.807776259@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121922.372583154@linuxfoundation.org> References: <20210322121922.372583154@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Shiyan commit 87263968516fb9507d6215d53f44052627fae8d8 upstream. When using the driver in I2S TDM mode, the _fsl_ssi_set_dai_fmt() function rewrites the number of slots previously set by the fsl_ssi_set_dai_tdm_slot() function to 2 by default. To fix this, let's use the saved slot count value or, if TDM is not used and the slot count is not set, proceed as before. Fixes: 4f14f5c11db1 ("ASoC: fsl_ssi: Fix number of words per frame for I2S-slave mode") Signed-off-by: Alexander Shiyan Acked-by: Nicolin Chen Link: https://lore.kernel.org/r/20210216114221.26635-1-shc_work@mail.ru Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/fsl/fsl_ssi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -873,6 +873,7 @@ static int fsl_ssi_hw_free(struct snd_pc static int _fsl_ssi_set_dai_fmt(struct fsl_ssi *ssi, unsigned int fmt) { u32 strcr = 0, scr = 0, stcr, srcr, mask; + unsigned int slots; ssi->dai_fmt = fmt; @@ -904,10 +905,11 @@ static int _fsl_ssi_set_dai_fmt(struct f return -EINVAL; } + slots = ssi->slots ? : 2; regmap_update_bits(ssi->regs, REG_SSI_STCCR, - SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(2)); + SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(slots)); regmap_update_bits(ssi->regs, REG_SSI_SRCCR, - SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(2)); + SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(slots)); /* Data on rising edge of bclk, frame low, 1clk before data */ strcr |= SSI_STCR_TFSI | SSI_STCR_TSCKP | SSI_STCR_TEFS;