Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3417025pxf; Mon, 22 Mar 2021 06:06:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOz8BjFKj5p9DtP/R9tTdC3qBJ/zHxZ+FRtGGdeU4PkEkoBkPKIVXhuu5JuJdESc8l7Wmi X-Received: by 2002:a2e:9107:: with SMTP id m7mr9487003ljg.379.1616418379284; Mon, 22 Mar 2021 06:06:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616418379; cv=none; d=google.com; s=arc-20160816; b=gCFTcDUrHLUGZ/ItZYCmwdgfgvRKiwYL8C0CuHUhd4guGr2RkcZ/5Nkp/xj+DK+hFq sFXjBH5JT9QblxYxITLpQCB/NIeKrMhGWEJ9tJMbkxUNyQUaWIEZ6cWdkRNH7m7iYKva d8yzNlFwrPgKI0HoGslz7WwvV/P7zGuRI4F9SBokfpBHoB5tmPxZTkQxrlREZnHjB64H peDVbVmJZRqzShmvZakjmBBQUPOyLAfOGsG/vJr4Fx4kKhppNStc/Elq0QNm7O3ScUuY R9jetYKe1FIPC9UdmHWSOwgOpwYNNP2fBvYFSnwixHTADoUK4vIKdWvXo6zFTMyERkOu j/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ye5cCJb+D8rFt8BqGxjzVg9b7Cdz+yJRV9hkwNFB32I=; b=WK4uhD+U9VZvestjw1GfC2apxFzL2SzmuqPe0C00M7MLC88QRhexYMJU/a10NtkPqD vnN8mTMDbAL8c3KK1sz1sI+k+vEjUmCTE7mryTLRyig7qWGe+bklZqxlYQ9b0S93bIEg D73TGOhFsDP4Zvg6O7SH3ULS3gmp+fuGYEhmmZxRt4g+Q0kIhBfu0jFVIKMXrZIZT1ih H+T0cx6qDnOY3KIZBvNfSJk9voMuJxKC3HeTxKVB/haFUDbB+7cmD/5tDdp3x7fIwgQ9 m3WHEBMkXYj9wVS+TMgJSdu1qXqYytGaHK6vYHXruCVnXw+Oo6aIc87Ar74tXMdJkLVe tL3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="xShEBqx/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cf5si11109343ejb.346.2021.03.22.06.05.44; Mon, 22 Mar 2021 06:06:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="xShEBqx/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229870AbhCVNEl (ORCPT + 99 others); Mon, 22 Mar 2021 09:04:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:47528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231895AbhCVMvO (ORCPT ); Mon, 22 Mar 2021 08:51:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A2919619FB; Mon, 22 Mar 2021 12:45:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616417152; bh=aoYiavtlJP2pJskaK6NkDrKcbc5G/xS+wV15QxO6LxA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xShEBqx/wkzH+RTOsgrDJTgSUSGtoX/NvUF7WyOKw/Wcfe8yjBz9FWSHx6q5dd54j s4LG/QuozKysYFrncglTftuUs4A04OTLNc1eJe9RZOtyQkBiZDyNO1YBUrKAiNLcwT GIjUwemHmzpWaE13KxXr/f40g8Md29QeR6wKp/9Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexander Shiyan , Nicolin Chen , Mark Brown Subject: [PATCH 4.19 13/43] ASoC: fsl_ssi: Fix TDM slot setup for I2S mode Date: Mon, 22 Mar 2021 13:28:27 +0100 Message-Id: <20210322121920.356271653@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121919.936671417@linuxfoundation.org> References: <20210322121919.936671417@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Shiyan commit 87263968516fb9507d6215d53f44052627fae8d8 upstream. When using the driver in I2S TDM mode, the _fsl_ssi_set_dai_fmt() function rewrites the number of slots previously set by the fsl_ssi_set_dai_tdm_slot() function to 2 by default. To fix this, let's use the saved slot count value or, if TDM is not used and the slot count is not set, proceed as before. Fixes: 4f14f5c11db1 ("ASoC: fsl_ssi: Fix number of words per frame for I2S-slave mode") Signed-off-by: Alexander Shiyan Acked-by: Nicolin Chen Link: https://lore.kernel.org/r/20210216114221.26635-1-shc_work@mail.ru Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/fsl/fsl_ssi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -873,6 +873,7 @@ static int fsl_ssi_hw_free(struct snd_pc static int _fsl_ssi_set_dai_fmt(struct fsl_ssi *ssi, unsigned int fmt) { u32 strcr = 0, scr = 0, stcr, srcr, mask; + unsigned int slots; ssi->dai_fmt = fmt; @@ -904,10 +905,11 @@ static int _fsl_ssi_set_dai_fmt(struct f return -EINVAL; } + slots = ssi->slots ? : 2; regmap_update_bits(ssi->regs, REG_SSI_STCCR, - SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(2)); + SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(slots)); regmap_update_bits(ssi->regs, REG_SSI_SRCCR, - SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(2)); + SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(slots)); /* Data on rising edge of bclk, frame low, 1clk before data */ strcr |= SSI_STCR_TFSI | SSI_STCR_TSCKP | SSI_STCR_TEFS;