Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3417181pxf; Mon, 22 Mar 2021 06:06:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzkknvabCyyT0/V4VRHRKyUMWltlJWgE4zdQXBVEoEYZYxs+0wX2CXj1IyWyIozeW60k7i X-Received: by 2002:a17:906:3409:: with SMTP id c9mr19068959ejb.314.1616418389570; Mon, 22 Mar 2021 06:06:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616418389; cv=none; d=google.com; s=arc-20160816; b=xP7dDgT7hIxjwlTUU3fyoSztXgxLQ7WYUPVJzcEPYCsYiYmCg/tHZiG8Fzj3KEAc4s 4HKNdr62Dc9ywhR3c2oIm4fkAcqG7IDh0c7gu3tjIQwnpnjL8b4+2w+HmVstGM9PNnD2 xRtZlBH0BJc0rvLoa96gUjEFYE37BpV66MVqo5rug+j3IHmki9qD3XVfXaXO/ZM/llBU oStMgkvB8hTbQ2Yjv8h7OFzDhBh4gCpVcZdwJ70d0g11d0zTL+k7BE359vADLE051B6M 103SiDkgoQe/K5Gv8zeHaKN/5Pqu/zmHT3b0N4figPuwKAVRKuVYeJmIzSxqARRZmyzY 9Sug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IgRmmq0cwxqpWV0JBbmpKQm6C3B5nS5cBX+vUKhdLzc=; b=tdGFwsht6csyt1pjljaRX6avVVQtba4aKobUdqygzjcT+SCI9x0HCR46pg34G5wDyl L9aL44zEIMLUWQA2vR7zmTL14iFa3hs37tBsmCeB1qXt2yTOeKcNz8y3eJnyZ+oSoz4h 8iBE9KTI/XeO16Uo1YHMUOno2O3ZDoJYhg+QSiVcrUU9LTMAsZTADEKPDVUNMPEd4cdb Xlt/rc8rdRqQaRN548IY9A2nOq+FTn9RAa9/z1xE4jN28jAn2LN/NrfGbfgDhuplzEye 6DKdUn+ZFZd4+w3RgZRP4cjacq1w9j55R29nh3dUOVdrGvnKYpenNW3Z95RAGACbg3OY VtcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZfWBhIrO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z8si11466863edd.550.2021.03.22.06.05.52; Mon, 22 Mar 2021 06:06:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZfWBhIrO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232508AbhCVNBq (ORCPT + 99 others); Mon, 22 Mar 2021 09:01:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:42924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232861AbhCVMsU (ORCPT ); Mon, 22 Mar 2021 08:48:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 13CCC619E7; Mon, 22 Mar 2021 12:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616417080; bh=iCxefx6+WhDS4Eu9hOTQXuw3LTiOFcRqpbF1DGSu1qE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZfWBhIrOX2oJQjqr6euZXkai4TPrp6tNSeCMyMqpoJDGYcVTeu2WJ2nuzJ8yyJcvc dnHPJl6R1wjU9WqUTo9kGr34tDTHQFe6SX0XtIWmg2DjA8iG4AqLZlLmXLbeqp0/Ux 0GcZKX06aGpstS7w55k2sg2XupsQz8GeIw92l1cw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Martin K. Petersen" Subject: [PATCH 4.19 19/43] scsi: lpfc: Fix some error codes in debugfs Date: Mon, 22 Mar 2021 13:28:33 +0100 Message-Id: <20210322121920.548335553@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121919.936671417@linuxfoundation.org> References: <20210322121919.936671417@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter commit 19f1bc7edf0f97186810e13a88f5b62069d89097 upstream. If copy_from_user() or kstrtoull() fail then the correct behavior is to return a negative error code. Link: https://lore.kernel.org/r/YEsbU/UxYypVrC7/@mwanda Fixes: f9bb2da11db8 ("[SCSI] lpfc 8.3.27: T10 additions for SLI4") Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/lpfc/lpfc_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c @@ -1843,7 +1843,7 @@ lpfc_debugfs_dif_err_write(struct file * memset(dstbuf, 0, 33); size = (nbytes < 32) ? nbytes : 32; if (copy_from_user(dstbuf, buf, size)) - return 0; + return -EFAULT; if (dent == phba->debug_InjErrLBA) { if ((buf[0] == 'o') && (buf[1] == 'f') && (buf[2] == 'f')) @@ -1851,7 +1851,7 @@ lpfc_debugfs_dif_err_write(struct file * } if ((tmp == 0) && (kstrtoull(dstbuf, 0, &tmp))) - return 0; + return -EINVAL; if (dent == phba->debug_writeGuard) phba->lpfc_injerr_wgrd_cnt = (uint32_t)tmp;