Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3420224pxf; Mon, 22 Mar 2021 06:09:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxq940OUItmFlLLWHn2zFxgh9D5GjieIFBV0QyR/IIa35QSOsiiE8CUxM6be5b0VPMt/Tsb X-Received: by 2002:a05:6402:278b:: with SMTP id b11mr25680051ede.380.1616418596117; Mon, 22 Mar 2021 06:09:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616418596; cv=none; d=google.com; s=arc-20160816; b=V+f6U47HtI+LUoogR365ADCoif/JEztH6vrrC+ozbMT53mKDic1PqMq8bHfhcadpII MTdChKSDyeOd5mhrJWiSeR7EZx2AE2uayVRVIEdFPuqOLnzIY8keMSfI3v2ogiuntyji WSwx9vJyrgZr80PF0YgiBlxPoMGx4z62nAsmztaTvAK/wTXUjSfpq5UBC+aebuMDrpQ/ dWrgkybG8y/gr7bFiJKUfyCpObFHB67KZTUkdhmfHexRT1JPtHRBdnS7PP4qTzu4ierZ CkhpghrqHihVI7OYh2IfTvO9Z5RQnHn2mZn8g/pUZXTuz6CkuI1ROMJWBTWj+IQEK0MQ 1qSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gbfJbkUF/n8bwYyTn2TutNWCL+EIKTd/nIA7UwhOjrI=; b=x5ZUc2itIC8E0+yM2LkChOaW244ug/sTls4+tvP2QykkG0CvszcgZCAVf4+6iVi8Hr zC5JEQcuq2wBTyfaCJwcAT0ed7AVTba4Br+eLFtkHkMgf7F0mhuC+IsbZvZ4OdN/888M TWmzP+fk0U3RDyeZn7vgD63sCmdYzRKFdHncTlIylWDDGILBgRcZR38+FtJBWamzgDOU hHFDIGV9IE1+ojTunQTbXfJETFvq6qoEtHb2QG34GxnkEVNYC2hBzJ+4lFXhf+LFi1R0 gTVOHLZV2iL6tGboM4L0aXY4FAbKL8R58SbWofo93igGBiYj8j6ZEU1xFwiJkqPDRhbp D97Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=g5yOmKKM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f6si10869702edq.600.2021.03.22.06.09.33; Mon, 22 Mar 2021 06:09:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=g5yOmKKM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233564AbhCVNIW (ORCPT + 99 others); Mon, 22 Mar 2021 09:08:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:47906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231805AbhCVMyH (ORCPT ); Mon, 22 Mar 2021 08:54:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 665E061A0E; Mon, 22 Mar 2021 12:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616417250; bh=j3sCsgsaEGo72nMLCv7/Rxlh6LfdcYG7HGPSO69KWqM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g5yOmKKMqiNN9claXdS+nJEPaKWsf9yPQ2f1eD6mNbxKdmUZ/lYiGv8T/AkrRZVYQ JOmLIoMFE+KL9S++yyn6tLlVWEpWINBN9qdYY8XTFJKZtBKS1JNfWAuon9WgUeaRGy 7h/EuqCIRg6pZq60s3cv/McZjf29vdtvTrhzh8pU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Martin K. Petersen" Subject: [PATCH 4.9 13/25] scsi: lpfc: Fix some error codes in debugfs Date: Mon, 22 Mar 2021 13:29:03 +0100 Message-Id: <20210322121920.822885578@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121920.399826335@linuxfoundation.org> References: <20210322121920.399826335@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter commit 19f1bc7edf0f97186810e13a88f5b62069d89097 upstream. If copy_from_user() or kstrtoull() fail then the correct behavior is to return a negative error code. Link: https://lore.kernel.org/r/YEsbU/UxYypVrC7/@mwanda Fixes: f9bb2da11db8 ("[SCSI] lpfc 8.3.27: T10 additions for SLI4") Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/lpfc/lpfc_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c @@ -1061,7 +1061,7 @@ lpfc_debugfs_dif_err_write(struct file * memset(dstbuf, 0, 33); size = (nbytes < 32) ? nbytes : 32; if (copy_from_user(dstbuf, buf, size)) - return 0; + return -EFAULT; if (dent == phba->debug_InjErrLBA) { if ((buf[0] == 'o') && (buf[1] == 'f') && (buf[2] == 'f')) @@ -1069,7 +1069,7 @@ lpfc_debugfs_dif_err_write(struct file * } if ((tmp == 0) && (kstrtoull(dstbuf, 0, &tmp))) - return 0; + return -EINVAL; if (dent == phba->debug_writeGuard) phba->lpfc_injerr_wgrd_cnt = (uint32_t)tmp;