Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3424850pxf; Mon, 22 Mar 2021 06:15:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+7/pYBSxYrhsiZefRMiH5S9IyZAeH+EJ4tRV2vRBk/ZgsabKA1p0mhoU7EX/RxORLADXR X-Received: by 2002:a17:906:8408:: with SMTP id n8mr18681235ejx.152.1616418910293; Mon, 22 Mar 2021 06:15:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616418910; cv=none; d=google.com; s=arc-20160816; b=I7BbGSqdVUwoLyy51RX8WUDw85u3M//UeE1SBwfJniNZBo2ffMfnQxaYs7XYyritMq wIrfV9gJP6sfTljlpySN43ABtIAT5z+F5vSIPYRv7YbOh1kS+HErIF+NILzkWf81gfVe t77pcAotyRIUn8IpCFUJIIdAuZ5ouIfXg13pwnkK576yrwTgMVtaynUtzjhW2VfUxwPS m1VAgqBf4zBnRay3WBxYNor3zuRN6TZjB2Vl2evyyZK6lX4JA6Vw81ypZ3/jC5xYzRaE gsHFT3ZUQ+7poYckJ98MYJZPIE1Jg9EOrwlesejiyvztZyPlcVYLbCOJ5YJiceKxknDs VVRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9Wm0dfYfGf2PpT3rayyJt80L7ZkrWI9ZIyp2nl7mLCM=; b=vvsBVzbNnvFFSigUjcZqlDrskyRF3Bj2f4mjLTDeT6hML9Ag++0sRnP2V1SEU3gyTD ZUUzW2PP2OSSGP/UXwPPXaMRjfsFfFxcPtKJB9iO9GDk8GGiUqS/hturQwbAc5Zf0z9T yyKlcpojCyoo3II8SfaoxSYALejTz8a3ENCRltXYmtV9KMEyYvaAibSXBXnNDhtNVseA YJqjFHY/a8DcpFEKqKzUspZc7CgmRgpFk8LcsWZQzRD2V6N+AEF0NGBRUIt/brftAB4K cXAveMEkRLLOzXgm3Vl2Vf24jBL9CV7AUr0xWvXVOAjZjIXJLm3NTqd3saJE673MSt/B K6bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="2J1h/b7A"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qh28si11227129ejb.580.2021.03.22.06.14.47; Mon, 22 Mar 2021 06:15:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="2J1h/b7A"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231478AbhCVNNt (ORCPT + 99 others); Mon, 22 Mar 2021 09:13:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:47776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231561AbhCVMvm (ORCPT ); Mon, 22 Mar 2021 08:51:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 94F3961A01; Mon, 22 Mar 2021 12:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616417167; bh=J+YpLjrfFR9D/MzxAuG51HJ0xmdU/gTqnZY1p9sGWx8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2J1h/b7AoCzGOquwSr6AFySBmWRHQuzKwDOTAKblCMBvwE0cUQF/5/UYMyHsTEx0L xovr91CrssUG6NtiTDXNA0RdOrmuRUGnH3ZaVwoZ/YGSzSqPQrIdwQ3FfNTWLq0rJv 3zFus6T4y9Kzx2Twy0NYbVqK7jWrnazzff8tKhJ0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lukas Czerner , Jan Kara , Theodore Tso Subject: [PATCH 4.4 01/14] ext4: handle error of ext4_setup_system_zone() on remount Date: Mon, 22 Mar 2021 13:28:55 +0100 Message-Id: <20210322121919.250604804@linuxfoundation.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210322121919.202392464@linuxfoundation.org> References: <20210322121919.202392464@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Kara commit d176b1f62f242ab259ff665a26fbac69db1aecba upstream. ext4_setup_system_zone() can fail. Handle the failure in ext4_remount(). Reviewed-by: Lukas Czerner Signed-off-by: Jan Kara Link: https://lore.kernel.org/r/20200728130437.7804-2-jack@suse.cz Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -4968,7 +4968,10 @@ static int ext4_remount(struct super_blo ext4_register_li_request(sb, first_not_zeroed); } - ext4_setup_system_zone(sb); + err = ext4_setup_system_zone(sb); + if (err) + goto restore_opts; + if (sbi->s_journal == NULL && !(old_sb_flags & MS_RDONLY)) ext4_commit_super(sb, 1);