Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3432470pxf; Mon, 22 Mar 2021 06:25:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxF1x6OchGKzU4/FfMz4erd4BPt/jGA0qbvfWw5Gl6f2HY7rY3jHXpyKfeEhYfgGzUXjrku X-Received: by 2002:a17:906:f203:: with SMTP id gt3mr18895347ejb.346.1616419509270; Mon, 22 Mar 2021 06:25:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616419509; cv=none; d=google.com; s=arc-20160816; b=yssFdo8b9Yb/h8TrzwhGplFPjiMVy+K1VbD/eW59mr+eHkaCLDIrRZIBGTWD3HSq+o kCku0SQ94PDQvBOFyZ0MhqKi+oza7hNQM6P81UsX4vedsDMAFnrE3gjNLqJsrisW3GFD 9wscWhuZK+PHoJW1NFc1dM4C/yb3wIeI1bCv0yRZFnhmk+ctzbQC5K5E353/V7sQ7+0n bns3iQey+lZsB9tMDtshdwhZVT5LmflETvtUW12PQai8AUvfCQVVwWqKv68Jb8X+IoEl lPsq2Tmy31XIajrtV7VmH0/7chI109OwUyAl6AED9Ke4lh8ZhE/oH5o69e9fiblb/tcM uGKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WL1qy7XT4KAz7tP3eAhsY2SfxQBCvpRYoDI+ccpcCwA=; b=ZyTBpV6sRtMBPsDJvZMWL7baAdyIhAfG077a3icX4J/6BNqoBN3RTqleNxM+B5qmuy TSYgOdm8SWQAMVWgtG4GjKiX87uAOmTCWDryvsmTEvXujLRC8SXjy/7ngRMGxbU4dz+G 9XwpyNXCHkJ+StxKqbyTNnL0/lh94fLQqrSXS2cc66QP9Ib3cAifF5fc02rRd5vb+3DT yI+Y8TkyJT8T5qOHGgllC5Ih1AN7ZuXb7l46qfSlRcUWIQ0x8X4/bOeJv5Ej3vZF8YuT 5RNG+3Hdm+W9ZZyldXBL74ETA6YIim3YB+OIq/VS2RvW2T57D/B5bp41BW/MAI0pWz63 O3dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="d0/Tjs95"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si11995979ejd.203.2021.03.22.06.24.46; Mon, 22 Mar 2021 06:25:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="d0/Tjs95"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231305AbhCVNXr (ORCPT + 99 others); Mon, 22 Mar 2021 09:23:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:38844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231971AbhCVNUN (ORCPT ); Mon, 22 Mar 2021 09:20:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C6CF761930; Mon, 22 Mar 2021 13:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616419213; bh=DEM5m42T6fPO1L4ytDHAvL93o+qWMGXRGdg6w0KHqpM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d0/Tjs95plgTlxflkC/2arhZPTi+AX9eUSqC9/Iet8NbuDjHxh39zImbo+GThacHk g0tSDJCaV4Uf3Z0uC2N8Z5kdFnq2lg0StYVG3ePTW/VUR8oeR9Agsnte+RLgZjD1DE LrsqMBW2mpaA3zkMmAtcrq1SiZeFDrDHJo8orKBgOLOEJ4sy6kKRUSGU5ppAbFXnbT +Z6gc1kHDeSRJI8+kanQpE9xOeN9wqqBnGvY8TUVNM8OfWekznsvwcwm0kJClqxtoS PGqy13QjDqdKYH8McJCNX9CPs4dKXildtYiy+LADPvwLfflZtGQ9JK9mbDSGrP1/tf 1COaFmQG7Tkag== From: Will Deacon To: Pavel Tatashin , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jmorris@namei.org, catalin.marinas@arm.com, tyhicks@linux.microsoft.com Cc: kernel-team@android.com, Will Deacon Subject: Re: [PATCH] arm64: kdump: update ppos when reading elfcorehdr Date: Mon, 22 Mar 2021 13:19:57 +0000 Message-Id: <161641719902.3900979.10337880549161097433.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210319205054.743368-1-pasha.tatashin@soleen.com> References: <20210319205054.743368-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Mar 2021 16:50:54 -0400, Pavel Tatashin wrote: > The ppos points to a position in the old kernel memory (and in case of > arm64 in the crash kernel since elfcorehdr is passed as a segment). The > function should update the ppos by the amount that was read. This bug is > not exposed by accident, but other platforms update this value properly. > So, fix it in ARM64 version of elfcorehdr_read() as well. Applied to arm64 (for-next/fixes), thanks! [1/1] arm64: kdump: update ppos when reading elfcorehdr https://git.kernel.org/arm64/c/141f8202cfa4 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev